add passthrough for collections when fields is enabled

Author: vincentsarago

stac_fastapi/pgstac/core.py

@@ -150,7 +150,7 @@ async def all_collections(  # noqa: C901
             prev=prev_link,
         ).get_links()
 
-        return Collections(
+        collections = Collections(
             collections=linked_collections or [],
             links=links,
             numberMatched=collections_result.get(
@@ -161,6 +161,14 @@ async def all_collections(  # noqa: C901
             ),
         )
 
+        # If we have the `fields` extension enabled
+        # we need to avoid Pydantic validation because the
+        # Items might not be a valid STAC Item objects
+        if fields:
+            return JSONResponse(collections)  # type: ignore
+
+        return collections
+
     async def get_collection(
         self,
         collection_id: str,

tests/api/test_api.py

@@ -274,10 +274,6 @@ async def test_app_query_extension_gte(load_test_data, app_client, load_test_col
 async def test_app_collection_fields_extension(
     load_test_data, app_client, load_test_collection, app
 ):
-    if app.state.settings.enable_response_models:
-        # https://github.com/stac-utils/stac-fastapi-pgstac/issues/328
-        pytest.skip("Skipping test when model_validation is enabled, see #328")
-
     fields = ["title"]
     resp = await app_client.get("/collections", params={"fields": ",".join(fields)})