add offset=0

Author: vincentsarago

stac_fastapi/pgstac/core.py

@@ -134,9 +134,6 @@ async def all_collections(  # noqa: C901
 
                 linked_collections.append(coll)
 
-        if not collections:
-            next_link = None
-
         links = await CollectionSearchPagingLinks(
             request=request,
             next=next_link,

stac_fastapi/pgstac/models/links.py

@@ -206,23 +206,7 @@ def link_prev(self):
         if self.prev is not None:
             method = self.request.method
             if method == "GET":
-                u = urlparse(self.url)
-                params = parse_qs(u.query)
-                params.update(self.prev["body"])
-
-                # if offset is equal to default value (0), drop it
-                if params.get("offset", -1) == 0:
-                    _ = params.pop("offset")
-
-                param_string = unquote(urlencode(params, True))
-                href = ParseResult(
-                    scheme=u.scheme,
-                    netloc=u.netloc,
-                    path=u.path,
-                    params=u.params,
-                    query=param_string,
-                    fragment=u.fragment,
-                ).geturl()
+                href = merge_params(self.url, self.prev["body"])
 
                 # if prev link is equal to this link, skip it
                 if href == self.url:

tests/resources/test_collection.py

@@ -469,7 +469,7 @@ async def test_get_collections_search_pagination(
     assert len(links) == 3
     assert {"root", "self", "previous"} == {link["rel"] for link in links}
     prev_link = list(filter(lambda link: link["rel"] == "previous", links))[0]
-    assert "offset" not in prev_link["href"]
+    assert "offset" in prev_link["href"]
 
     ###################
     # offset=0, should not have next/previous link