Adding default "not implemented" for JSON Patch.

Author: rhysrevans3

stac_fastapi/types/stac_fastapi/types/core.py

@@ -154,7 +154,6 @@ def merge_patch_item(
         """
         ...
 
-    @abc.abstractmethod
     def json_patch_item(
         self,
         collection_id: str,
@@ -174,12 +173,10 @@ def json_patch_item(
         Returns:
             The patched item.
         """
-        ...
+        raise NotImplementedError("JSON Patch not implemented")
 
     @abc.abstractmethod
-    def delete_item(
-        self, item_id: str, collection_id: str, **kwargs
-    ) -> Optional[Union[stac.Item, Response]]:
+    def delete_item(self, item_id: str, collection_id: str, **kwargs) -> Optional[Union[stac.Item, Response]]:
         """Delete an item from a collection.
 
         Called with `DELETE /collections/{collection_id}/items/{item_id}`
@@ -194,9 +191,7 @@ def delete_item(
         ...
 
     @abc.abstractmethod
-    def create_collection(
-        self, collection: Collection, **kwargs
-    ) -> Optional[Union[stac.Collection, Response]]:
+    def create_collection(self, collection: Collection, **kwargs) -> Optional[Union[stac.Collection, Response]]:
         """Create a new collection.
 
         Called with `POST /collections`.
@@ -313,9 +308,7 @@ def json_patch_collection(
         ...
 
     @abc.abstractmethod
-    def delete_collection(
-        self, collection_id: str, **kwargs
-    ) -> Optional[Union[stac.Collection, Response]]:
+    def delete_collection(self, collection_id: str, **kwargs) -> Optional[Union[stac.Collection, Response]]:
         """Delete a collection.
 
         Called with `DELETE /collections/{collection_id}`
@@ -468,9 +461,7 @@ async def json_patch_item(
         ...
 
     @abc.abstractmethod
-    async def delete_item(
-        self, item_id: str, collection_id: str, **kwargs
-    ) -> Optional[Union[stac.Item, Response]]:
+    async def delete_item(self, item_id: str, collection_id: str, **kwargs) -> Optional[Union[stac.Item, Response]]:
         """Delete an item from a collection.
 
         Called with `DELETE /collections/{collection_id}/items/{item_id}`
@@ -485,9 +476,7 @@ async def delete_item(
         ...
 
     @abc.abstractmethod
-    async def create_collection(
-        self, collection: Collection, **kwargs
-    ) -> Optional[Union[stac.Collection, Response]]:
+    async def create_collection(self, collection: Collection, **kwargs) -> Optional[Union[stac.Collection, Response]]:
         """Create a new collection.
 
         Called with `POST /collections`.
@@ -604,9 +593,7 @@ async def json_patch_collection(
         ...
 
     @abc.abstractmethod
-    async def delete_collection(
-        self, collection_id: str, **kwargs
-    ) -> Optional[Union[stac.Collection, Response]]:
+    async def delete_collection(self, collection_id: str, **kwargs) -> Optional[Union[stac.Collection, Response]]:
         """Delete a collection.
 
         Called with `DELETE /collections/{collection_id}`
@@ -696,9 +683,7 @@ class BaseCoreClient(LandingPageMixin, abc.ABC):
         extensions: list of registered api extensions.
     """
 
-    base_conformance_classes: List[str] = attr.ib(
-        factory=lambda: BASE_CONFORMANCE_CLASSES
-    )
+    base_conformance_classes: List[str] = attr.ib(factory=lambda: BASE_CONFORMANCE_CLASSES)
     extensions: List[ApiExtension] = attr.ib(default=attr.Factory(list))
 
     def conformance_classes(self) -> List[str]:
@@ -744,9 +729,7 @@ def landing_page(self, **kwargs) -> stac.LandingPage:
         )
 
         # Add Queryables link
-        if self.extension_is_enabled("FilterExtension") or self.extension_is_enabled(
-            "SearchFilterExtension"
-        ):
+        if self.extension_is_enabled("FilterExtension") or self.extension_is_enabled("SearchFilterExtension"):
             landing_page["links"].append(
                 {
                     "rel": Relations.queryables.value,
@@ -808,9 +791,7 @@ def conformance(self, **kwargs) -> stac.Conformance:
         return stac.Conformance(conformsTo=self.conformance_classes())
 
     @abc.abstractmethod
-    def post_search(
-        self, search_request: BaseSearchPostRequest, **kwargs
-    ) -> stac.ItemCollection:
+    def post_search(self, search_request: BaseSearchPostRequest, **kwargs) -> stac.ItemCollection:
         """Cross catalog search (POST).
 
         Called with `POST /search`.
@@ -916,9 +897,7 @@ class AsyncBaseCoreClient(LandingPageMixin, abc.ABC):
         extensions: list of registered api extensions.
     """
 
-    base_conformance_classes: List[str] = attr.ib(
-        factory=lambda: BASE_CONFORMANCE_CLASSES
-    )
+    base_conformance_classes: List[str] = attr.ib(factory=lambda: BASE_CONFORMANCE_CLASSES)
     extensions: List[ApiExtension] = attr.ib(default=attr.Factory(list))
 
     def conformance_classes(self) -> List[str]:
@@ -954,9 +933,7 @@ async def landing_page(self, **kwargs) -> stac.LandingPage:
         )
 
         # Add Queryables link
-        if self.extension_is_enabled("FilterExtension") or self.extension_is_enabled(
-            "SearchFilterExtension"
-        ):
+        if self.extension_is_enabled("FilterExtension") or self.extension_is_enabled("SearchFilterExtension"):
             landing_page["links"].append(
                 {
                     "rel": Relations.queryables.value,
@@ -1019,9 +996,7 @@ async def conformance(self, **kwargs) -> stac.Conformance:
         return stac.Conformance(conformsTo=self.conformance_classes())
 
     @abc.abstractmethod
-    async def post_search(
-        self, search_request: BaseSearchPostRequest, **kwargs
-    ) -> stac.ItemCollection:
+    async def post_search(self, search_request: BaseSearchPostRequest, **kwargs) -> stac.ItemCollection:
         """Cross catalog search (POST).
 
         Called with `POST /search`.