fix output types (#867)

Author: vincentsarago

CHANGES.md

@@ -6,6 +6,10 @@
 
 - support for python 3.9 and 3.10
 
+### Fixed 
+
+- fixed output type for `api.models.create_request_model` and `api.models.create_get_request_model` methods
+
 ## [6.1.1] - 2025-11-23
 
 ### Fixed 

stac_fastapi/api/stac_fastapi/api/models.py

@@ -33,7 +33,7 @@ def create_request_model(
     extensions: Optional[List[ApiExtension]] = None,
     mixins: Optional[Union[List[Type[BaseModel]], List[Type[APIRequest]]]] = None,
     request_type: Optional[str] = "GET",
-) -> Union[Type[BaseModel], APIRequest]:
+) -> Union[Type[BaseModel], Type[APIRequest]]:
     """Create a pydantic model for validating request bodies."""
     fields = {}
     extension_models = []
@@ -65,7 +65,7 @@ def create_request_model(
 def create_get_request_model(
     extensions: Optional[List[ApiExtension]],
     base_model: BaseSearchGetRequest = BaseSearchGetRequest,
-) -> APIRequest:
+) -> Type[APIRequest]:
     """Wrap create_request_model to create the GET request model."""
 
     return create_request_model(

stac_fastapi/api/tests/test_models.py

@@ -3,18 +3,24 @@
 import pytest
 from fastapi import Depends, FastAPI, HTTPException
 from fastapi.testclient import TestClient
-from pydantic import ValidationError
+from pydantic import BaseModel, ValidationError
 
 from stac_fastapi.api.models import create_get_request_model, create_post_request_model
 from stac_fastapi.extensions.core import FieldsExtension, FilterExtension, SortExtension
-from stac_fastapi.types.search import BaseSearchGetRequest, BaseSearchPostRequest
+from stac_fastapi.types.search import (
+    APIRequest,
+    BaseSearchGetRequest,
+    BaseSearchPostRequest,
+)
 
 
 def test_create_get_request_model():
     request_model = create_get_request_model(
         extensions=[FilterExtension(), FieldsExtension()],
         base_model=BaseSearchGetRequest,
     )
+    assert type(request_model) is type
+    assert issubclass(request_model, APIRequest)
 
     model = request_model(
         collections="test1,test2",
@@ -96,6 +102,7 @@ def test_create_post_request_model(filter_val, passes):
         extensions=[FilterExtension(), FieldsExtension()],
         base_model=BaseSearchPostRequest,
     )
+    assert issubclass(request_model, BaseModel)
 
     if not passes:
         with pytest.raises(ValidationError):