Fix logging in exception handlers

[geospatial-jeff]

The exc_info=True parameter in the exception handlers doesn't actually do anything because the log statement isn't within a except block. It should either be removed or updated to explicitly pass in exception traceback so it is logged:

exc = Exception
logger.error(
    "My error message",
    exc_info=(type(exc), exc, exc.__traceback__)
)

Logging every exception that triggers a handler might be overkill, we may just want to log traceback on 5XX responses?

https://github.com/stac-utils/stac-fastapi/blob/master/stac_fastapi/api/stac_fastapi/api/errors.py#L45

[gadomski]

So I think this is a non-issue, but it's a little hard to be sure. I checked the handling of (e.g.) a 404 error, and inspected the value of exc here:

stac-fastapi/stac_fastapi/api/stac_fastapi/api/errors.py

Lines 57 to 63 in 6db83a9

	def handler(request: Request, exc: Exception):
	"""I handle exceptions!!."""
	logger.error(exc, exc_info=True)
	return JSONResponse(
	content=ErrorResponse(code=exc.__class__.__name__, description=str(exc)),
	status_code=status_code,
	)

>>> type(exc)
<class 'stac_fastapi.types.errors.NotFoundError'>
>>> isinstance(exc, Exception)
True

According to the docs on exc_info, if it is an exception tuple OR an exception instance, exc is used: https://docs.python.org/3/library/logging.html#logging.Logger.debug. So I think we're good? @geospatial-jeff can you re-open if my understanding is incorrect?