fix: fixing some properties

Any catches will be in patch release

Author: stachu540

api/src/main/java/hirez/api/object/PlayerIdPortal.java

@@ -1,13 +1,18 @@
 package hirez.api.object;
 
 import com.fasterxml.jackson.annotation.JsonProperty;
+import hirez.api.object.adapters.TextToBoolean;
 import lombok.Data;
 
 @Data
 public class PlayerIdPortal {
+    @JsonProperty("Name")
+    private final String name;
     private final long playerId;
     private final String portal;
     private final int portalId;
+    @TextToBoolean
+    private final boolean privacyFlag;
     @JsonProperty("ret_msg")
     private final String returnedMessage;
 

paladins/src/main/java/hirez/paladins/object/Champion.java

@@ -18,33 +18,49 @@ public class Champion implements ReturnedMessage {
     @JsonProperty("Ability_5")
     private final Ability ability5;
 
-    private final String abilityDescription1;
-    private final String abilityDescription2;
-    private final String abilityDescription3;
-    private final String abilityDescription4;
-    private final String abilityDescription5;
+    @JsonProperty("Ability1")
+    private final String ability1Name;
+    @JsonProperty("Ability2")
+    private final String ability2Name;
+    @JsonProperty("Ability3")
+    private final String ability3Name;
+    @JsonProperty("Ability4")
+    private final String ability4Name;
+    @JsonProperty("Ability5")
+    private final String ability5Name;
+
+    @JsonProperty("abilityDescription1")
+    private final String ability1Description;
+    @JsonProperty("abilityDescription2")
+    private final String ability2Description;
+    @JsonProperty("abilityDescription3")
+    private final String ability3Description;
+    @JsonProperty("abilityDescription4")
+    private final String ability4Description;
+    @JsonProperty("abilityDescription5")
+    private final String ability5Description;
 
     @JsonProperty("AbilityId1")
-    private final long abilityId1;
+    private final long ability1Id;
     @JsonProperty("AbilityId2")
-    private final long abilityId2;
+    private final long ability2Id;
     @JsonProperty("AbilityId3")
-    private final long abilityId3;
+    private final long ability3Id;
     @JsonProperty("AbilityId4")
-    private final long abilityId4;
+    private final long ability4Id;
     @JsonProperty("AbilityId5")
-    private final long abilityId5;
+    private final long ability5Id;
 
     @JsonProperty("ChampionAbility1_URL")
-    private final String championAbility1URL;
+    private final String ability1URL;
     @JsonProperty("ChampionAbility2_URL")
-    private final String championAbility2URL;
+    private final String ability2URL;
     @JsonProperty("ChampionAbility3_URL")
-    private final String championAbility3URL;
+    private final String ability3URL;
     @JsonProperty("ChampionAbility4_URL")
-    private final String championAbility4URL;
+    private final String ability4URL;
     @JsonProperty("ChampionAbility5_URL")
-    private final String championAbility5URL;
+    private final String ability5URL;
 
     @JsonProperty("ChampionCard_URL")
     private final String championCardURL;
@@ -57,11 +73,14 @@ public class Champion implements ReturnedMessage {
     private final int health;
     private final long id;
     @TextToBoolean
+    @JsonProperty("latestChampion")
     private final boolean latestChampion;
     @JsonProperty("Lore")
     private final String lore;
     @JsonProperty("Name")
     private final String name;
+    @JsonProperty("Name_English")
+    private final String nameEnglish;
     @TextToBoolean
     @JsonProperty("OnFreeRotation")
     private final boolean onFreeRotation;
@@ -89,12 +108,15 @@ public class Champion implements ReturnedMessage {
     private final String type;
 
     @Data
-    public class Ability {
+    public static class Ability {
         @JsonProperty("Description")
         private final String description;
+        @JsonProperty("rechargeSeconds")
         private final long rechargeSeconds;
         @JsonProperty("Summary")
         private final String name;
+        @JsonProperty("damageType")
+        private final String damageType;
         @JsonProperty("Id")
         private final long id;
         @JsonProperty("URL")

smite/src/main/java/hirez/smite/object/God.java

@@ -1,7 +1,6 @@
 package hirez.smite.object;
 
 import com.fasterxml.jackson.annotation.JsonProperty;
-import com.fasterxml.jackson.annotation.JsonRootName;
 import hirez.api.object.adapters.TextToBoolean;
 import hirez.api.object.interfaces.ReturnedMessage;
 import lombok.Data;
@@ -21,11 +20,27 @@ public class God implements ReturnedMessage {
     @JsonProperty("Ability_5")
     private final Ability ability5;
 
-    private final Description abilityDescription1;
-    private final Description abilityDescription2;
-    private final Description abilityDescription3;
-    private final Description abilityDescription4;
-    private final Description abilityDescription5;
+    @JsonProperty("Ability1")
+    private final String ability1Name;
+    @JsonProperty("Ability2")
+    private final String ability2Name;
+    @JsonProperty("Ability3")
+    private final String ability3Name;
+    @JsonProperty("Ability4")
+    private final String ability4Name;
+    @JsonProperty("Ability5")
+    private final String ability5Name;
+
+    @JsonProperty("abilityDescription1")
+    private final ItemDescription abilityDescription1;
+    @JsonProperty("abilityDescription2")
+    private final ItemDescription abilityDescription2;
+    @JsonProperty("abilityDescription3")
+    private final ItemDescription abilityDescription3;
+    @JsonProperty("abilityDescription4")
+    private final ItemDescription abilityDescription4;
+    @JsonProperty("abilityDescription5")
+    private final ItemDescription abilityDescription5;
 
     @JsonProperty("AbilityId1")
     private final long ability1Id;
@@ -38,9 +53,13 @@ public class God implements ReturnedMessage {
     @JsonProperty("AbilityId5")
     private final long ability5Id;
 
+    @JsonProperty("AttackSpeed")
     private final double attackSpeed;
+    @JsonProperty("AttackSpeedPerLevel")
     private final double attackSpeedPerLevel;
-    private final Description basicAttack;
+    @JsonProperty("basicAttack")
+    private final ItemDescription basicAttack;
+    @JsonProperty("Cons")
     private final String cons;
 
     @JsonProperty("godAbility1_URL")
@@ -59,41 +78,65 @@ public class God implements ReturnedMessage {
     @JsonProperty("godIcon_URL")
     private final String iconURL;
 
+    @JsonProperty("HP5PerLevel")
     private final double hp5PerLevel;
+    @JsonProperty("Health")
     private final int health;
+    @JsonProperty("HealthPerFive")
     private final int healthPerFive;
+    @JsonProperty("HealthPerLevel")
     private final int healthPerLevel;
     private final long id;
     @TextToBoolean
+    @JsonProperty("latestGod")
     private final boolean latestGod;
+    @JsonProperty("Lore")
     private final String lore;
     @JsonProperty("MP5PerLevel")
     private final double mp5PerLevel;
+    @JsonProperty("MagicProtection")
     private final int magicProtection;
+    @JsonProperty("MagicProtectionPerLevel")
     private final double magicProtectionPerLevel;
+    @JsonProperty("MagicalPower")
     private final int magicalPower;
+    @JsonProperty("MagicalPowerPerLevel")
     private final int magicalPowerPerLevel;
+    @JsonProperty("Mana")
     private final int mana;
+    @JsonProperty("ManaPerFive")
     private final double manaPerFive;
+    @JsonProperty("ManaPerLevel")
     private final int manaPerLevel;
+    @JsonProperty("Name")
     private final String name;
     @TextToBoolean
+    @JsonProperty("OnFreeRotation")
     private final boolean onFreeRotation;
+    @JsonProperty("Pantheon")
     private final String pantheon;
+    @JsonProperty("PhysicalPower")
     private final int physicalPower;
+    @JsonProperty("PhysicalPowerPerLevel")
     private final int physicalPowerPerLevel;
+    @JsonProperty("PhysicalProtection")
     private final int physicalProtection;
+    @JsonProperty("PhysicalProtectionPerLevel")
     private final int physicalProtectionPerLevel;
+    @JsonProperty("Pros")
     private final String pros;
     @JsonProperty("ret_msg")
     private final String returnedMessage;
+    @JsonProperty("Roles")
     private final String roles;
+    @JsonProperty("Speed")
     private final int speed;
+    @JsonProperty("Title")
     private final String title;
+    @JsonProperty("Type")
     private final String type;
 
     @Data
-    @JsonRootName("itemDescription")
     public static class Description {
         private final String cooldown;
         private final String cost;
@@ -105,9 +148,17 @@ public static class Description {
         private final String secondaryDescription;
     }
 
+    @Data
+    public static class ItemDescription {
+        @JsonProperty("itemDescription")
+        private final Description itemDescription;
+    }
+
     @Data
     public static class Ability {
-        private final Description description;
+        @JsonProperty("Description")
+        private final ItemDescription description;
+        @JsonProperty("Id")
         private final long id;
         @JsonProperty("Summary")
         private final String name;