Skip to content

Commit 70caf2b

Browse files
author
Damian Staszewski
committed
better way test without exposing data from API.
1 parent ba43382 commit 70caf2b

File tree

1 file changed

+24
-48
lines changed

1 file changed

+24
-48
lines changed

‎src/test/java/pl/stachuofficial/HiRezAPITest.java‎

Lines changed: 24 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -50,28 +50,29 @@ static void setUp() {
5050
apitest = new HiRezTest(dev_id, auth_key);
5151
}
5252

53+
void testData(boolean condition, String title) {
54+
Assertions.assertTrue(condition, title);
55+
if (condition) System.out.println(title+": OK");
56+
else System.err.println(title+": ERROR");
57+
}
58+
5359
@Test
5460
@DisplayName("Smite PC")
5561
void smitePc() {
5662
Assertions.assertAll(
5763
() -> {
5864
String data = apitest.ping(Smite.Platform.PC).toString();
59-
Assertions.assertTrue(data.contains("Ping successful."), "Smite PC - Ping API");
60-
System.out.println(data);
65+
testData(data.contains("Ping successful."), "Smite PC - Ping API");
6166
},
6267
() -> {
6368
String data = apitest.test(Smite.Platform.PC).toString();
64-
Assertions.assertTrue(
65-
data.contains("This was a successful test with the following parameters added:"),
69+
testData(data.contains("This was a successful test with the following parameters added:"),
6670
"Smite PC - Session Test");
67-
System.out.println(data);
6871
},
6972
() -> {
7073
StringData data = apitest.patch(Smite.Platform.PC);
71-
Assertions.assertTrue(
72-
data.toJsonObject().get("ret_msg").equals(null) && !data.toJsonObject().getString("version_string").isEmpty(),
74+
testData(data.toJsonObject().get("ret_msg").equals(null) && !data.toJsonObject().getString("version_string").isEmpty(),
7375
"Smite PC - Patch Notes Test");
74-
System.out.println(data.toJsonObject().toString());
7576
});
7677
}
7778
@Test
@@ -80,22 +81,17 @@ void smiteXbox() {
8081
Assertions.assertAll(
8182
() -> {
8283
String data = apitest.ping(Smite.Platform.XBOX).toString();
83-
Assertions.assertTrue(data.contains("Ping successful."), "Smite XBOX - Ping API");
84-
System.out.println(data);
84+
testData(data.contains("Ping successful."), "Smite XBOX - Ping API");
8585
},
8686
() -> {
8787
String data = apitest.test(Smite.Platform.XBOX).toString();
88-
Assertions.assertTrue(
89-
data.contains("This was a successful test with the following parameters added:"),
88+
testData(data.contains("This was a successful test with the following parameters added:"),
9089
"Smite XBOX - Session Test");
91-
System.out.println(data);
9290
},
9391
() -> {
9492
StringData data = apitest.patch(Smite.Platform.XBOX);
95-
Assertions.assertTrue(
96-
data.toJsonObject().get("ret_msg").equals(null) && !data.toJsonObject().getString("version_string").isEmpty(),
93+
testData(data.toJsonObject().get("ret_msg").equals(null) && !data.toJsonObject().getString("version_string").isEmpty(),
9794
"Smite XBOX - Patch Notes Test");
98-
System.out.println(data.toJsonObject().toString());
9995
});
10096
}
10197
@Test
@@ -104,22 +100,17 @@ void smitePs4() {
104100
Assertions.assertAll(
105101
() -> {
106102
String data = apitest.ping(Smite.Platform.PS4).toString();
107-
Assertions.assertTrue(data.contains("Ping successful."), "Smite PS4 - Ping API");
108-
System.out.println(data);
103+
testData(data.contains("Ping successful."), "Smite PS4 - Ping API");
109104
},
110105
() -> {
111106
String data = apitest.test(Smite.Platform.PS4).toString();
112-
Assertions.assertTrue(
113-
data.contains("This was a successful test with the following parameters added:"),
107+
testData(data.contains("This was a successful test with the following parameters added:"),
114108
"Smite PS4 - Session Test");
115-
System.out.println(data);
116109
},
117110
() -> {
118111
StringData data = apitest.patch(Smite.Platform.PS4);
119-
Assertions.assertTrue(
120-
data.toJsonObject().get("ret_msg").equals(null) && !data.toJsonObject().getString("version_string").isEmpty(),
112+
testData(data.toJsonObject().get("ret_msg").equals(null) && !data.toJsonObject().getString("version_string").isEmpty(),
121113
"Smite PS4 - Patch Notes Test");
122-
System.out.println(data.toJsonObject().toString());
123114
});
124115
}
125116

@@ -129,22 +120,17 @@ void paladinsPc() {
129120
Assertions.assertAll(
130121
() -> {
131122
String data = apitest.ping(Paladins.Platform.PC).toString();
132-
Assertions.assertTrue(data.contains("Ping successful."), "Paladins PC - Ping API");
133-
System.out.println(data);
123+
testData(data.contains("Ping successful."), "Paladins PC - Ping API");
134124
},
135125
() -> {
136126
String data = apitest.test(Paladins.Platform.PC).toString();
137-
Assertions.assertTrue(
138-
data.contains("This was a successful test with the following parameters added:"),
127+
testData(data.contains("This was a successful test with the following parameters added:"),
139128
"Paladins PC - Session Test");
140-
System.out.println(data);
141129
},
142130
() -> {
143131
StringData data = apitest.patch(Paladins.Platform.PC);
144-
Assertions.assertTrue(
145-
data.toJsonObject().get("ret_msg").equals(null) && !data.toJsonObject().getString("version_string").isEmpty(),
132+
testData(data.toJsonObject().get("ret_msg").equals(null) && !data.toJsonObject().getString("version_string").isEmpty(),
146133
"Paladins PC - Patch Notes Test");
147-
System.out.println(data.toJsonObject().toString());
148134
});
149135
}
150136
@Test
@@ -153,22 +139,17 @@ void paladinsXbox() {
153139
Assertions.assertAll(
154140
() -> {
155141
String data = apitest.ping(Paladins.Platform.XBOX).toString();
156-
Assertions.assertTrue(data.contains("Ping successful."), "Paladins XBOX - Ping API");
157-
System.out.println(data);
142+
testData(data.contains("Ping successful."), "Paladins XBOX - Ping API");
158143
},
159144
() -> {
160145
String data = apitest.test(Paladins.Platform.XBOX).toString();
161-
Assertions.assertTrue(
162-
data.contains("This was a successful test with the following parameters added:"),
146+
testData(data.contains("This was a successful test with the following parameters added:"),
163147
"Paladins XBOX - Session Test");
164-
System.out.println(data);
165148
},
166149
() -> {
167150
StringData data = apitest.patch(Paladins.Platform.XBOX);
168-
Assertions.assertTrue(
169-
data.toJsonObject().get("ret_msg").equals(null) && !data.toJsonObject().getString("version_string").isEmpty(),
151+
testData(data.toJsonObject().get("ret_msg").equals(null) && !data.toJsonObject().getString("version_string").isEmpty(),
170152
"Paladins XBOX - Patch Notes Test");
171-
System.out.println(data.toJsonObject().toString());
172153
});
173154
}
174155
@Test
@@ -177,22 +158,17 @@ void paladinsPs4() {
177158
Assertions.assertAll(
178159
() -> {
179160
String data = apitest.ping(Paladins.Platform.PS4).toString();
180-
Assertions.assertTrue(data.contains("Ping successful."), "Paladins PS4 - Ping API");
181-
System.out.println(data);
161+
testData(data.contains("Ping successful."), "Paladins PS4 - Ping API");
182162
},
183163
() -> {
184164
String data = apitest.test(Paladins.Platform.PS4).toString();
185-
Assertions.assertTrue(
186-
data.contains("This was a successful test with the following parameters added:"),
165+
testData(data.contains("This was a successful test with the following parameters added:"),
187166
"Paladins PS4 - Session Test");
188-
System.out.println(data);
189167
},
190168
() -> {
191169
StringData data = apitest.patch(Paladins.Platform.PS4);
192-
Assertions.assertTrue(
193-
data.toJsonObject().get("ret_msg").equals(null) && !data.toJsonObject().getString("version_string").isEmpty(),
170+
testData(data.toJsonObject().get("ret_msg").equals(null) && !data.toJsonObject().getString("version_string").isEmpty(),
194171
"Paladins PS4 - Patch Notes Test");
195-
System.out.println(data.toJsonObject().toString());
196172
});
197173
}
198174

0 commit comments

Comments
 (0)