Skip to content

Commit 83cdc5d

Browse files
fix: Update MacOS constants
1 parent c29643c commit 83cdc5d

File tree

3 files changed

+22
-20
lines changed

3 files changed

+22
-20
lines changed

shell/browser/ui/cocoa/electron_native_view.mm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -323,10 +323,10 @@ void UpdateTrackingAreas(NSView* self, SEL _cmd) {
323323
NativeViewPrivate* priv = [self nativeViewPrivate];
324324
if (NSPointInRect(mouse, [self bounds])) { // mouse in view.
325325
if (!priv->hovered)
326-
[self mouseEntered:FakeEvent(self, NSMouseEntered)];
326+
[self mouseEntered:FakeEvent(self, NSEventTypeMouseEntered)];
327327
} else { // mouse not in view.
328328
if (priv->hovered)
329-
[self mouseExited:FakeEvent(self, NSMouseExited)];
329+
[self mouseExited:FakeEvent(self, NSEventTypeMouseExited)];
330330
}
331331

332332
[self enableTracking];

shell/browser/ui/cocoa/mouse_capture.mm

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,14 @@
66
namespace electron {
77

88
MouseCapture::MouseCapture(NativeView* view) : view_(view) {
9-
NSEventMask event_mask =
10-
NSLeftMouseDownMask | NSLeftMouseUpMask | NSRightMouseDownMask |
11-
NSRightMouseUpMask | NSMouseMovedMask | NSLeftMouseDraggedMask |
12-
NSRightMouseDraggedMask | NSMouseEnteredMask | NSMouseExitedMask |
13-
NSScrollWheelMask | NSOtherMouseDownMask | NSOtherMouseUpMask |
14-
NSOtherMouseDraggedMask;
9+
NSEventMask event_mask = NSEventMaskLeftMouseDown | NSEventMaskLeftMouseUp |
10+
NSEventMaskRightMouseDown | NSEventMaskRightMouseUp |
11+
NSEventMaskMouseMoved | NSEventMaskLeftMouseDragged |
12+
NSEventMaskRightMouseDragged |
13+
NSEventMaskMouseEntered | NSEventMaskMouseExited |
14+
NSEventMaskScrollWheel | NSEventMaskOtherMouseDown |
15+
NSEventMaskOtherMouseUp |
16+
NSEventMaskOtherMouseDragged;
1517
local_monitor_ = [NSEvent
1618
addLocalMonitorForEventsMatchingMask:event_mask
1719
handler:^NSEvent*(NSEvent* event) {

shell/browser/ui/native_view_mac.mm

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,26 +17,26 @@
1717

1818
EventType EventTypeFromNS(NSEvent* event) {
1919
switch ([event type]) {
20-
case NSLeftMouseDown:
20+
case NSEventTypeLeftMouseDown:
2121
return EventType::kLeftMouseDown;
22-
case NSRightMouseDown:
22+
case NSEventTypeRightMouseDown:
2323
return EventType::kRightMouseDown;
24-
case NSOtherMouseDown:
24+
case NSEventTypeOtherMouseDown:
2525
return EventType::kOtherMouseDown;
26-
case NSLeftMouseUp:
26+
case NSEventTypeLeftMouseUp:
2727
return EventType::kLeftMouseUp;
28-
case NSRightMouseUp:
28+
case NSEventTypeRightMouseUp:
2929
return EventType::kRightMouseUp;
30-
case NSOtherMouseUp:
30+
case NSEventTypeOtherMouseUp:
3131
return EventType::kOtherMouseUp;
32-
case NSLeftMouseDragged:
33-
case NSRightMouseDragged:
34-
case NSOtherMouseDragged:
35-
case NSMouseMoved:
32+
case NSEventTypeLeftMouseDragged:
33+
case NSEventTypeRightMouseDragged:
34+
case NSEventTypeOtherMouseDragged:
35+
case NSEventTypeMouseMoved:
3636
return EventType::kMouseMove;
37-
case NSMouseEntered:
37+
case NSEventTypeMouseEntered:
3838
return EventType::kMouseEnter;
39-
case NSMouseExited:
39+
case NSEventTypeMouseExited:
4040
return EventType::kMouseLeave;
4141
default:
4242
return EventType::kUnknown;

0 commit comments

Comments
 (0)