Skip to content

Commit 0934a25

Browse files
committed
Ignore Wconversion warnings
1 parent a82d69b commit 0934a25

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ SET(${PROJECT_NAME}_SOURCES
130130
)
131131

132132
ADD_LIBRARY(${PROJECT_NAME} SHARED ${${PROJECT_NAME}_SOURCES} ${${PROJECT_NAME}_HEADERS})
133-
TARGET_COMPILE_OPTIONS(${PROJECT_NAME} PRIVATE $<$<CXX_COMPILER_ID:MSVC>:-bigobj>)
133+
TARGET_COMPILE_OPTIONS(${PROJECT_NAME} PRIVATE $<$<CXX_COMPILER_ID:MSVC>:-bigobj> "-Wno-conversion")
134134

135135
TARGET_LINK_BOOST_PYTHON(${PROJECT_NAME})
136136
PKG_CONFIG_USE_DEPENDENCY(${PROJECT_NAME} eigen3)

python/CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ MAKE_DIRECTORY("${${PROJECT_NAME}_BINARY_DIR}/python/${PROJECT_NAME}")
2626
ADD_LIBRARY(${PYWRAP} SHARED main.cpp)
2727
TARGET_LINK_LIBRARIES(${PYWRAP} ${PROJECT_NAME})
2828
TARGET_LINK_BOOST_PYTHON(${PYWRAP})
29+
# BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS spews conversion warnings from int to long unsigned int.
30+
# Unfortunately, using literals does not work in a macro. As such, this turns them off for the entire wrapper:
31+
TARGET_COMPILE_OPTIONS(${PYWRAP} PRIVATE "-Wno-conversion")
2932
#IF(BUILD_WITH_COMMIT_VERSION)
3033
# TAG_LIBRARY_VERSION(${PYWRAP})
3134
#ENDIF(BUILD_WITH_COMMIT_VERSION)

0 commit comments

Comments
 (0)