Removed some useless compute_proxy and other adjustments

Author: Lucas-Haubert

include/eigenpy/decompositions/ComplexSchur.hpp

@@ -27,6 +27,13 @@ struct ComplexSchurVisitor
         .def(bp::init<MatrixType, bp::optional<bool>>(
             bp::args("matrix", "computeU"), "Computes Schur  of given matrix"))
 
+        .def("matrixU", &Solver::matrixU, bp::arg("self"),
+             "Returns the unitary matrix in the Schur decomposition. ",
+             bp::return_value_policy<bp::copy_const_reference>())
+        .def("matrixT", &Solver::matrixT, bp::arg("self"),
+             "Returns the triangular matrix in the Schur decomposition. ",
+             bp::return_value_policy<bp::copy_const_reference>())
+
         .def("compute", &ComplexSchurVisitor::compute_proxy<MatrixType>,
              bp::args("self", "matrix"), "Computes the Schur of given matrix.",
              bp::return_self<>())
@@ -46,13 +53,6 @@ struct ComplexSchurVisitor
              "Compute Schur decomposition from a given Hessenberg matrix. ",
              bp::return_self<>())
 
-        .def("matrixT", &Solver::matrixT, bp::arg("self"),
-             "Returns the triangular matrix in the Schur decomposition. ",
-             bp::return_value_policy<bp::copy_const_reference>())
-        .def("matrixU", &Solver::matrixU, bp::arg("self"),
-             "Returns the unitary matrix in the Schur decomposition. ",
-             bp::return_value_policy<bp::copy_const_reference>())
-
         .def("info", &Solver::info, bp::arg("self"),
              "NumericalIssue if the input contains INF or NaN values or "
              "overflow occured. Returns Success otherwise.")

include/eigenpy/decompositions/HessenbergDecomposition.hpp

@@ -64,13 +64,6 @@ struct HessenbergDecompositionVisitor
         .def(HessenbergDecompositionVisitor())
         .def(IdVisitor<Solver>());
   }
-
- private:
-  template <typename MatrixType>
-  static Solver& compute_proxy(Solver& self,
-                               const Eigen::EigenBase<MatrixType>& matrix) {
-    return self.compute(matrix);
-  }
 };
 
 }  // namespace eigenpy

include/eigenpy/decompositions/RealSchur.hpp

@@ -63,7 +63,9 @@ struct RealSchurVisitor
         .def("setMaxIterations", &Solver::setMaxIterations,
              bp::args("self", "max_iter"),
              "Sets the maximum number of iterations allowed.",
-             bp::return_self<>());
+             bp::return_self<>())
+        .def("getMaxIterations", &Solver::getMaxIterations, bp::arg("self"),
+             "Returns the maximum number of iterations.");
   }
 
   static void expose() {

include/eigenpy/decompositions/Tridiagonalization.hpp

@@ -29,10 +29,6 @@ struct TridiagonalizationVisitor : public boost::python::def_visitor<
                                   "Constructor; computes tridiagonal "
                                   "decomposition of given matrix. "))
 
-        .def("compute", &TridiagonalizationVisitor::compute_proxy<MatrixType>,
-             bp::args("self", "matrix"),
-             "Computes tridiagonal decomposition of given matrix. ",
-             bp::return_self<>())
         .def(
             "compute",
             (Solver & (Solver::*)(const Eigen::EigenBase<MatrixType>& matrix)) &
@@ -41,22 +37,21 @@ struct TridiagonalizationVisitor : public boost::python::def_visitor<
             "Computes tridiagonal decomposition of given matrix. ",
             bp::return_self<>())
 
-        .def("diagonal", &Solver::diagonal, bp::arg("self"),
-             "Returns the diagonal of the tridiagonal matrix T in the "
-             "decomposition. ")
-
         .def("householderCoefficients", &Solver::householderCoefficients,
              bp::arg("self"), "Returns the Householder coefficients. ")
+        .def("packedMatrix", &Solver::packedMatrix, bp::arg("self"),
+             "Returns the internal representation of the decomposition. ",
+             bp::return_value_policy<bp::copy_const_reference>())
 
+        // TODO: Expose so that the return type are convertible to np arrays
         .def("matrixQ", &Solver::matrixQ, bp::arg("self"),
              "Returns the unitary matrix Q in the decomposition. ")
         .def("matrixT", &Solver::matrixT, bp::arg("self"),
              "Returns the unitary matrix T in the decomposition. ")
 
-        .def("packedMatrix", &Solver::packedMatrix, bp::arg("self"),
-             "Returns the internal representation of the decomposition. ",
-             bp::return_value_policy<bp::copy_const_reference>())
-
+        .def("diagonal", &Solver::diagonal, bp::arg("self"),
+             "Returns the diagonal of the tridiagonal matrix T in the "
+             "decomposition. ")
         .def("subDiagonal", &Solver::subDiagonal, bp::arg("self"),
              "Returns the subdiagonal of the tridiagonal matrix T in the "
              "decomposition.");
@@ -73,13 +68,6 @@ struct TridiagonalizationVisitor : public boost::python::def_visitor<
         .def(TridiagonalizationVisitor())
         .def(IdVisitor<Solver>());
   }
-
- private:
-  template <typename MatrixType>
-  static Solver& compute_proxy(Solver& self,
-                               const Eigen::EigenBase<MatrixType>& matrix) {
-    return self.compute(matrix);
-  }
 };
 
 }  // namespace eigenpy

unittest/python/test_tridiagonalization.py

@@ -7,14 +7,3 @@
 A = rng.random((dim, dim))
 
 tri = eigenpy.Tridiagonalization(A)
-
-# Q = tri.matrixQ()
-# print("Q")
-# print(Q)
-# Q_conj = Q.conj().T
-
-# T = tri.matrixT()
-# print("T")
-# print(T)
-
-# assert eigenpy.is_approx(A, Q @ T @ Q_conj)