Merge pull request #62 from jcarpent/devel

Add helper to expose types

Author: jcarpent

CMakeLists.txt

@@ -82,6 +82,7 @@ SET(${PROJECT_NAME}_HEADERS
   ${${PROJECT_NAME}_SOLVERS_HEADERS}
   include/eigenpy/eigenpy.hpp
   include/eigenpy/exception.hpp
+  include/eigenpy/expose.hpp
   include/eigenpy/details.hpp
   include/eigenpy/fwd.hpp
   include/eigenpy/map.hpp

include/eigenpy/angle-axis.hpp

@@ -6,20 +6,35 @@
 #ifndef __eigenpy_angle_axis_hpp__
 #define __eigenpy_angle_axis_hpp__
 
+#include "eigenpy/fwd.hpp"
+
 #include <boost/python.hpp>
 #include <Eigen/Core>
 #include <Eigen/Geometry>
 
-#include "eigenpy/registration.hpp"
-
 namespace eigenpy
 {
 
   namespace bp = boost::python;
+  
+  template<typename AngleAxis> class AngleAxisVisitor;
+  
+  namespace internal
+  {
+    template<typename Scalar>
+    struct call_expose< Eigen::AngleAxis<Scalar> >
+    {
+      typedef Eigen::AngleAxis<Scalar> type;
+      static inline void run()
+      {
+        AngleAxisVisitor<type>::expose();
+      }
+    };
+  } // namespace internal
 
   template<typename AngleAxis>
   class AngleAxisVisitor
-    :  public boost::python::def_visitor< AngleAxisVisitor<AngleAxis> >
+  : public bp::def_visitor< AngleAxisVisitor<AngleAxis> >
   {
 
     typedef typename AngleAxis::Scalar Scalar;
@@ -103,8 +118,6 @@ namespace eigenpy
 
     static void expose()
     {
-      if(register_symbolic_link_to_registered_type<AngleAxis>()) return;
-     
       bp::class_<AngleAxis>("AngleAxis",
                             "AngleAxis representation of rotations.\n\n",
                             bp::no_init)

include/eigenpy/expose.hpp

@@ -0,0 +1,35 @@
+/*
+ * Copyright 2019, INRIA
+ */
+
+#ifndef __eigenpy_expose_hpp__
+#define __eigenpy_expose_hpp__
+
+#include "eigenpy/registration.hpp"
+
+namespace eigenpy
+{
+  namespace internal
+  {
+    ///
+    /// \brief Allows a template specialization.
+    ///
+    template<typename T>
+    struct call_expose
+    {
+      static inline void run() { T::expose(); }
+    };
+  } // namespace internal
+  
+  ///
+  /// \brief Call the expose function of a given type T.
+  ///
+  template<typename T>
+  inline void expose()
+  {
+    if(not register_symbolic_link_to_registered_type<T>())
+      internal::call_expose<T>::run();
+  }
+}
+
+#endif // ifndef __eigenpy_expose_hpp__

include/eigenpy/fwd.hpp

@@ -26,5 +26,7 @@
   #define EIGENPY_DEFAULT_ALIGNMENT_VALUE Eigen::Unaligned
 #endif
 
+#include "eigenpy/expose.hpp"
+
 #endif // ifndef __eigenpy_fwd_hpp__
 

include/eigenpy/quaternion.hpp

@@ -6,6 +6,8 @@
 #ifndef __eigenpy_quaternion_hpp__
 #define __eigenpy_quaternion_hpp__
 
+#include "eigenpy/fwd.hpp"
+
 #include <Eigen/Core>
 #include <Eigen/Geometry>
 
@@ -27,9 +29,24 @@ namespace eigenpy
 
   namespace bp = boost::python;
 
+  template<typename QuaternionDerived> class QuaternionVisitor;
+  
+  namespace internal
+  {
+    template<typename Scalar, int Options>
+    struct call_expose< Eigen::Quaternion<Scalar,Options> >
+    {
+      typedef Eigen::Quaternion<Scalar,Options> type;
+      static inline void run()
+      {
+        QuaternionVisitor<type>::expose();
+      }
+    };
+  } // namespace internal
+  
   template<typename Quaternion>
   class QuaternionVisitor
-    :  public boost::python::def_visitor< QuaternionVisitor<Quaternion> >
+  :  public bp::def_visitor< QuaternionVisitor<Quaternion> >
   {
     typedef Eigen::QuaternionBase<Quaternion> QuaternionBase;
 
@@ -203,8 +220,6 @@ namespace eigenpy
 
     static void expose()
     {
-      if(register_symbolic_link_to_registered_type<Quaternion>()) return;
-
       bp::class_<Quaternion>("Quaternion",
                              "Quaternion representing rotation.\n\n"
                              "Supported operations "

src/angle-axis.cpp

@@ -13,6 +13,6 @@ namespace eigenpy
 {
   void exposeAngleAxis()
   {
-    AngleAxisVisitor<Eigen::AngleAxisd>::expose();
+    expose<Eigen::AngleAxisd>();
   }
 } // namespace eigenpy

src/quaternion.cpp

@@ -13,6 +13,6 @@ namespace eigenpy
 {
   void exposeQuaternion()
   {
-    QuaternionVisitor<Eigen::Quaterniond>::expose();
+    expose<Eigen::Quaterniond>();
   }
 } // namespace eigenpy