Skip to content

Commit 69215a9

Browse files
committed
Corrected PYTHON_EXT_SUFFIX usage.
1 parent d337648 commit 69215a9

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

CMakeLists.txt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,6 @@ SET(${PROJECT_NAME}_SOURCES
130130
)
131131

132132
ADD_LIBRARY(${PROJECT_NAME} SHARED ${${PROJECT_NAME}_SOURCES} ${${PROJECT_NAME}_HEADERS})
133-
SET(LIB_${PROJECT_NAME}_SUFFIX ${PYTHON_EXT_SUFFIX})
134-
IF(APPLE)
135-
STRING(REPLACE ".so" ".dylib" LIB_${PROJECT_NAME}_SUFFIX ${LIB_${PROJECT_NAME}_SUFFIX})
136-
ENDIF(APPLE)
137-
SET_TARGET_PROPERTIES(${PROJECT_NAME} PROPERTIES SUFFIX "${LIB_${PROJECT_NAME}_SUFFIX}")
138133
TARGET_COMPILE_OPTIONS(${PROJECT_NAME} PRIVATE $<$<CXX_COMPILER_ID:MSVC>:-bigobj>)
139134

140135
TARGET_LINK_BOOST_PYTHON(${PROJECT_NAME})

python/CMakeLists.txt

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,7 @@ TARGET_LINK_BOOST_PYTHON(${PYWRAP})
3232
SET(${PYWRAP}_INSTALL_DIR ${CMAKE_INSTALL_PREFIX}/${PYTHON_SITELIB})
3333

3434
SET_PROPERTY(TARGET ${PYWRAP} PROPERTY LINKER_LANGUAGE CXX)
35-
IF(APPLE)
36-
# We need to change the extension for python bindings
37-
SET_TARGET_PROPERTIES(${PYWRAP} PROPERTIES SUFFIX ".so")
38-
ELSEIF(WIN32)
39-
SET_TARGET_PROPERTIES(${PYWRAP} PROPERTIES SUFFIX ".pyd")
40-
ENDIF(APPLE)
35+
SET_TARGET_PROPERTIES(${PYWRAP} PROPERTIES SUFFIX ${PYTHON_EXT_SUFFIX})
4136

4237
SET_TARGET_PROPERTIES(${PYWRAP} PROPERTIES
4338
LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/python/${PROJECT_NAME}")

0 commit comments

Comments
 (0)