File tree Expand file tree Collapse file tree 1 file changed +8
-5
lines changed Expand file tree Collapse file tree 1 file changed +8
-5
lines changed Original file line number Diff line number Diff line change 1515// https://numpy.org/devdocs/reference/c-api/array.html#c.NPY_API_SYMBOL_ATTRIBUTE
1616#define NPY_API_SYMBOL_ATTRIBUTE EIGENPY_DLLAPI
1717
18+ // When building with MSVC, Python headers use some pragma operator to link
19+ // against the Python DLL.
20+ // Unfortunately, it can link against the wrong build type of the library
21+ // leading to some linking issue.
22+ // Boost::Python provides a helper specifically dedicated to selecting the right
23+ // Python library depending on build type, so let's make use of it.
1824// Numpy headers drags Python with them. As a result, it
19- // is necessary to include the desired Python library before
20- // Numpy picks the default one, as it would be impossible to
21- // to change it afterward. Boost::Python provides a helper
22- // specifically dedicated to selecting the right Python
23- // library depending on build type, so let's make use of it.
25+ // is necessary to include this helper before including Numpy.
26+ // See: https://github.com/stack-of-tasks/eigenpy/pull/514
2427#include < boost/python/detail/wrap_python.hpp>
2528
2629#include < numpy/numpyconfig.h>
You can’t perform that action at this time.
0 commit comments