Apply suggestions from code review

jcarpent · jorisv · web-flow · commit a0fa42db805b · 2023-12-12T11:48:14.000+01:00
Co-authored-by: Joris Vaillant &lt;joris.vaillant@gmail.com&gt;
diff --git a/include/eigenpy/std-pair.hpp b/include/eigenpy/std-pair.hpp
@@ -54,7 +54,7 @@ struct StdPairConverter {
 
   static void registration() {
     boost::python::converter::registry::push_back(
-        reinterpret_cast<void* (*)(_object*)>(&convertible), &construct,
+        &convertible, &construct,
         boost::python::type_id<pair_type>()
 #ifndef BOOST_PYTHON_NO_PY_SIGNATURES
             ,
diff --git a/unittest/CMakeLists.txt b/unittest/CMakeLists.txt
@@ -117,7 +117,7 @@ add_python_unit_test("py-std-array" "unittest/python/test_std_array.py"
 set_tests_properties("py-std-array" PROPERTIES DEPENDS ${PYWRAP})
 
 add_python_unit_test("py-std-pair" "unittest/python/test_std_pair.py"
-                     "python;unittest")
+                     "unittest")
 set_tests_properties("py-std-pair" PROPERTIES DEPENDS ${PYWRAP})
 
 add_python_unit_test("py-user-struct" "unittest/python/test_user_struct.py"

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ struct StdPairConverter {`
`54`	`54`
`55`	`55`	`static void registration() {`
`56`	`56`	`boost::python::converter::registry::push_back(`
`57`		`- reinterpret_cast<void* ()(_object)>(&convertible), &construct,`
	`57`	`+ &convertible, &construct,`
`58`	`58`	`boost::python::type_id<pair_type>()`
`59`	`59`	`#ifndef BOOST_PYTHON_NO_PY_SIGNATURES`
`60`	`60`	`,`