decompositions: Fixed computation options in BDCSVD

Author: Lucas-Haubert

include/eigenpy/decompositions/BDCSVD.hpp

@@ -25,28 +25,18 @@ struct BDCSVDVisitor
   template <class PyClass>
   void visit(PyClass &cl) const {
     cl.def(bp::init<>(bp::arg("self"), "Default constructor"))
-        // TODO: Management of _Options, put default options for default
-        // constructor
         .def(bp::init<Eigen::DenseIndex, Eigen::DenseIndex>(
             bp::args("self", "rows", "cols"),
             "Default Constructor with memory preallocation. "))
         .def(bp::init<Eigen::DenseIndex, Eigen::DenseIndex, unsigned int>(
-            bp::args("self", "rows", "cols", "computationOptions "),
-            "Default Constructor with memory preallocation. \n\n"
-            "Like the default constructor but with preallocation of the "
-            "internal "
-            "data according to the specified problem size and the "
-            "computationOptions. "))
+            bp::args("self", "rows", "cols", "computationOptions"),
+            "Default Constructor with memory preallocation. "))
         .def(bp::init<MatrixType>(
             bp::args("self", "matrix"),
             "Constructor performing the decomposition of given matrix. "))
         .def(bp::init<MatrixType, unsigned int>(
-            bp::args("self", "matrix", "computationOptions "),
-            "Constructor performing the decomposition of given matrix. \n\n"
-            "One cannot request unitiaries using both the Options template "
-            "parameter "
-            "and the constructor. If possible, prefer using the Options "
-            "template parameter."))
+            bp::args("self", "matrix", "computationOptions"),
+            "Constructor performing the decomposition of given matrix. "))
 
         .def("cols", &Solver::cols, bp::arg("self"),
              "Returns the number of columns. ")

include/eigenpy/decompositions/sparse/QR.hpp

@@ -15,8 +15,8 @@
 namespace eigenpy {
 
 template <typename _MatrixType,
-          typename _Ordering = Eigen::AMDOrdering<
-              typename _MatrixType::StorageIndex>>
+          typename _Ordering =
+              Eigen::AMDOrdering<typename _MatrixType::StorageIndex>>
 struct SparseQRVisitor : public boost::python::def_visitor<
                              SparseQRVisitor<_MatrixType, _Ordering>> {
   typedef SparseQRVisitor<_MatrixType, _Ordering> Visitor;

unittest/python/test_BDCSVD.py

@@ -8,7 +8,12 @@
 A = rng.random((dim, dim))
 A = (A + A.T) * 0.5 + np.diag(10.0 + rng.random(dim))
 
-bdcsvd = eigenpy.BDCSVD(A, 24)
+bdcsvd = eigenpy.BDCSVD(
+    A,
+    eigenpy.DecompositionOptions.ComputeFullU
+    | eigenpy.DecompositionOptions.ComputeFullV,
+)
+assert bdcsvd.info() == eigenpy.ComputationInfo.Success
 
 # Solve
 X = rng.random((dim, 20))
@@ -18,8 +23,6 @@
 assert eigenpy.is_approx(A.dot(X_est), B)
 
 # Others
-assert bdcsvd.info() == eigenpy.ComputationInfo.Success
-
 cols = bdcsvd.cols()
 rows = bdcsvd.rows()