Merge pull request #473 from wxmerkt/topic/fix-warnings

Fix warnings to address unstable build on buildfarm

Author: jorisv

include/eigenpy/deprecation-policy.hpp

@@ -19,6 +19,10 @@ constexpr PyObject *deprecationTypeToPyObj(DeprecationType dep) {
       return PyExc_DeprecationWarning;
     case DeprecationType::FUTURE:
       return PyExc_FutureWarning;
+    default:  // The switch handles all cases explicitly, this should never be
+              // triggered.
+      throw std::invalid_argument(
+          "Undefined DeprecationType - this should never be triggered.");
   }
 }
 

unittest/bind_virtual_factory.cpp

@@ -72,7 +72,10 @@ struct VirtualClassWrapper : MyVirtualClass, bp::wrapper<MyVirtualClass> {
   }
 
   shared_ptr<MyVirtualData> createData() const override {
-    if (bp::override fo = this->get_override("createData")) return fo();
+    if (bp::override fo = this->get_override("createData")) {
+      bp::object result = fo().as<bp::object>();
+      return bp::extract<shared_ptr<MyVirtualData> >(result);
+    }
     return default_createData();
   }