From 1f13932c57744e9157c4fa8e748037aea1020af9 Mon Sep 17 00:00:00 2001 From: Joris Vaillant Date: Wed, 24 Sep 2025 17:36:32 +0200 Subject: [PATCH 1/2] core: remove `accelerate.hpp` This header clash with `Accelerate.hpp` in non case sensitive OS. --- CMakeLists.txt | 3 +-- .../sparse/accelerate/accelerate.hpp | 18 ------------------ 2 files changed, 1 insertion(+), 20 deletions(-) delete mode 100644 include/eigenpy/decompositions/sparse/accelerate/accelerate.hpp diff --git a/CMakeLists.txt b/CMakeLists.txt index e767907c..0ca21e2c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -209,8 +209,7 @@ set(${PROJECT_NAME}_DECOMPOSITIONS_SPARSE_CHOLMOD_HEADERS include/eigenpy/decompositions/sparse/cholmod/CholmodSupernodalLLT.hpp) set(${PROJECT_NAME}_DECOMPOSITIONS_SPARSE_ACCELERATE_HEADERS - include/eigenpy/decompositions/sparse/accelerate/Accelerate.hpp - include/eigenpy/decompositions/sparse/accelerate/accelerate.hpp) + include/eigenpy/decompositions/sparse/accelerate/Accelerate.hpp) set(${PROJECT_NAME}_DECOMPOSITIONS_SPARSE_HEADERS include/eigenpy/decompositions/sparse/SimplicialLLT.hpp diff --git a/include/eigenpy/decompositions/sparse/accelerate/accelerate.hpp b/include/eigenpy/decompositions/sparse/accelerate/accelerate.hpp deleted file mode 100644 index 71ff88b0..00000000 --- a/include/eigenpy/decompositions/sparse/accelerate/accelerate.hpp +++ /dev/null @@ -1,18 +0,0 @@ -/* - * Copyright 2025 INRIA - */ - -#ifndef __eigenpy_decompositions_sparse_accelerate_accelerate_hpp_deprecated__ -#define __eigenpy_decompositions_sparse_accelerate_accelerate_hpp_deprecated__ - -#include "eigenpy/fwd.hpp" - -// clang-format off -EIGENPY_PRAGMA_DEPRECATED_HEADER(eigenpy/decompositions/sparse/accelerate/accelerate.hpp, eigenpy/decompositions/sparse/accelerate/Accelerate.hpp) -// clang-format on - -#include "eigenpy/decompositions/sparse/accelerate/Accelerate.hpp" - -#endif - -// ifndef __eigenpy_decompositions_sparse_accelerate_accelerate_hpp_deprecated__ From 303b96a908fe2c678f78e4a2052952d7a6b5cd2c Mon Sep 17 00:00:00 2001 From: Joris Vaillant Date: Wed, 24 Sep 2025 17:40:24 +0200 Subject: [PATCH 2/2] changelog: Add entry --- CHANGELOG.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 42d33d39..6bc5f2d8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,14 +6,16 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ## [Unreleased] -## [3.12.0] - 2025-08-12 +### Changed -### Added +- Remove `accelerate.hpp` header that clash with Accelerate.hpp in non case sensitive OS ([#593](https://github.com/stack-of-tasks/eigenpy/pull/593) + We don't consider it an API break since this header was rarely used. -- Add additional decompositions and solvers from Eigen ([#571](https://github.com/stack-of-tasks/eigenpy/pull/571)) +## [3.12.0] - 2025-08-12 ### Added +- Add additional decompositions and solvers from Eigen ([#571](https://github.com/stack-of-tasks/eigenpy/pull/571)) - Docker images `ghcr.io/stack-of-tasks/eigenpy` ([#575](https://github.com/stack-of-tasks/eigenpy/pull/575)) ### Changed