Only add GCC Clang warnings options in GCC/Clang (#64)

* Only add GCC Clang warnings options in GCC/Clang

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Guilhem Saurel <[email protected]>

* Only add GCC Clang warnings options in GCC/Clang

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Guilhem Saurel <[email protected]>

Author: 3 people

CMakeLists.txt

@@ -90,8 +90,11 @@ set(${PROJECT_NAME}_HEADERS
     include/${PROJECT_NAME}/eiquadprog-utils.hxx)
 
 add_library(${PROJECT_NAME} src/eiquadprog-fast.cpp src/eiquadprog.cpp)
-target_compile_options(${PROJECT_NAME} PRIVATE "-Wno-sign-conversion"
-)# We have a lot of implicit size_t to Eigen::Index conversions
+
+if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
+  # We have a lot of implicit size_t to Eigen::Index conversions
+  target_compile_options(${PROJECT_NAME} PRIVATE "-Wno-sign-conversion")
+endif()
 
 if(TRACE_SOLVER)
   target_compile_definitions(${PROJECT_NAME} PRIVATE EIQGUADPROG_TRACE_SOLVER)

tests/CMakeLists.txt

@@ -24,14 +24,16 @@ set(TESTS eiquadprog-basic eiquadprog-fast eiquadprog-rt eiquadprog-both
 foreach(test ${TESTS})
   add_unit_test(${test} ${test}.cpp)
   target_link_libraries(${test} ${PROJECT_NAME} Boost::unit_test_framework)
-  target_compile_options(
-    ${test} PRIVATE "-Wno-sign-conversion") # We have a lot of implicit size_t
-                                            # to Eigen::Index conversions
+  if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
+    # We have a lot of implicit size_t to Eigen::Index conversions
+    target_compile_options(${test} PRIVATE "-Wno-sign-conversion")
+  endif()
 endforeach(test ${TESTS})
 
 add_library(testab SHARED TestA.cpp TestB.cpp)
 target_link_libraries(testab ${PROJECT_NAME})
 target_link_libraries(test-integration testab)
-target_compile_options(
-  testab PRIVATE "-Wno-sign-conversion") # We have a lot of implicit size_t to
-                                         # Eigen::Index conversions
+if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
+  # We have a lot of implicit size_t to Eigen::Index conversions
+  target_compile_options(testab PRIVATE "-Wno-sign-conversion")
+endif()