From 06400947d5b6651eb11b8d009f55878111780cb7 Mon Sep 17 00:00:00 2001
From: Silvio Traversaro <silvio@traversaro.it>
Date: Fri, 12 Sep 2025 14:52:47 +0200
Subject: [PATCH 1/4] Only add GCC Clang warnings options in GCC/Clang

---
 tests/CMakeLists.txt | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index 52faed7..0b0b12e 100644
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -24,14 +24,18 @@ set(TESTS eiquadprog-basic eiquadprog-fast eiquadprog-rt eiquadprog-both
 foreach(test ${TESTS})
   add_unit_test(${test} ${test}.cpp)
   target_link_libraries(${test} ${PROJECT_NAME} Boost::unit_test_framework)
-  target_compile_options(
-    ${test} PRIVATE "-Wno-sign-conversion") # We have a lot of implicit size_t
-                                            # to Eigen::Index conversions
+  if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_C_COMPILER_ID MATCHES "Clang")
+    target_compile_options(
+      ${test} PRIVATE "-Wno-sign-conversion") # We have a lot of implicit size_t
+                                              # to Eigen::Index conversions
+  endif()
 endforeach(test ${TESTS})
 
 add_library(testab SHARED TestA.cpp TestB.cpp)
 target_link_libraries(testab ${PROJECT_NAME})
 target_link_libraries(test-integration testab)
-target_compile_options(
-  testab PRIVATE "-Wno-sign-conversion") # We have a lot of implicit size_t to
-                                         # Eigen::Index conversions
+if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_C_COMPILER_ID MATCHES "Clang")
+  target_compile_options(
+    testab PRIVATE "-Wno-sign-conversion") # We have a lot of implicit size_t to
+                                           # Eigen::Index conversions
+endif()

From 8de470f8cca92e0615a9627f7418e3e75da0538c Mon Sep 17 00:00:00 2001
From: "pre-commit-ci[bot]"
 <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date: Fri, 12 Sep 2025 12:55:00 +0000
Subject: [PATCH 2/4] [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
---
 tests/CMakeLists.txt | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index 0b0b12e..dce319c 100644
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -25,9 +25,8 @@ foreach(test ${TESTS})
   add_unit_test(${test} ${test}.cpp)
   target_link_libraries(${test} ${PROJECT_NAME} Boost::unit_test_framework)
   if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_C_COMPILER_ID MATCHES "Clang")
-    target_compile_options(
-      ${test} PRIVATE "-Wno-sign-conversion") # We have a lot of implicit size_t
-                                              # to Eigen::Index conversions
+    target_compile_options(${test} PRIVATE "-Wno-sign-conversion"
+    )# We have a lot of implicit size_t to Eigen::Index conversions
   endif()
 endforeach(test ${TESTS})
 

From c606b7bfc134f8863d01baf4c74be6712f351550 Mon Sep 17 00:00:00 2001
From: Silvio Traversaro <silvio@traversaro.it>
Date: Fri, 12 Sep 2025 15:33:51 +0200
Subject: [PATCH 3/4] Apply suggestions from code review

Co-authored-by: Guilhem Saurel <guilhem.saurel@laas.fr>
---
 tests/CMakeLists.txt | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index dce319c..9462063 100644
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -24,17 +24,16 @@ set(TESTS eiquadprog-basic eiquadprog-fast eiquadprog-rt eiquadprog-both
 foreach(test ${TESTS})
   add_unit_test(${test} ${test}.cpp)
   target_link_libraries(${test} ${PROJECT_NAME} Boost::unit_test_framework)
-  if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_C_COMPILER_ID MATCHES "Clang")
-    target_compile_options(${test} PRIVATE "-Wno-sign-conversion"
-    )# We have a lot of implicit size_t to Eigen::Index conversions
+  if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
+    # We have a lot of implicit size_t to Eigen::Index conversions
+    target_compile_options(${test} PRIVATE "-Wno-sign-conversion")
   endif()
 endforeach(test ${TESTS})
 
 add_library(testab SHARED TestA.cpp TestB.cpp)
 target_link_libraries(testab ${PROJECT_NAME})
 target_link_libraries(test-integration testab)
-if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_C_COMPILER_ID MATCHES "Clang")
-  target_compile_options(
-    testab PRIVATE "-Wno-sign-conversion") # We have a lot of implicit size_t to
-                                           # Eigen::Index conversions
+if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
+  # We have a lot of implicit size_t to Eigen::Index conversions
+  target_compile_options(testab PRIVATE "-Wno-sign-conversion")
 endif()

From 6d1da52313e02093a9b3bc5225a5da6cb55a2b6f Mon Sep 17 00:00:00 2001
From: Silvio Traversaro <silvio@traversaro.it>
Date: Fri, 12 Sep 2025 15:35:27 +0200
Subject: [PATCH 4/4] Only add GCC Clang warnings options in GCC/Clang

---
 CMakeLists.txt | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 6f8d272..043eba4 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -90,8 +90,11 @@ set(${PROJECT_NAME}_HEADERS
     include/${PROJECT_NAME}/eiquadprog-utils.hxx)
 
 add_library(${PROJECT_NAME} src/eiquadprog-fast.cpp src/eiquadprog.cpp)
-target_compile_options(${PROJECT_NAME} PRIVATE "-Wno-sign-conversion"
-)# We have a lot of implicit size_t to Eigen::Index conversions
+
+if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
+  # We have a lot of implicit size_t to Eigen::Index conversions
+  target_compile_options(${PROJECT_NAME} PRIVATE "-Wno-sign-conversion")
+endif()
 
 if(TRACE_SOLVER)
   target_compile_definitions(${PROJECT_NAME} PRIVATE EIQGUADPROG_TRACE_SOLVER)