Skip to content

Commit 4d4359a

Browse files
Merge pull request #546 from stackabletech/update-release-branch
Update release branch
2 parents 0bd16a8 + c311ba7 commit 4d4359a

File tree

11 files changed

+108
-84
lines changed

11 files changed

+108
-84
lines changed

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,16 @@
22

33
## [Unreleased]
44

5+
### Fixed
6+
7+
- BREAKING: Use distinct ServiceAccounts for the Stacklets, so that multiple Stacklets can be
8+
deployed in one namespace. Existing Stacklets will use the newly created ServiceAccounts after
9+
restart ([#545]).
10+
- Fix OIDC endpoint construction in case the `rootPath` does not have a trailing slash ([#547]).
11+
12+
[#545]: https://github.com/stackabletech/airflow-operator/pull/545
13+
[#547]: https://github.com/stackabletech/airflow-operator/pull/547
14+
515
## [24.11.0] - 2024-11-18
616

717
### Added

Cargo.lock

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.nix

Lines changed: 11 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,11 @@ serde = { version = "1.0", features = ["derive"] }
2323
serde_json = "1.0"
2424
serde_yaml = "0.9"
2525
snafu = "0.8"
26-
stackable-operator = { git = "https://github.com/stackabletech/operator-rs.git", tag = "stackable-operator-0.80.0" }
26+
stackable-operator = { git = "https://github.com/stackabletech/operator-rs.git", tag = "stackable-operator-0.82.0" }
2727
strum = { version = "0.26", features = ["derive"] }
2828
tokio = { version = "1.40", features = ["full"] }
2929
tracing = "0.1"
3030

3131
# [patch."https://github.com/stackabletech/operator-rs.git"]
3232
# stackable-operator = { git = "https://github.com/stackabletech//operator-rs.git", branch = "main" }
33+
# stackable-operator = { path = "../operator-rs/crates/stackable-operator" }

Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ SHELL=/usr/bin/env bash -euo pipefail
2929
render-readme:
3030
scripts/render_readme.sh
3131

32+
render-docs:
33+
scripts/docs_templating.sh
34+
3235
## Docker related targets
3336
docker-build:
3437
docker build --force-rm --build-arg VERSION=${VERSION} -t "${DOCKER_REPO}/${ORGANIZATION}/${OPERATOR_NAME}:${VERSION}-${ARCH}" -f docker/Dockerfile .

crate-hashes.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/modules/airflow/examples/getting_started/code/getting_started.sh

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,7 @@
22
set -euo pipefail
33

44
# DO NOT EDIT THE SCRIPT
5-
# Instead, update the j2 template, and regenerate it for dev:
6-
# cat <<EOF | jinja2 --format yaml getting_started.sh.j2 -o getting_started.sh
7-
# helm:
8-
# repo_name: stackable-dev
9-
# repo_url: https://repo.stackable.tech/repository/helm-dev/
10-
# versions:
11-
# commons: 0.0.0-dev
12-
# secret: 0.0.0-dev
13-
# listener: 0.0.0-dev
14-
# airflow: 0.0.0-dev
15-
# postgresql: 12.1.5
16-
# redis: 17.3.7
17-
# EOF
5+
# Instead, update the j2 template, and regenerate it for dev with `make render-docs`.
186

197
# This script contains all the code snippets from the guide, as well as some assert tests
208
# to test if the instructions in the guide work. The user *could* use it, but it is intended

docs/modules/airflow/examples/getting_started/code/getting_started.sh.j2

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,7 @@
22
set -euo pipefail
33

44
# DO NOT EDIT THE SCRIPT
5-
# Instead, update the j2 template, and regenerate it for dev:
6-
# cat <<EOF | jinja2 --format yaml getting_started.sh.j2 -o getting_started.sh
7-
# helm:
8-
# repo_name: stackable-dev
9-
# repo_url: https://repo.stackable.tech/repository/helm-dev/
10-
# versions:
11-
# commons: 0.0.0-dev
12-
# secret: 0.0.0-dev
13-
# listener: 0.0.0-dev
14-
# airflow: 0.0.0-dev
15-
# postgresql: 12.1.5
16-
# redis: 17.3.7
17-
# EOF
5+
# Instead, update the j2 template, and regenerate it for dev with `make render-docs`.
186

197
# This script contains all the code snippets from the guide, as well as some assert tests
208
# to test if the instructions in the guide work. The user *could* use it, but it is intended

rust/operator-binary/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ tracing.workspace = true
2626
indoc.workspace = true
2727

2828
[build-dependencies]
29-
3029
built.workspace = true
3130

3231
[dev-dependencies]
32+
rstest.workspace = true
3333
serde_yaml.workspace = true

rust/operator-binary/src/airflow_controller.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ use stackable_operator::{
4646
apps::v1::{StatefulSet, StatefulSetSpec},
4747
core::v1::{
4848
ConfigMap, EmptyDirVolumeSource, EnvVar, PodTemplateSpec, Probe, Service,
49-
ServicePort, ServiceSpec, TCPSocketAction, VolumeMount,
49+
ServiceAccount, ServicePort, ServiceSpec, TCPSocketAction, VolumeMount,
5050
},
5151
},
5252
apimachinery::pkg::{apis::meta::v1::LabelSelector, util::intstr::IntOrString},
@@ -416,7 +416,7 @@ pub async fn reconcile_airflow(
416416
build_rbac_resources(airflow, APP_NAME, required_labels).context(BuildRBACObjectsSnafu)?;
417417

418418
let rbac_sa = cluster_resources
419-
.add(client, rbac_sa)
419+
.add(client, rbac_sa.clone())
420420
.await
421421
.context(ApplyServiceAccountSnafu)?;
422422
cluster_resources
@@ -488,7 +488,7 @@ pub async fn reconcile_airflow(
488488
&rolegroup,
489489
rolegroup_config,
490490
&authentication_config,
491-
&rbac_sa.name_unchecked(),
491+
&rbac_sa,
492492
&merged_airflow_config,
493493
airflow_executor,
494494
)?;
@@ -836,7 +836,7 @@ fn build_server_rolegroup_statefulset(
836836
rolegroup_ref: &RoleGroupRef<AirflowCluster>,
837837
rolegroup_config: &HashMap<PropertyNameKind, BTreeMap<String, String>>,
838838
authentication_config: &AirflowClientAuthenticationDetailsResolved,
839-
sa_name: &str,
839+
service_account: &ServiceAccount,
840840
merged_airflow_config: &AirflowConfig,
841841
executor: &AirflowExecutor,
842842
) -> Result<StatefulSet> {
@@ -861,7 +861,7 @@ fn build_server_rolegroup_statefulset(
861861
pb.metadata(pb_metadata)
862862
.image_pull_secrets_from_product_image(resolved_product_image)
863863
.affinity(&merged_airflow_config.affinity)
864-
.service_account_name(sa_name)
864+
.service_account_name(service_account.name_any())
865865
.security_context(
866866
PodSecurityContextBuilder::new()
867867
.run_as_user(AIRFLOW_UID)

0 commit comments

Comments
 (0)