Remove the deprecated pod enrichment controller (#321)

* Remove the deprecated pod enrichment controller

Fixes #292

* Changelog

* Removed remaining references to pod enrichment from the docs

* Update docs/modules/commons-operator/pages/index.adoc

Co-authored-by: Sebastian Bernauer <[email protected]>

* Fixed precommit

---------

Co-authored-by: Sebastian Bernauer <[email protected]>

Author: nightkr

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
 
+### Removed
+
+- BREAKING: Removed the deprecated pod enrichment controller ([#321]).
+
 ### Added
 
 - Aggregate emitted Kubernetes events on the CustomResources ([#318]).
@@ -13,6 +17,7 @@ All notable changes to this project will be documented in this file.
 - Append a dot (`.`) to the default cluster domain to reduce DNS requests ([#318]).
 
 [#318]: https://github.com/stackabletech/commons-operator/pull/318
+[#321]: https://github.com/stackabletech/commons-operator/pull/321
 
 ## [24.11.0] - 2024-11-18
 

docs/modules/commons-operator/pages/index.adoc

@@ -1,5 +1,5 @@
 = Stackable Commons Operator
-:description: Learn about shared objects (AuthenticationClass, S3Bucket and S3Connection) and shared functionality (Pod enrichting, restarting) on the Stackable Data Platform.
+:description: Learn about shared objects (AuthenticationClass, S3Bucket and S3Connection) and shared functionality (restarting) on the Stackable Data Platform.
 :github: https://github.com/stackabletech/commons-operator/
 :crd: {crd-docs-base-url}/commons-operator/{crd-docs-version}/
 
@@ -23,4 +23,4 @@ You can also find the full CRD refererence documentation for all objects linked
 == Shared functionality
 
 The commons operator implements functionality that is shared by all other Stackable operators.
-For example, it  xref:pod-enrichment.adoc[adds additional information to Pods] which would otherwise have to be inferred and takes care of xref:restarter.adoc[restarting] Pods when necessary, for example to reload configuration settings in products that don't support hot reloading.
+For example, it takes care of xref:restarter.adoc[restarting] Pods when necessary, for example to reload configuration settings in products that don't support hot reloading.

docs/modules/commons-operator/pages/pod-enrichment.adoc

@@ -8,7 +8,3 @@ The commons-operator is used for multiple purposes:
 
 |xref:restarter.adoc[]
 |A controller that watches Pod objects and their controllers and restarts them when required.
-
-|xref:pod-enrichment.adoc[]
-|A controller that adds commonly used information to Pod objects.
-|===

docs/modules/commons-operator/pages/usage.adoc

@@ -2,7 +2,6 @@
 * xref:commons-operator:usage.adoc[]
 * Concepts
 ** xref:commons-operator:restarter.adoc[]
-** xref:commons-operator:pod-enrichment.adoc[]
 * xref:commons-operator:reference/index.adoc[]
 ** xref:commons-operator:reference/crds.adoc[]
 *** {crd-docs}/authentication.stackable.tech/authenticationclass/v1alpha1/[AuthenticationClass {external-link-icon}^]

docs/modules/commons-operator/partials/nav.adoc

@@ -1,4 +1,3 @@
-mod pod_enrichment_controller;
 mod restart_controller;
 
 use built_info::PKG_VERSION;
@@ -61,18 +60,8 @@ async fn main() -> anyhow::Result<()> {
             let sts_restart_controller =
                 restart_controller::statefulset::start(&client, &watch_namespace);
             let pod_restart_controller = restart_controller::pod::start(&client, &watch_namespace);
-            let pod_enrichment_controller =
-                pod_enrichment_controller::start(&client, &watch_namespace);
-            pin_mut!(
-                sts_restart_controller,
-                pod_restart_controller,
-                pod_enrichment_controller
-            );
-            futures::future::select(
-                futures::future::select(sts_restart_controller, pod_restart_controller),
-                pod_enrichment_controller,
-            )
-            .await;
+            pin_mut!(sts_restart_controller, pod_restart_controller);
+            futures::future::select(sts_restart_controller, pod_restart_controller).await;
         }
     }