Skip to content

Commit 12a11b5

Browse files
committed
chore: add todos about fixing the image tags so that they are easily replacable on release
1 parent 500f07c commit 12a11b5

File tree

6 files changed

+24
-0
lines changed

6 files changed

+24
-0
lines changed

.github/workflows/dev_jupyter-pyspark-with-alibi-detect.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ name: Build and publish jupyter-pyspark-with-alibi-detect
33

44
env:
55
IMAGE_NAME: jupyter-pyspark-with-alibi-detect
6+
# TODO (@NickLarsenNZ): Use a versioned image with stackable0.0.0-dev or stackableXX.X.X so that
7+
# the demo is reproducable for the release and it will be automatically replaced for the release branch.
68
IMAGE_VERSION: python-3.9
79
REGISTRY_PATH: stackable
810
DOCKERFILE_PATH: "demos/signal-processing/Dockerfile-jupyter"
@@ -12,6 +14,8 @@ on:
1214
push:
1315
branches:
1416
- main
17+
# TODO (@NickLarsenNZ): Also build on release branches, but with a stackable0.0.0-dev or stackableXX.X.X tag.
18+
# - release-*
1519
paths:
1620
- demos/signal-processing/Dockerfile-jupyter
1721
- demos/signal-processing/requirements.txt

.github/workflows/dev_nifi.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ name: Build and publish NiFi for signal-processing demo
33

44
env:
55
IMAGE_NAME: nifi
6+
# TODO (@NickLarsenNZ): Use a versioned image with stackable0.0.0-dev or stackableXX.X.X so that
7+
# the demo is reproducable for the release and it will be automatically replaced for the release branch.
68
IMAGE_VERSION: 1.27.0-postgresql
79
REGISTRY_PATH: stackable
810
DOCKERFILE_PATH: "demos/signal-processing/Dockerfile-nifi"
@@ -12,6 +14,8 @@ on:
1214
push:
1315
branches:
1416
- main
17+
# TODO (@NickLarsenNZ): Also build on release branches, but with a stackable0.0.0-dev or stackableXX.X.X tag.
18+
# - release-*
1519
paths:
1620
- demos/signal-processing/Dockerfile-nifi
1721
- .github/workflows/dev_nifi.yaml

.github/workflows/dev_spark-k8s-with-scikit-learn.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ name: Build and publish spark-k8s-with-scikit-learn
33

44
env:
55
IMAGE_NAME: spark-k8s-with-scikit-learn
6+
# TODO (@NickLarsenNZ): Use a versioned image with stackable0.0.0-dev or stackableXX.X.X so that
7+
# the demo is reproducable for the release and it will be automatically replaced for the release branch.
68
IMAGE_VERSION: 3.5.0-stackable24.3.0
79
REGISTRY_PATH: stackable
810
DOCKERFILE_PATH: "demos/jupyterhub-pyspark-hdfs-anomaly-detection-taxi-data/Dockerfile"
@@ -12,6 +14,8 @@ on:
1214
push:
1315
branches:
1416
- main
17+
# TODO (@NickLarsenNZ): Also build on release branches, but with a stackable0.0.0-dev or stackableXX.X.X tag.
18+
# - release-*
1519
paths:
1620
- demos/jupyterhub-pyspark-hdfs-anomaly-detection-taxi-data/Dockerfile
1721
- demos/jupyterhub-pyspark-hdfs-anomaly-detection-taxi-data/requirements.txt

docs/modules/demos/pages/jupyterhub-pyspark-hdfs-anomaly-detection-taxi-data.adoc

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,10 @@ This is described below.
151151

152152
Libraries can be added to a custom *product* image launched by the notebook. Suppose a Spark job is prepared like this:
153153

154+
// TODO (@NickLarsenNZ): Use stackable0.0.0-dev so that the demo is reproducable for the release
155+
// and it will be automatically replaced for the release branch.
156+
// Also update the reference in notebook.ipynb.
157+
154158
[source,python]
155159
----
156160
spark = (SparkSession
@@ -172,6 +176,10 @@ spark = (SparkSession
172176

173177
It requires a specific Spark image:
174178

179+
// TODO (@NickLarsenNZ): Use stackable0.0.0-dev so that the demo is reproducable for the release
180+
// and it will be automatically replaced for the release branch.
181+
// Also update the reference in notebook.ipynb.
182+
175183
[source,python]
176184
----
177185
.config("spark.kubernetes.container.image",

stacks/signal-processing/jupyterhub.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ options:
3030
singleuser:
3131
cmd: null
3232
image:
33+
# TODO (@NickLarsenNZ): Use a versioned image with stackable0.0.0-dev or stackableXX.X.X so that
34+
# the demo is reproducable for the release and it will be automatically replaced for the release branch.
3335
name: docker.stackable.tech/demos/jupyter-pyspark-with-alibi-detect
3436
tag: python-3.9
3537
serviceAccountName: spark

stacks/signal-processing/nifi.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ metadata:
66
spec:
77
image:
88
productVersion: 1.27.0
9+
# TODO (@NickLarsenNZ): Use a versioned image with stackable0.0.0-dev or stackableXX.X.X so that
10+
# the demo is reproducable for the release and it will be automatically replaced for the release branch.
911
custom: docker.stackable.tech/demos/nifi:1.27.0-postgresql
1012
clusterConfig:
1113
listenerClass: external-unstable

0 commit comments

Comments
 (0)