chore(pre-commit): fix lints on all files to make future changes less burdensome

NickLarsenNZ · NickLarsenNZ · commit fb39139b5cbe · 2024-11-16T20:07:36.000+01:00
diff --git a/.gitattributes b/.gitattributes
@@ -2,4 +2,4 @@ docs/** -linguist-documentation
 
 *.adoc linguist-detectable
 *.yaml linguist-detectable
-*.yml linguist-detectable
+*.yml linguist-detectable
diff --git a/.github/workflows/dev_spark-k8s-with-scikit-learn.yaml b/.github/workflows/dev_spark-k8s-with-scikit-learn.yaml
@@ -34,7 +34,7 @@ jobs:
           # TODO: the image 3.5.0-stackable24.3.0 does not have an arm64 build.
           # Re-activate the arm runner when the image is updated to one that does.
           # Also adjust publish_manifest step to include arm architecture
-          #- {name: "ubicloud-standard-8-arm", arch: "arm64"}
+          # - {name: "ubicloud-standard-8-arm", arch: "arm64"}
     steps:
       - name: Checkout Repository
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
diff --git a/.gitignore b/.gitignore
@@ -1 +1 @@
-.env
+.env
diff --git a/.yamllint.yaml b/.yamllint.yaml
@@ -8,3 +8,4 @@ rules:
   comments:
     min-spaces-from-content: 1  # Needed due to https://github.com/adrienverge/yamllint/issues/443
   braces: disable # because the yaml files are templates which can have {{ ... }}
+  indentation: disable # There are many conflicting styles and it isn't so important in this repo. It can be enabled later if we want consistency.
diff --git a/demos/data-lakehouse-iceberg-trino-spark/create-trino-tables.yaml b/demos/data-lakehouse-iceberg-trino-spark/create-trino-tables.yaml
@@ -338,29 +338,6 @@ data:
         )
     """)
 
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
     run_query(connection, """
         create table if not exists lakehouse.house_sales.house_sales with (
             partitioning = ARRAY['year(date_of_transfer)']
@@ -504,23 +481,6 @@ data:
         where tpep_pickup_datetime >= date '2015-01-01' and tpep_pickup_datetime <= now() -- We have to remove some invalid records
     """)
 
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
     run_query(connection, """
       create or replace materialized view lakehouse.taxi.yellow_tripdata_daily_agg as
       select
@@ -566,11 +526,6 @@ data:
         REFRESH MATERIALIZED VIEW lakehouse.taxi.yellow_tripdata_monthly_agg
     """)
 
-
-
-
-
-
     # At this point Spark should have created the needed underlying tables
     run_query(connection, """
         create or replace view lakehouse.smart_city.shared_bikes_station_status_latest as
diff --git a/demos/demos-v1.yaml b/demos/demos-v1.yaml
@@ -1,3 +1,4 @@
+---
 demos:
   please-update:
     description: This version of stackablectl is outdated, please visit https://docs.stackable.tech/stackablectl/stable/installation.html on how to get the latest version
diff --git a/demos/demos-v2.yaml b/demos/demos-v2.yaml
@@ -73,7 +73,7 @@ demos:
       memory: 42034Mi
       pvc: 75Gi # 30Gi for Kafka
   nifi-kafka-druid-water-level-data:
-    description:  Demo ingesting water level data into Kafka using NiFi, streaming it into Druid and creating a Superset dashboard
+    description: Demo ingesting water level data into Kafka using NiFi, streaming it into Druid and creating a Superset dashboard
     documentation: https://docs.stackable.tech/stackablectl/stable/demos/nifi-kafka-druid-water-level-data.html
     stackableStack: nifi-kafka-druid-superset-s3
     labels:
diff --git a/demos/end-to-end-security/README.md b/demos/end-to-end-security/README.md
@@ -5,6 +5,7 @@
 3. Optional: Add Database connection
 4. Add admin user in Keycloak to all relevant groups (so that he has access to the tables, so he can create datasets, charts and dashboards).
 5. `pgdump` the Postgres and update the dump in Git. For that shell into `postgresql-superset-0` and execute
+
 ```sh
 export PGPASSWORD="$POSTGRES_POSTGRES_PASSWORD"
 
diff --git a/demos/nifi-kafka-druid-earthquake-data/download_earthquake_data.sh b/demos/nifi-kafka-druid-earthquake-data/download_earthquake_data.sh
@@ -1,3 +1,6 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
 # This script is not used for the demo
 # Its purpose is to document how to retrieve the used earthquake data
 
diff --git a/docs/modules/demos/images/end-to-end-security/README.md b/docs/modules/demos/images/end-to-end-security/README.md
@@ -1,3 +1,5 @@
+# ent-to-end-security
+
 The images are exported from
-https://docs.google.com/presentation/d/19h3sBve_dOSgpZ6eTZqmYXxGoiQqXNs1/edit?usp=sharing&ouid=105504333647320477456&rtpof=true&sd=true.
+<https://docs.google.com/presentation/d/19h3sBve_dOSgpZ6eTZqmYXxGoiQqXNs1/edit?usp=sharing&ouid=105504333647320477456&rtpof=true&sd=true>
 Ask Sebastian for access if needed.
diff --git a/docs/modules/demos/images/end-to-end-security/trino-schema.svg b/docs/modules/demos/images/end-to-end-security/trino-schema.svg
diff --git a/stacks/_templates/keycloak.yaml b/stacks/_templates/keycloak.yaml
@@ -126,14 +126,14 @@ metadata:
   labels:
     app: keycloak
 spec:
-# We want a stable Keycloak address that does not change when Keycloak reboots.
-# We could simply pick LoadBalancer here, but on-prem clusters often times don't support LBs,
-# so the demo would not run on their environments. Additionally, LB addresses often take a while to allocate
-# (order of minutes on GCP iirc). So there's no way for us to know whether there's no LB address because it's still
-# in progress, or if there's no LB address because it's unsupported.
-#
-# But we can at least make sure to reconcile the AuthClass once Keycloak restarts.
-# We achieve this by letting the keycloak itself propagate it's address instead of a separate Job.
+  # We want a stable Keycloak address that does not change when Keycloak reboots.
+  # We could simply pick LoadBalancer here, but on-prem clusters often times don't support LBs,
+  # so the demo would not run on their environments. Additionally, LB addresses often take a while to allocate
+  # (order of minutes on GCP iirc). So there's no way for us to know whether there's no LB address because it's still
+  # in progress, or if there's no LB address because it's unsupported.
+  #
+  # But we can at least make sure to reconcile the AuthClass once Keycloak restarts.
+  # We achieve this by letting the keycloak itself propagate it's address instead of a separate Job.
   type: NodePort
   selector:
     app: keycloak
diff --git a/stacks/_templates/prometheus-service-monitor.yaml b/stacks/_templates/prometheus-service-monitor.yaml
@@ -1,3 +1,4 @@
+---
 apiVersion: monitoring.coreos.com/v1
 kind: ServiceMonitor
 metadata:
diff --git a/stacks/_templates/vector-aggregator-discovery.yaml b/stacks/_templates/vector-aggregator-discovery.yaml
@@ -1,3 +1,4 @@
+---
 apiVersion: v1
 kind: ConfigMap
 metadata:
diff --git a/stacks/authentication/openldap-tls.yaml b/stacks/authentication/openldap-tls.yaml
@@ -93,4 +93,4 @@ spec:
       port: 1636
       targetPort: tls-ldap
   selector:
-    app.kubernetes.io/name: openldap
+    app.kubernetes.io/name: openldap
diff --git a/stacks/end-to-end-security/kerberos-secretclass.yaml b/stacks/end-to-end-security/kerberos-secretclass.yaml
@@ -1,4 +1,3 @@
-
 ---
 apiVersion: secrets.stackable.tech/v1alpha1
 kind: SecretClass
diff --git a/stacks/end-to-end-security/superset.yaml b/stacks/end-to-end-security/superset.yaml
@@ -23,7 +23,7 @@ spec:
       spec:
         # We need to restore the postgres state before the superset container itself starts some database migrations
         initContainers:
-        # The postgres image does not contain curl or wget...
+          # The postgres image does not contain curl or wget...
           - name: download-dump
             image: docker.stackable.tech/stackable/testing-tools:0.2.0-stackable24.7.0
             command:
diff --git a/stacks/keycloak-opa-poc/policies.yaml b/stacks/keycloak-opa-poc/policies.yaml
@@ -58,4 +58,4 @@ data:
 #         "57d3b407-ecc0-4cc1-aaaf-45a63f43b96b",
 #         "170b4130-ca4d-417b-b229-f2917d5ab3d1"
 #       ]
-#     }
+#     }
diff --git a/stacks/keycloak-opa-poc/setup-keycloak.yaml b/stacks/keycloak-opa-poc/setup-keycloak.yaml
@@ -1,3 +1,4 @@
+---
 apiVersion: v1
 kind: Secret
 metadata:
diff --git a/stacks/observability/grafana-admin-credentials.yaml b/stacks/observability/grafana-admin-credentials.yaml
@@ -1,3 +1,4 @@
+---
 apiVersion: v1
 kind: Secret
 metadata:
diff --git a/stacks/observability/grafana.yaml b/stacks/observability/grafana.yaml
@@ -1,5 +1,6 @@
-# https://github.com/grafana/helm-charts/tree/main/charts/grafana
+# yamllint disable rule:comments-indentation
 ---
+# https://github.com/grafana/helm-charts/tree/main/charts/grafana
 releaseName: grafana
 name: grafana
 repo:
diff --git a/stacks/observability/opentelemetry-collector-deployment.yaml b/stacks/observability/opentelemetry-collector-deployment.yaml
@@ -1,3 +1,5 @@
+# yamllint disable rule:comments-indentation
+---
 # The OpenTelemetry Operator does not yet allow setting the service to be a NodePort
 # See: https://github.com/open-telemetry/opentelemetry-operator/issues/902
 apiVersion: opentelemetry.io/v1beta1
@@ -122,7 +124,7 @@ spec:
           - resourcedetection/env
           - resource/logs
           - attributes/logs
-          exporters: 
+          exporters:
           - loki
           # - debug
       # Set the log level of the opentelemetry-collector application.
@@ -141,7 +143,7 @@ spec:
       cpu: 250m
       memory: 64Mi
   volumeMounts:
-    # We mount a certificate from the secret-operator so that we have the CA 
+    # We mount a certificate from the secret-operator so that we have the CA
     # cert for exporters to trust what they connect to.
     - name: tls
       mountPath: /certs
diff --git a/stacks/observability/opentelemetry-collector-sidecar.yaml b/stacks/observability/opentelemetry-collector-sidecar.yaml
@@ -1,3 +1,5 @@
+# yamllint disable rule:comments-indentation
+---
 apiVersion: opentelemetry.io/v1beta1
 kind: OpenTelemetryCollector
 metadata:
@@ -121,7 +123,7 @@ spec:
           - resourcedetection/env
           - resource/logs
           - attributes/logs
-          exporters: 
+          exporters:
           - loki
           # - debug
       # Set the log level of the opentelemetry-collector application.
@@ -140,7 +142,7 @@ spec:
       cpu: 250m
       memory: 64Mi
   volumeMounts:
-    # We mount a certificate from the secret-operator so that we have the CA 
+    # We mount a certificate from the secret-operator so that we have the CA
     # cert for exporters to trust what they connect to.
     - name: tls
       mountPath: /certs
diff --git a/stacks/stacks-v1.yaml b/stacks/stacks-v1.yaml
@@ -1,3 +1,4 @@
+---
 stacks:
   please-update:
     description: This version of stackablectl is outdated, please visit https://docs.stackable.tech/stackablectl/stable/installation.html on how to get the latest version
diff --git a/stacks/trino-superset-s3/hive-metastore.yaml b/stacks/trino-superset-s3/hive-metastore.yaml
@@ -25,4 +25,4 @@ metadata:
 type: Opaque
 stringData:
   username: hive
-  password: hive        
+  password: hive

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+---`
`1`	`2`	`demos:`
`2`	`3`	`please-update:`
`3`	`4`	`description: This version of stackablectl is outdated, please visit https://docs.stackable.tech/stackablectl/stable/installation.html on how to get the latest version`