Skip to content

Commit 0811522

Browse files
committed
ci(pr_test_build_images): Add a note about filtering superficial changes to avoid pointless builds
1 parent 2ea40b1 commit 0811522

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/workflows/pr_test_build_images.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,9 @@ jobs:
6666
# Needed for tomlq
6767
pip install yq==3.4.3
6868
69+
# TODO (@NickLarsenNZ): Filter out superficial changes, eg: only comments added/removed.
70+
# An idea: before the `xargs -r dirname` command, we can compare old and new with comments stripped.
71+
# And keep adding rules as we need them.
6972
PRODUCT_VERSION_PAIRS=$(
7073
# shellcheck disable=SC2016
7174
git diff --name-only "${GIT_BASE_REF}..${GIT_HEAD_REF}" \
@@ -76,7 +79,6 @@ jobs:
7679
| jq --slurp --compact-output '.'
7780
)
7881
echo "product_version_pairs=$PRODUCT_VERSION_PAIRS" | tee -a "$GITHUB_OUTPUT"
79-
8082
outputs:
8183
product_version_pairs: ${{ steps.shard.outputs.product_version_pairs }}
8284

0 commit comments

Comments
 (0)