Skip to content

Commit 6646a55

Browse files
authored
Merge branch 'main' into chore/hbase-use-config-utils
2 parents 67dd5e2 + 4458cda commit 6646a55

File tree

9 files changed

+88
-14
lines changed

9 files changed

+88
-14
lines changed

.github/actionlint.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@
22
self-hosted-runner:
33
# Ubicloud machines we are using
44
labels:
5-
- ubicloud-standard-8-arm
5+
- ubicloud-standard-8-arm-ubuntu-2404
6+
- ubicloud-standard-8-ubuntu-2404

.github/workflows/build_opensearch_dashboards.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ run-name: |
66
on:
77
workflow_dispatch:
88
schedule:
9-
- cron: '0 0 2/2 * *' # https://crontab.guru/#0_0_2/2_*_*
9+
- cron: "0 0 2/2 * *" # https://crontab.guru/#0_0_2/2_*_*
1010
push:
1111
branches: [main]
1212
tags:
@@ -34,3 +34,4 @@ jobs:
3434
product-name: opensearch-dashboards
3535
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
3636
registry-namespace: sdp
37+
runners: ubicloud

.github/workflows/reusable_build_image.yaml

Lines changed: 42 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,13 @@ on:
1010
registry-namespace:
1111
required: true
1212
type: string
13+
runners:
14+
description: |
15+
The type of runners used.
16+
- `mixed`: x86_64 builds run on the GitHub hosted runners and the aarch64 builds run on the Ubicloud runners
17+
- `ubicloud`: Both the x86_64 and the aarch64 builds run on the Ubicloud runners
18+
default: mixed
19+
type: string
1320
secrets:
1421
harbor-robot-secret:
1522
description: The secret for the Harbor robot user used to push images and manifest
@@ -19,8 +26,33 @@ on:
1926
required: true
2027

2128
jobs:
22-
generate_matrix:
23-
name: Generate Version List
29+
generate_runner_dimension:
30+
name: Generate Runner Dimension
31+
runs-on: ubuntu-latest
32+
steps:
33+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
34+
with:
35+
persist-credentials: false
36+
- id: runners
37+
shell: bash
38+
env:
39+
RUNNERS_TYPE: ${{ inputs.runners }}
40+
run: |
41+
if [ "$RUNNERS_TYPE" == "mixed" ]; then
42+
RUNNERS=$(jq --compact-output < .github/workflows/runners/mixed.json)
43+
echo "RUNNERS=$RUNNERS" | tee -a "$GITHUB_OUTPUT"
44+
elif [ "$RUNNERS_TYPE" == "ubicloud" ]; then
45+
RUNNERS=$(jq --compact-output < .github/workflows/runners/ubicloud.json)
46+
echo "RUNNERS=$RUNNERS" | tee -a "$GITHUB_OUTPUT"
47+
else
48+
echo "Invalid runners type, expected 'mixed' or 'ubicloud'"
49+
exit 1
50+
fi
51+
outputs:
52+
runners: ${{ steps.runners.outputs.RUNNERS }}
53+
54+
generate_version_dimension:
55+
name: Generate Version Dimension
2456
runs-on: ubuntu-latest
2557
steps:
2658
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -35,17 +67,17 @@ jobs:
3567

3668
build:
3769
name: Build/Publish ${{ matrix.versions }}-${{ matrix.runner.arch }} Image
38-
needs: [generate_matrix]
70+
needs:
71+
- generate_version_dimension
72+
- generate_runner_dimension
3973
permissions:
4074
id-token: write
4175
runs-on: ${{ matrix.runner.name }}
4276
strategy:
4377
fail-fast: false
4478
matrix:
45-
runner:
46-
- {name: "ubuntu-latest", arch: "amd64"}
47-
- {name: "ubicloud-standard-8-arm-ubuntu-2404", arch: "arm64"}
48-
versions: ${{ fromJson(needs.generate_matrix.outputs.versions) }}
79+
versions: ${{ fromJson(needs.generate_version_dimension.outputs.versions) }}
80+
runner: ${{ fromJson(needs.generate_runner_dimension.outputs.runners) }}
4981
steps:
5082
- name: Checkout Repository
5183
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -76,14 +108,14 @@ jobs:
76108

77109
publish_manifests:
78110
name: Build/Publish ${{ matrix.versions }} Manifests
79-
needs: [generate_matrix, build]
111+
needs: [generate_version_dimension, build]
80112
permissions:
81113
id-token: write
82114
runs-on: ubuntu-latest
83115
strategy:
84116
fail-fast: false
85117
matrix:
86-
versions: ${{ fromJson(needs.generate_matrix.outputs.versions) }}
118+
versions: ${{ fromJson(needs.generate_version_dimension.outputs.versions) }}
87119
steps:
88120
- name: Checkout Repository
89121
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -101,7 +133,7 @@ jobs:
101133

102134
notify:
103135
name: Failure Notification
104-
needs: [generate_matrix, build, publish_manifests]
136+
needs: [generate_version_dimension, build, publish_manifests]
105137
runs-on: ubuntu-latest
106138
if: failure() || (github.run_attempt > 1 && !cancelled())
107139
steps:
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
[
2+
{
3+
"name": "ubuntu-latest",
4+
"arch": "amd64"
5+
},
6+
{
7+
"name": "ubicloud-standard-8-arm-ubuntu-2404",
8+
"arch": "arm64"
9+
}
10+
]
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
[
2+
{
3+
"name": "ubicloud-standard-8-ubuntu-2404",
4+
"arch": "amd64"
5+
},
6+
{
7+
"name": "ubicloud-standard-8-arm-ubuntu-2404",
8+
"arch": "arm64"
9+
}
10+
]

CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ All notable changes to this project will be documented in this file.
2121
- opa: Add `1.8.0` ([#1279]).
2222
- spark: Add `3.5.7` ([#1280]).
2323
- spark-connect-client: Add `3.5.7` ([#1280]).
24-
- superset: Add `4.1.4` ([#1284]).
24+
- superset: Add `4.1.4` ([#1284]).
2525
- spark: Add `4.0.1` ([#1286]).
2626
- spark-connect-client: Add `4.0.1` ([#1286]).
2727
- trino/trino-storage-connector: Add `477` ([#1285]).
@@ -44,6 +44,7 @@ All notable changes to this project will be documented in this file.
4444
- tools: Bump dependency versions - kubectl to `1.34.1`, yq to `4.47.2`, and jq to `1.8.1` ([#1290]).
4545
- testing-tools: Update keycloak dependency to `26.3.5` and `python:3.12-slim-bullseye` base image ([#1289]).
4646
- hbase: replace `sed` calls with `config-utils template` where possible ([#1301]).
47+
- hbase: move hbck2.env to hbase-operator-tools image and add log4j2 properties for this tool ([#1300]).
4748

4849
### Removed
4950

@@ -91,6 +92,7 @@ All notable changes to this project will be documented in this file.
9192
[#1293]: https://github.com/stackabletech/docker-images/pull/1293
9293
[#1296]: https://github.com/stackabletech/docker-images/pull/1296
9394
[#1301]: https://github.com/stackabletech/docker-images/pull/1301
95+
[#1300]: https://github.com/stackabletech/docker-images/pull/1300
9496

9597
## [25.7.0] - 2025-07-23
9698

hbase/hbase-operator-tools/Dockerfile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,11 @@ ARG DELETE_CACHES="true"
2121
# The variable names are intentionally passed to envsubst in single-quotes,
2222
# so that they are not expanded. Disabling ShellCheck rules in a Dockerfile
2323
# does not work, so please ignore the according warning (SC2016).
24-
COPY --chown=${STACKABLE_USER_UID}:0 hbase/hbase/stackable/bin/hbck2.env /stackable/bin/
24+
COPY --chown=${STACKABLE_USER_UID}:0 hbase/hbase-operator-tools/stackable/bin/hbck2.env /stackable/bin/
2525
COPY --chown=${STACKABLE_USER_UID}:0 hbase/hbase-operator-tools/stackable/patches/patchable.toml /stackable/src/hbase/hbase-operator-tools/stackable/patches/patchable.toml
2626
COPY --chown=${STACKABLE_USER_UID}:0 hbase/hbase-operator-tools/stackable/patches/${HBASE_OPERATOR_TOOLS_VERSION} /stackable/src/hbase/hbase-operator-tools/stackable/patches/${HBASE_OPERATOR_TOOLS_VERSION}
2727
COPY --chown=${STACKABLE_USER_UID}:0 hbase/hbase/stackable/bin/hbase-entrypoint.sh /stackable/bin/
28+
COPY --chown=${STACKABLE_USER_UID}:0 hbase/hbase-operator-tools/stackable/conf/log4j2-hbck.properties /tmp/log4j2-hbck.properties
2829

2930
COPY --from=hbase-builder --chown=${STACKABLE_USER_UID}:0 /stackable/patched-libs/maven/org/apache/hbase /stackable/patched-libs/maven/org/apache/hbase
3031
COPY --from=hadoop-builder --chown=${STACKABLE_USER_UID}:0 /stackable/patched-libs/maven/org/apache/hadoop /stackable/patched-libs/maven/org/apache/hadoop
@@ -84,6 +85,9 @@ if [ "${DELETE_CACHES}" = "true" ] ; then
8485
rm -rf /stackable/.cache/*
8586
fi
8687

88+
mkdir -p /stackable/hbase-operator-tools-${FULL_HBASE_OPERATOR_TOOLS_VERSION}/conf
89+
mv /tmp/log4j2-hbck.properties /stackable/hbase-operator-tools-${FULL_HBASE_OPERATOR_TOOLS_VERSION}/conf/log4j2-hbck.properties
90+
8791
# set correct groups
8892
chmod --recursive g=u /stackable
8993
EOF
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
#!/bin/sh
22

3+
export LOG4J_CONFIGURATION_FILE=/stackable/hbase-operator-tools/conf/log4j2-hbck.properties
4+
35
exec /stackable/hbase-${PATCHED_HBASE_VERSION}/bin/hbase hbck \
46
-j /stackable/hbase-operator-tools-${FULL_HBASE_OPERATOR_TOOLS_VERSION}/hbase-hbck2/hbase-hbck2-${PATCHED_HBASE_OPERATOR_TOOLS_VERSION}.jar \
57
"$@"
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
status = warn
2+
dest = err
3+
name = PropertiesConfig
4+
5+
# Console appender
6+
appender.console.type = Console
7+
appender.console.target = SYSTEM_ERR
8+
appender.console.name = console
9+
appender.console.layout.type = PatternLayout
10+
appender.console.layout.pattern = %d{ISO8601} %-5p [%t%notEmpty{ %X}] %c{2}: %.1000m%n
11+
12+
rootLogger = WARN,console

0 commit comments

Comments
 (0)