chore: Add more image validation

Author: Techassi

rust/boil/src/build/bakefile.rs

@@ -391,7 +391,7 @@ impl Bakefile {
         let image_name = image_name.replace('/', "__");
 
         // The dots in the semantic version also need to be replaced.
-        let image_version = image_version.to_string().replace('.', "_");
+        let image_version = image_version.replace('.', "_");
 
         format!("{image_name}-{image_version}")
     }

rust/boil/src/build/image.rs

@@ -7,14 +7,20 @@ use std::{
 };
 
 use serde::Deserialize;
-use snafu::{ResultExt as _, Snafu};
+use snafu::{ResultExt as _, Snafu, ensure};
 
 use crate::{IfContext, build::docker::BuildArguments};
 
 #[derive(Debug, Snafu)]
 pub enum ParseImageError {
     #[snafu(display("encountered invalid format, expected name[=version,...]"))]
     InvalidFormat,
+
+    #[snafu(display("the path contains unsupported characters: '.' or '~'"))]
+    UnsupportedChars,
+
+    #[snafu(display("absolute paths are not supported"))]
+    AbsolutePath,
 }
 
 #[derive(Clone, Debug)]
@@ -29,11 +35,16 @@ impl FromStr for Image {
     fn from_str(s: &str) -> Result<Self, Self::Err> {
         let parts: Vec<_> = s.split('=').collect();
 
+        ensure!(!parts[0].contains(['.', '~']), UnsupportedCharsSnafu);
+        ensure!(!parts[0].starts_with('/'), AbsolutePathSnafu);
+
+        let image_name = parts[0].trim_end_matches('/').to_owned();
+
         match parts.len() {
-            1 => Ok(Self::new_unversioned(parts[0].to_owned())),
+            1 => Ok(Self::new_unversioned(image_name)),
             2 => {
                 let versions: Vec<_> = parts[1].split(',').map(ToOwned::to_owned).collect();
-                Ok(Self::new(parts[0].to_owned(), versions))
+                Ok(Self::new(image_name, versions))
             }
             _ => InvalidFormatSnafu.fail(),
         }

rust/boil/src/cli.rs

@@ -11,9 +11,6 @@ pub struct Cli {
     #[arg(short, long = "configuration", global = true, default_value_os_t = Self::default_config_path())]
     pub config_path: PathBuf,
 
-    #[arg(short, long, default_value_os_t = Self::default_base_path())]
-    pub base_path: PathBuf,
-
     #[command(subcommand)]
     pub command: Command,
 }
@@ -22,10 +19,6 @@ impl Cli {
     fn default_config_path() -> PathBuf {
         PathBuf::from("./boil.toml")
     }
-
-    fn default_base_path() -> PathBuf {
-        PathBuf::from(".")
-    }
 }
 
 #[derive(Debug, Subcommand)]