fix(omid): location and permissions of the tso logging directory (#773)

* change ownership of the tso dir

* Set omid.log.dir sys prop and some refactoring

* run pre-commit to fix formatting

* update delete_caches

* successfully ran on OpenShift

* works in both kind and openshift

* Implement review feedback

Author: razvan

omid/Dockerfile

@@ -8,16 +8,23 @@
 FROM stackable/image/java-devel AS builder
 
 ARG PRODUCT
+ARG DELETE_CACHES="true"
 
 USER stackable
 WORKDIR /stackable
 
-RUN curl --fail -L https://dist.apache.org/repos/dist/release/phoenix/phoenix-omid-${PRODUCT}/phoenix-omid-${PRODUCT}-src.tar.gz | tar -xzC .
+# hadolint ignore=DL3003
+RUN --mount=type=cache,id=maven,uid=1000,target=/stackable/.m2/repository <<EOF
+  curl --fail -L https://dist.apache.org/repos/dist/release/phoenix/phoenix-omid-${PRODUCT}/phoenix-omid-${PRODUCT}-src.tar.gz | tar -xzC .
+  cd /stackable/phoenix-omid-${PRODUCT} || exit
+  mvn package -Phbase-2 -DskipTests
+  tar -xf tso-server/target/omid-tso-server-${PRODUCT}-bin.tar.gz -C /stackable
+  tar -xf examples/target/omid-examples-${PRODUCT}-bin.tar.gz -C /stackable
 
-WORKDIR /stackable/phoenix-omid-${PRODUCT}
-RUN mvn package -Phbase-2 -DskipTests && \
-    tar -xf tso-server/target/omid-tso-server-${PRODUCT}-bin.tar.gz -C /stackable && \
-    tar -xf examples/target/omid-examples-${PRODUCT}-bin.tar.gz -C /stackable
+if [ "${DELETE_CACHES}" = "true" ] ; then
+  rm -rf /stackable/.m2/repository/*
+fi
+EOF
 
 # ===
 # For earlier versions this script removes the .class file that contains the
@@ -51,29 +58,37 @@ LABEL name="Apache Phoenix Omid" \
       summary="The Stackable image for Apache Phoenix Omid." \
       description="This image is deployed by the Stackable Operator for Apache HBase."
 
-RUN microdnf update && \
-    microdnf clean all && \
-    rm -rf /var/cache/yum
-
-ENV HOME=/stackable
-
-COPY --chown=stackable:stackable omid/stackable /stackable
 COPY omid/licenses /licenses
 
-USER stackable
-WORKDIR /stackable
-
-COPY --from=builder /stackable/omid-tso-server-${PRODUCT} /stackable/omid-tso-server-${PRODUCT}
-COPY --from=builder /stackable/omid-examples-${PRODUCT} /stackable/omid-examples-${PRODUCT}
-
-RUN ln -s /stackable/omid-tso-server-${PRODUCT} /stackable/omid-tso-server && \
-    ln -s /stackable/omid-examples-${PRODUCT} /stackable/omid-examples && \
-    curl https://repo.stackable.tech/repository/packages/jmx-exporter/jmx_prometheus_javaagent-${JMX_EXPORTER}.jar \
-    -o /stackable/jmx/jmx_prometheus_javaagent-${JMX_EXPORTER}.jar && \
-    chmod -x /stackable/jmx/jmx_prometheus_javaagent-${JMX_EXPORTER}.jar
+COPY --chown=stackable:stackable omid/stackable /stackable
+COPY --chown=stackable:stackable --from=builder /stackable/omid-tso-server-${PRODUCT} /stackable/omid-tso-server-${PRODUCT}
+COPY --chown=stackable:stackable --from=builder /stackable/omid-examples-${PRODUCT} /stackable/omid-examples-${PRODUCT}
+
+RUN <<EOF
+  microdnf update
+  microdnf clean all
+  rm -rf /var/cache/yum
+
+  ln -s /stackable/omid-tso-server-${PRODUCT} /stackable/omid-tso-server
+  ln -s /stackable/omid-examples-${PRODUCT} /stackable/omid-examples
+  curl https://repo.stackable.tech/repository/packages/jmx-exporter/jmx_prometheus_javaagent-${JMX_EXPORTER}.jar \
+  -o /stackable/jmx/jmx_prometheus_javaagent-${JMX_EXPORTER}.jar
+  chmod -x /stackable/jmx/jmx_prometheus_javaagent-${JMX_EXPORTER}.jar
+  # omid.sh places this file at the front of the classpath: remove it to allow the config map entry to take precedence
+  rm /stackable/omid-tso-server/conf/hbase-site.xml
+
+  # To support arbitrary user ids on OpenShift, this folder must belong to the root group.
+  mkdir /stackable/logs
+  chown -R 1000:0 /stackable/logs
+  chgrp -R 0 /stackable/logs
+  chmod -R g=u /stackable/logs
+EOF
+
+USER 1000
+WORKDIR /stackable/omid-tso-server
 
+ENV HOME=/stackable
 ENV HBASE_CONF_DIR=/stackable/hbase/conf
-# omid.sh places this file at the front of the classpath: remove it to allow the config map entry to take precedence
-RUN rm /stackable/omid-tso-server/conf/hbase-site.xml
-WORKDIR /stackable/omid-tso-server
+ENV OMID_OPTS="-Domid.log.dir=/stackable/logs"
+
 CMD ["./bin/omid.sh", "tso" ]