Skip to content

Commit bb35a87

Browse files
authored
fix: pin luxon to fix build (#1315)
* fix: pin luxon to fix build * chore: changelog
1 parent 922c720 commit bb35a87

File tree

4 files changed

+48
-55
lines changed

4 files changed

+48
-55
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ All notable changes to this project will be documented in this file.
4949
- hbase: move hbck2.env to hbase-operator-tools image and add log4j2 properties for this tool ([#1300]).
5050
- hbase: replace `sed` calls with `config-utils template` where possible ([#1301]).
5151
- superset: Fix the 4.1.2 build when building from source ([#1309])
52+
- superset: Pin `luxon` to version 3.6.1 to fix build ([#1315])
5253

5354
### Fixed
5455

@@ -106,6 +107,7 @@ All notable changes to this project will be documented in this file.
106107
[#1308]: https://github.com/stackabletech/docker-images/pull/1308
107108
[#1309]: https://github.com/stackabletech/docker-images/pull/1309
108109
[#1311]: https://github.com/stackabletech/docker-images/pull/1311
110+
[#1315]: https://github.com/stackabletech/docker-images/pull/1315
109111

110112
## [25.7.0] - 2025-07-23
111113

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
From 1b11f3ff47f46105289f7f9dcaa4fc10d6ea3571 Mon Sep 17 00:00:00 2001
2+
From: dervoeti <[email protected]>
3+
Date: Wed, 22 Oct 2025 17:04:19 +0200
4+
Subject: fix: pin luxon to fix build
5+
6+
For some reason npm tries to use a newer version of luxon than the version in the lock file. I suspect this might be related to how npm before version 11 handles workspace dependencies in lock files. The luxon version is set to 3.6.1 now to prevent npm from trying to select a newer version, so that the same packages as in the original Superset build are used.
7+
---
8+
superset-frontend/package.json | 2 +-
9+
1 file changed, 1 insertion(+), 1 deletion(-)
10+
11+
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
12+
index ebca197a25..3490ecaa93 100644
13+
--- a/superset-frontend/package.json
14+
+++ b/superset-frontend/package.json
15+
@@ -148,7 +148,7 @@
16+
"json-bigint": "^1.0.0",
17+
"json-stringify-pretty-compact": "^2.0.0",
18+
"lodash": "^4.17.21",
19+
- "luxon": "^3.5.0",
20+
+ "luxon": "3.6.1",
21+
"mapbox-gl": "^2.10.0",
22+
"markdown-to-jsx": "^7.4.7",
23+
"match-sorter": "^6.3.4",

superset/stackable/patches/4.1.2/0001-fix.patch

Lines changed: 0 additions & 55 deletions
This file was deleted.
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
From 23a71074574336d3cbdf0b27e3650bf21b39b337 Mon Sep 17 00:00:00 2001
2+
From: dervoeti <[email protected]>
3+
Date: Wed, 22 Oct 2025 16:42:08 +0200
4+
Subject: fix: pin luxon to fix build
5+
6+
For some reason npm tries to use a newer version of luxon than the version in the lock file. I suspect this might be related to how npm before version 11 handles workspace dependencies in lock files. The luxon version is set to 3.6.1 now to prevent npm from trying to select a newer version, so that the same packages as in the original Superset build are used.
7+
---
8+
superset-frontend/package.json | 2 +-
9+
1 file changed, 1 insertion(+), 1 deletion(-)
10+
11+
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
12+
index 066ce89764..cd6ca2a53f 100644
13+
--- a/superset-frontend/package.json
14+
+++ b/superset-frontend/package.json
15+
@@ -148,7 +148,7 @@
16+
"json-bigint": "^1.0.0",
17+
"json-stringify-pretty-compact": "^2.0.0",
18+
"lodash": "^4.17.21",
19+
- "luxon": "^3.5.0",
20+
+ "luxon": "3.6.1",
21+
"mapbox-gl": "^2.10.0",
22+
"markdown-to-jsx": "^7.4.7",
23+
"match-sorter": "^6.3.4",

0 commit comments

Comments
 (0)