Skip to content

Commit f2cfbde

Browse files
committed
Fix build
1 parent a1c029a commit f2cfbde

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

druid/Dockerfile

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,20 +43,29 @@ COPY --chown=${STACKABLE_USER_UID}:0 druid/stackable/patches/${PRODUCT} /stackab
4343
# with a "directory not empty" error on the first builder to finish, as other builders
4444
# are still working in the cache directory.
4545

46+
# Let's have patchable as a dedicated step, as it fetches the druid sourcecode over the network,
47+
# thus taking a bit (which is annoying while development). We can re-run the same command later,
48+
# it just takes not so long on the second invocation.
49+
RUN /stackable/patchable --images-repo-root=src checkout druid ${PRODUCT} > /tmp/DRUID_SOURCE_DIR
50+
4651
RUN --mount=type=cache,id=maven-${PRODUCT},uid=${STACKABLE_USER_UID},target=/stackable/.m2/repository \
4752
--mount=type=cache,id=npm-${PRODUCT},uid=${STACKABLE_USER_UID},target=/stackable/.npm \
4853
--mount=type=cache,id=cache-${PRODUCT},uid=${STACKABLE_USER_UID},target=/stackable/.cache \
4954
<<EOF
50-
cd "$(/stackable/patchable --images-repo-root=src checkout druid ${PRODUCT})"
55+
cd "$(cat /tmp/DRUID_SOURCE_DIR)" || exit 1
56+
rm /tmp/DRUID_SOURCE_DIR
5157

5258
mvn \
5359
--batch-mode \
5460
--no-transfer-progress \
5561
clean install \
5662
-Pdist,stackable-bundle-contrib-exts \
57-
-DskipTests \
58-
-Dmaven.javadoc.skip=true \
59-
-Dmaven.gitcommitid.skip=true
63+
-Dmaven.test.skip `# Skip test compilation` \
64+
-DskipTests `# Skip test execution` \
65+
-Dcheckstyle.skip `# Skip checkstyle checks. We dont care if the code is properly formatted, it just wastes time` \
66+
-Dmaven.javadoc.skip=true `# Dont generate javadoc` \
67+
-Dmaven.gitcommitid.skip=true \
68+
--projects '!quidem-ut' `# This is just a maven module for tests. https://github.com/apache/druid/pull/16867 added https://raw.githubusercontent.com/kgyrtkirk/datasets/repo/ as a Maven repository, which fails to pull for us (Failed to execute goal on project druid-quidem-ut: Could not resolve dependencies for project org.apache.druid:druid-quidem-ut:jar:33.0.0: com.github.kgyrtkirk.datasets:kttm-nested:jar:0.1 was not found in https://build-repo.stackable.tech/repository/maven-public/). By disabling the maven module we dont pull in this weird dependency...`
6069

6170
mv distribution/target/apache-druid-${PRODUCT}-bin/apache-druid-${PRODUCT} /stackable/
6271
mv distribution/target/bom.json /stackable/apache-druid-${PRODUCT}/apache-druid-${PRODUCT}.cdx.json

0 commit comments

Comments
 (0)