From dafa437c38ead7417ea993e4158e15e90d2b67a3 Mon Sep 17 00:00:00 2001 From: Lars Francke Date: Thu, 7 Nov 2024 14:41:21 +0100 Subject: [PATCH 1/2] Update JMX Exporter to a custom built version of 1.0.1 This includes an updated version of the Prometheus client which fixes a performance regression in 1.0.1. Unfortunately there was no release of JMX Exporter 1.0.2 in time for our SDP 24.11 release so we decided to just build a custom version off main as of commit 193f6f5819a07093853f71f1b4094ccc7e67912f --- CHANGELOG.md | 2 ++ hadoop/versions.py | 6 +++--- hbase/versions.py | 2 +- hive/versions.py | 4 ++-- kafka/versions.py | 4 ++-- omid/versions.py | 2 +- spark-k8s/versions.py | 4 ++-- trino/versions.py | 4 ++-- zookeeper/versions.py | 2 +- 9 files changed, 16 insertions(+), 14 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 93a278f7f..1d81a7a47 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -38,6 +38,7 @@ All notable changes to this project will be documented in this file. - ubi-rust-builder: Bump Rust toolchain to 1.81.0 ([#902]). - ci: Handle release builds in the same build workflows ([#913]). - hadoop: Bump to `hdfs-utils` 0.4.0 ([#914]). +- jmx exporter: Updated to a custom-built version of 1.0.1 to fix performance regressions ([#920]) ### Removed @@ -101,6 +102,7 @@ All notable changes to this project will be documented in this file. [#912]: https://github.com/stackabletech/docker-images/pull/912 [#913]: https://github.com/stackabletech/docker-images/pull/913 [#914]: https://github.com/stackabletech/docker-images/pull/914 +[#920]: https://github.com/stackabletech/docker-images/pull/920 ## [24.7.0] - 2024-07-24 diff --git a/hadoop/versions.py b/hadoop/versions.py index 8126e6434..a9bd6bcc0 100644 --- a/hadoop/versions.py +++ b/hadoop/versions.py @@ -4,7 +4,7 @@ "java-base": "11", "java-devel": "11", "async_profiler": "2.9", - "jmx_exporter": "1.0.1", + "jmx_exporter": "1.0.1-stackable", "protobuf": "3.7.1", "hdfs_utils": "0.4.0", }, @@ -13,7 +13,7 @@ "java-base": "11", "java-devel": "11", "async_profiler": "2.9", - "jmx_exporter": "1.0.1", + "jmx_exporter": "1.0.1-stackable", "protobuf": "3.7.1", "hdfs_utils": "0.4.0", }, @@ -22,7 +22,7 @@ "java-base": "11", "java-devel": "11", "async_profiler": "2.9", - "jmx_exporter": "1.0.1", + "jmx_exporter": "1.0.1-stackable", "protobuf": "3.7.1", "hdfs_utils": "0.4.0", }, diff --git a/hbase/versions.py b/hbase/versions.py index c29ba55e8..002c8255c 100644 --- a/hbase/versions.py +++ b/hbase/versions.py @@ -11,7 +11,7 @@ "phoenix": "5.2.0", "hbase_profile": "2.4", "hadoop": "3.3.6", - "jmx_exporter": "1.0.1", # update the stackable/jmx/config folder too + "jmx_exporter": "1.0.1-stackable", # update the stackable/jmx/config folder too "opa_authorizer": "", # only for HBase 2.6.0 "delete_caches": "true", }, diff --git a/hive/versions.py b/hive/versions.py index 45dbf096f..c35922942 100644 --- a/hive/versions.py +++ b/hive/versions.py @@ -1,7 +1,7 @@ versions = [ { "product": "4.0.0", - "jmx_exporter": "1.0.1", + "jmx_exporter": "1.0.1-stackable", # Hive 4 must be built with Java 8 (according to GitHub README) but seems to run on Java 11 "java-base": "11", "java-devel": "8", @@ -13,7 +13,7 @@ }, { "product": "3.1.3", - "jmx_exporter": "1.0.1", + "jmx_exporter": "1.0.1-stackable", # Hive 3 must be built with Java 8 but will run on Java 11 "java-base": "11", "java-devel": "8", diff --git a/kafka/versions.py b/kafka/versions.py index ae103ad7e..5b122674a 100644 --- a/kafka/versions.py +++ b/kafka/versions.py @@ -6,7 +6,7 @@ "scala": "2.13", "kcat": "1.7.0", "opa_authorizer": "1.5.1", - "jmx_exporter": "1.0.1", + "jmx_exporter": "1.0.1-stackable", }, { "product": "3.8.0", @@ -15,6 +15,6 @@ "scala": "2.13", "kcat": "1.7.0", "opa_authorizer": "1.5.1", - "jmx_exporter": "1.0.1", + "jmx_exporter": "1.0.1-stackable", }, ] diff --git a/omid/versions.py b/omid/versions.py index 8ed439afe..4ba037180 100644 --- a/omid/versions.py +++ b/omid/versions.py @@ -3,6 +3,6 @@ "product": "1.1.2", "java-base": "11", "java-devel": "11", - "jmx_exporter": "1.0.1", + "jmx_exporter": "1.0.1-stackable", }, ] diff --git a/spark-k8s/versions.py b/spark-k8s/versions.py index 5e72a99d3..a8c62ed56 100644 --- a/spark-k8s/versions.py +++ b/spark-k8s/versions.py @@ -13,7 +13,7 @@ "stax2_api": "4.2.1", # https://mvnrepository.com/artifact/com.fasterxml.jackson.dataformat/jackson-dataformat-xml/2.15.2 "woodstox_core": "6.5.1", # https://mvnrepository.com/artifact/com.fasterxml.jackson.dataformat/jackson-dataformat-xml/2.15.2 "vector": "0.41.1", - "jmx_exporter": "1.0.1", + "jmx_exporter": "1.0.1-stackable", "tini": "0.19.0", "hbase_connector": "1.0.1", }, @@ -31,7 +31,7 @@ "stax2_api": "4.2.1", # https://mvnrepository.com/artifact/com.fasterxml.jackson.dataformat/jackson-dataformat-xml/2.15.2 "woodstox_core": "6.5.1", # https://mvnrepository.com/artifact/com.fasterxml.jackson.dataformat/jackson-dataformat-xml/2.15.2 "vector": "0.41.1", - "jmx_exporter": "1.0.1", + "jmx_exporter": "1.0.1-stackable", "tini": "0.19.0", "hbase_connector": "1.0.1", }, diff --git a/trino/versions.py b/trino/versions.py index 354b25811..96f771922 100644 --- a/trino/versions.py +++ b/trino/versions.py @@ -3,14 +3,14 @@ "product": "451", "java-base": "22", "java-devel": "22", - "jmx_exporter": "1.0.1", + "jmx_exporter": "1.0.1-stackable", "storage_connector": "451", }, { "product": "455", "java-base": "22", "java-devel": "22", - "jmx_exporter": "1.0.1", + "jmx_exporter": "1.0.1-stackable", "storage_connector": "455", }, ] diff --git a/zookeeper/versions.py b/zookeeper/versions.py index c90dc3dea..81af6bbf8 100644 --- a/zookeeper/versions.py +++ b/zookeeper/versions.py @@ -7,6 +7,6 @@ # zookeeper: Execution spotbugs of goal com.github.spotbugs:spotbugs-maven-plugin:4.0.0:spotbugs failed: Java # returned: 1 -> [Help 1] "java-devel": "11", - "jmx_exporter": "1.0.1", + "jmx_exporter": "1.0.1-stackable", }, ] From a15e1c8add159249c16d01d9468f08b650e3161e Mon Sep 17 00:00:00 2001 From: Lars Francke Date: Thu, 7 Nov 2024 14:56:23 +0100 Subject: [PATCH 2/2] Update CHANGELOG.md Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1d81a7a47..77f4e5427 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -38,7 +38,7 @@ All notable changes to this project will be documented in this file. - ubi-rust-builder: Bump Rust toolchain to 1.81.0 ([#902]). - ci: Handle release builds in the same build workflows ([#913]). - hadoop: Bump to `hdfs-utils` 0.4.0 ([#914]). -- jmx exporter: Updated to a custom-built version of 1.0.1 to fix performance regressions ([#920]) +- jmx_exporter: Updated to a custom-built version of 1.0.1 to fix performance regressions ([#920]). ### Removed