Skip to content

chore: Update gitsync to v4.4.0 #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 3, 2025
Merged

chore: Update gitsync to v4.4.0 #990

merged 3 commits into from
Feb 3, 2025

Conversation

@adwk67
Copy link
Member

@adwk67 adwk67 commented Feb 3, 2025 •
edited
Loading

Description

Fixes #987

🟢 Tested with the gitsync integration test:

--- PASS: kuttl (563.83s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-2.9.2_openshift-false_executor-kubernetes (148.17s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-2.10.2_openshift-false_executor-celery (211.42s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-2.9.3_openshift-false_executor-kubernetes (167.46s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-2.9.2_openshift-false_executor-celery (206.06s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-2.9.3_openshift-false_executor-celery (195.18s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-2.10.2_openshift-false_executor-kubernetes (146.30s)
PASS

🟢 Openshift:

--- PASS: kuttl (468.64s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-2.10.2,docker.stackable.tech_sandbox_airflow_2.10.2-stackable0.0.0-dev_openshift-true_executor-kubernetes (455.61s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [x] Changes are OpenShift compatible
- [x] All added packages (via microdnf or otherwise) have a comment on why they are added
- [x] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [x] Add an entry to the CHANGELOG.md file
- [x] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@adwk67 adwk67 marked this pull request as ready for review February 3, 2025 11:58
dervoeti
dervoeti previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67 adwk67 requested a review from dervoeti February 3, 2025 15:30
dervoeti
dervoeti approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67 adwk67 added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit 53da3b0 Feb 3, 2025
3 checks passed
@adwk67 adwk67 deleted the chore/update-gitysnc-to-4.4.0 branch February 3, 2025 15:33
dervoeti pushed a commit that referenced this pull request Feb 26, 2025
@adwk67 @dervoeti
chore: Update gitsync to v4.4.0 (#990)
56966f8 
* chore: Update gitsync to v4.4.0

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dervoeti dervoeti dervoeti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

git-sync 4.4.0 (part of https://github.com/stackabletech/docker-images/issues/964)

3 participants

@adwk67 @dervoeti