Skip to content

Commit 884bc37

Browse files
Apply suggestions from code review
Co-authored-by: Sebastian Bernauer <[email protected]>
1 parent c95fb51 commit 884bc37

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

modules/ROOT/pages/kubernetes/index.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,4 +81,4 @@ Metrics-server is running at https://127.0.0.1:6443/api/v1/namespaces/kube-syste
8181
=== Configuring the cluster domain
8282

8383
In case a non-default cluster domain is used as described in https://kubernetes.io/docs/tasks/administer-cluster/dns-custom-nameservers/[Customizing DNS Service],
84-
Stackable operators can be configured accordingly. This is described in detail in this guide xref:guides:cluster-domain.adoc[Configuring the Kubernetes cluster domain].
84+
Stackable operators can be configured accordingly. This is described in detail in the xref:guides:cluster-domain.adoc[Configuring the Kubernetes cluster domain] guide.

modules/guides/pages/cluster-domain.adoc

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,17 @@
33
:dns-custom-nameservers: https://kubernetes.io/docs/tasks/administer-cluster/dns-custom-nameservers/
44
:dns-pod-service: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/
55

6-
Stackable operators allow to configure a non-default cluster domain as described in {dns-custom-nameservers}[`Customizing DNS Service`] (and more in {dns-pod-service}[`DNS for Services and Pods`]).
7-
The configuration is primarily done via and environment variable `KUBERNETES_CLUSTER_DOMAIN`, but there is also a mechansim to auto detect the cluster domain using the `/etc/resolv.conf` file.
6+
Stackable operators allow to configure a non-default cluster domain as described in {dns-custom-nameservers}[Customizing DNS Service] (and more in {dns-pod-service}[DNS for Services and Pods]).
7+
The configuration is primarily done via and environment variable `KUBERNETES_CLUSTER_DOMAIN`, but there is also a mechanism to auto detect the cluster domain using the `/etc/resolv.conf` file.
88

9-
The following steps explain the use of the environment variable and the auto detection mechanism in detail.
9+
The following steps explain the use of the environment variable and the auto detection mechanism in detail:
1010

1111
== Steps
1212

1313
=== Use environment variable
1414

15-
The environment variable `KUBERNETES_CLUSTER_DOMAIN` takes precedence over auto detection. This means that the desired cluster domain can be configured in a Helm values file via the property `kubernetesClusterDomain` or via the install command like:
15+
The environment variable `KUBERNETES_CLUSTER_DOMAIN` takes precedence over auto detection.
16+
This means that the desired cluster domain can be configured in a Helm values file via the property `kubernetesClusterDomain` or via the install command like:
1617

1718
```
1819
helm install hive-operator stackable-stable/hive-operator --set kubernetesClusterDomain="my-cluster.local"
@@ -37,7 +38,7 @@ Using this example as a base for the cluster domain auto detection, the operator
3738

3839
=== Running locally
3940

40-
This section covers the case when both `KUBERNETES_CLUSTER_DOMAIN` and `KUBERNETES_SERVICE_HOST` are not set. This would be the case if the operator is not running in a clusterized environment like e.g. locally a Laptop or PC.
41+
This section covers the case when both `KUBERNETES_CLUSTER_DOMAIN` and `KUBERNETES_SERVICE_HOST` are not set. This would be the case if the operator is not running in a clusterized environment like e.g. locally on a Laptop or PC.
4142
Running the operator locally is mostly for development and therefore not relevant for most users.
4243

4344
If running locally, and `KUBERNETES_CLUSTER_DOMAIN` and `KUBERNETES_SERVICE_HOST` are not set, the operator will default its cluster domain to `cluster.local`.

0 commit comments

Comments
 (0)