Skip to content

chore: ensure metrics are correctly exposed #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2025
Merged

chore: ensure metrics are correctly exposed #761

merged 3 commits into from
Oct 15, 2025

Conversation

@xeniape
Copy link
Member

@xeniape xeniape commented Oct 13, 2025 •
edited by adwk67
Loading

Description

Part of stackabletech/issues#747
This PR adds Prometheus annotations and adds a pod port for metrics

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@xeniape xeniape self-assigned this Oct 13, 2025
@xeniape xeniape mentioned this pull request Oct 13, 2025
Open
16 tasks
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Oct 13, 2025
@adwk67 adwk67 self-requested a review October 13, 2025 14:18
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 13, 2025
adwk67
adwk67 previously approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:
image

Nit: In the Hive PR Malte replaced these with callouts from operator-rs: https://github.com/stackabletech/druid-operator/pull/761/files#diff-8df1bae7fe400b1c62e55f2dca18cd143b8a7994f7d8fe5a41fd7954f4627aaaR112-R119

@xeniape
Copy link
Member Author

xeniape commented Oct 15, 2025

LGTM: image

Nit: In the Hive PR Malte replaced these with callouts from operator-rs: https://github.com/stackabletech/druid-operator/pull/761/files#diff-8df1bae7fe400b1c62e55f2dca18cd143b8a7994f7d8fe5a41fd7954f4627aaaR112-R119

Yep thank you! Sorry, took a while, wanted to finish the hbase PR first :) d6fb58d

@xeniape xeniape requested a review from adwk67 October 15, 2025 12:24
adwk67
adwk67 approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xeniape xeniape added this pull request to the merge queue Oct 15, 2025
Merged via the queue into main with commit cbbe19e Oct 15, 2025
17 checks passed
@xeniape xeniape deleted the chore/ensure-metrics-correctly-exposed branch October 15, 2025 14:54
@xeniape xeniape moved this from Development: In Review to Development: Done in Stackable Engineering Oct 15, 2025
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Nov 4, 2025
@lfrancke
Copy link
Member

lfrancke commented Nov 4, 2025

Could you please add release notes?

@maltesander
Copy link
Member

maltesander commented Nov 5, 2025

Release snippet

Previously, the druid-operator did not expose Prometheus annotations containing the http(s) scheme or the metrics path and port. This was added in this PR and allows custom relabel configs in Prometheus to use these annotations to scrape the metric endpoints.

@lfrancke lfrancke added release-note Denotes a PR that will be considered when it comes time to generate release notes. release/25.11.0 labels Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

@xeniape xeniape

Labels

release/25.11.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Stackable Engineering
Status: Acceptance: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xeniape @lfrancke @maltesander @adwk67