Addressed review comments.

Author: soenkeliebau

Cargo.toml

@@ -30,4 +30,4 @@ tracing-futures = { version = "0.2", features = ["futures-03"] }
 
 #[patch."https://github.com/stackabletech/operator-rs.git"]
 #stackable-operator = { path = "../operator-rs/crates/stackable-operator" }
-#stackable-operator = { git = "https://github.com/stackabletech//operator-rs.git", branch = "fix/SUP-148" }
+#stackable-operator = { git = "https://github.com/stackabletech//operator-rs.git", branch = "main" }

rust/operator-binary/src/hdfs_clusterrolebinding_nodes_controller.rs

@@ -65,14 +65,14 @@ pub async fn reconcile(
                 Err(e) => {
                     error!(
                         ?object,
-                        ?e,
+                        error = &e as &dyn std::error::Error,
                         "Failed to build serviceAccount name for hdfs cluster"
                     );
                     None
                 }
             }
         })
-        .map(|(meta, sa_name)| {
+        .flat_map(|(meta, sa_name)| {
             let mut result = vec![
                 Subject {
                     kind: "ServiceAccount".to_string(),
@@ -100,7 +100,6 @@ pub async fn reconcile(
             result.dedup();
             result
         })
-        .flat_map(|vec| vec.into_iter())
         .collect();
 
     let patch = Patch::Apply(json!({

rust/operator-binary/src/hdfs_controller.rs

@@ -324,7 +324,6 @@ pub async fn reconcile_hdfs(
     .context(BuildRbacResourcesSnafu)?;
 
     cluster_resources
-        // We clone here because we need to use rbac_sa further down
         .add(client, rbac_sa.clone())
         .await
         .context(ApplyServiceAccountSnafu)?;