Skip to content

Commit 43d4933

Browse files
siegfriedwebersiegfriedweber
committed
chore: Format Python code in the smoke test
1 parent a7ac065 commit 43d4933

File tree

1 file changed

+93
-88
lines changed

1 file changed

+93
-88
lines changed

‎tests/templates/kuttl/smoke/test_metrics.py‎

Lines changed: 93 additions & 88 deletions
Original file line numberDiff line numberDiff line change
@@ -6,114 +6,119 @@
66

77
import requests
88

9+
910
def check_metrics(
10-
namespace: str,
11-
role: str,
12-
port: int,
13-
expected_metrics: list[str]
14-
) -> None:
15-
response: requests.Response = requests.get(
16-
f'http://hdfs-{role}-default-0.hdfs-{role}-default.{namespace}.svc.cluster.local:{port}/metrics',
17-
timeout=10
18-
)
19-
assert response.ok, "Requesting metrics failed"
11+
namespace: str, role: str, port: int, expected_metrics: list[str]
12+
) -> None:
13+
response: requests.Response = requests.get(
14+
f"http://hdfs-{role}-default-0.hdfs-{role}-default.{namespace}.svc.cluster.local:{port}/metrics",
15+
timeout=10,
16+
)
17+
assert response.ok, "Requesting metrics failed"
2018

21-
for metric in expected_metrics:
22-
assert re.search(f'^{metric}', response.text, re.MULTILINE) is not None, \
23-
f"Metric '{metric}' not found for {role}"
19+
for metric in expected_metrics:
20+
assert (
21+
re.search(f"^{metric}", response.text, re.MULTILINE) is not None
22+
), f"Metric '{metric}' not found for {role}"
2423

2524

2625
def check_namenode_metrics(
2726
namespace: str,
2827
product_version: str,
29-
) -> None:
30-
expected_metrics: list[str] = [
31-
# Kind "MetricsSystem"
32-
'hadoop_namenode_num_active_sources{kind="MetricsSystem",role="NameNode",service="HDFS",sub="Stats"}',
33-
# Attribute "Total"
34-
'hadoop_namenode_total{kind="NameNodeInfo",role="NameNode",service="HDFS"}',
35-
# Counter suffixed with "_total"
36-
'hadoop_namenode_files_total{kind="FSNamesystem",role="NameNode",service="HDFS"}',
37-
# Metric suffixed with "_created"
38-
'hadoop_namenode_files_created_{kind="NameNodeActivity",role="NameNode",service="HDFS"}',
39-
# Non-special metric
40-
'hadoop_namenode_files_deleted{kind="NameNodeActivity",role="NameNode",service="HDFS"}',
41-
]
42-
43-
if product_version in ["3.3.4", "3.3.6"]:
44-
# Log counters were removed in 3.4.0 (HADOOP-17524).
45-
expected_metrics.extend([
46-
# Metric suffixed with "_info"
47-
'hadoop_namenode_log_info_{kind="JvmMetrics",role="NameNode",service="HDFS"}',
48-
])
49-
50-
check_metrics(namespace, 'namenode', 8183, expected_metrics)
28+
) -> None:
29+
expected_metrics: list[str] = [
30+
# Kind "MetricsSystem"
31+
'hadoop_namenode_num_active_sources{kind="MetricsSystem",role="NameNode",service="HDFS",sub="Stats"}',
32+
# Attribute "Total"
33+
'hadoop_namenode_total{kind="NameNodeInfo",role="NameNode",service="HDFS"}',
34+
# Counter suffixed with "_total"
35+
'hadoop_namenode_files_total{kind="FSNamesystem",role="NameNode",service="HDFS"}',
36+
# Metric suffixed with "_created"
37+
'hadoop_namenode_files_created_{kind="NameNodeActivity",role="NameNode",service="HDFS"}',
38+
# Non-special metric
39+
'hadoop_namenode_files_deleted{kind="NameNodeActivity",role="NameNode",service="HDFS"}',
40+
]
41+
42+
if product_version in ["3.3.4", "3.3.6"]:
43+
# Log counters were removed in 3.4.0 (HADOOP-17524).
44+
expected_metrics.extend(
45+
[
46+
# Metric suffixed with "_info"
47+
'hadoop_namenode_log_info_{kind="JvmMetrics",role="NameNode",service="HDFS"}',
48+
]
49+
)
50+
51+
check_metrics(namespace, "namenode", 8183, expected_metrics)
5152

5253

5354
def check_datanode_metrics(
5455
namespace: str,
5556
product_version: str,
56-
) -> None:
57-
expected_metrics: list[str] = [
58-
# Kind "MetricsSystem"
59-
'hadoop_datanode_num_active_sources{kind="MetricsSystem",role="DataNode",service="HDFS",sub="Stats"}',
60-
# Kind "FSDatasetState" suffixed with "_total"
61-
'hadoop_datanode_estimated_capacity_lost_total{fsdatasetid=".+",kind="FSDatasetState",role="DataNode",service="HDFS"}',
62-
# Kind "FSDatasetState"
63-
'hadoop_datanode_capacity{fsdatasetid=".+",kind="FSDatasetState",role="DataNode",service="HDFS"}',
64-
# Kind "DataNodeActivity" suffixed with "_info"
65-
'hadoop_datanode_blocks_get_local_path_info_{host="hdfs-datanode-default-0\\.hdfs-datanode-default\\..+\\.svc\\.cluster\\.local",kind="DataNodeActivity",port="9866",role="DataNode",service="HDFS"}',
66-
# Kind "DataNodeActivity"
67-
'hadoop_datanode_blocks_read{host="hdfs-datanode-default-0\\.hdfs-datanode-default\\..+\\.svc\\.cluster\\.local",kind="DataNodeActivity",port="9866",role="DataNode",service="HDFS"}',
68-
# Counter suffixed with "_total"
69-
'hadoop_datanode_estimated_capacity_lost_total{kind="FSDatasetState",role="DataNode",service="HDFS"}',
70-
# Non-special metric
71-
'hadoop_datanode_gc_count{kind="JvmMetrics",role="DataNode",service="HDFS"}',
72-
]
73-
74-
if product_version in ["3.3.4", "3.3.6"]:
75-
# Log counters were removed in 3.4.0 (HADOOP-17524).
76-
expected_metrics.extend([
77-
# Metric suffixed with "_info"
78-
'hadoop_datanode_log_info_{kind="JvmMetrics",role="DataNode",service="HDFS"}',
79-
])
80-
81-
check_metrics(namespace, 'datanode', 8082, expected_metrics)
57+
) -> None:
58+
expected_metrics: list[str] = [
59+
# Kind "MetricsSystem"
60+
'hadoop_datanode_num_active_sources{kind="MetricsSystem",role="DataNode",service="HDFS",sub="Stats"}',
61+
# Kind "FSDatasetState" suffixed with "_total"
62+
'hadoop_datanode_estimated_capacity_lost_total{fsdatasetid=".+",kind="FSDatasetState",role="DataNode",service="HDFS"}',
63+
# Kind "FSDatasetState"
64+
'hadoop_datanode_capacity{fsdatasetid=".+",kind="FSDatasetState",role="DataNode",service="HDFS"}',
65+
# Kind "DataNodeActivity" suffixed with "_info"
66+
'hadoop_datanode_blocks_get_local_path_info_{host="hdfs-datanode-default-0\\.hdfs-datanode-default\\..+\\.svc\\.cluster\\.local",kind="DataNodeActivity",port="9866",role="DataNode",service="HDFS"}',
67+
# Kind "DataNodeActivity"
68+
'hadoop_datanode_blocks_read{host="hdfs-datanode-default-0\\.hdfs-datanode-default\\..+\\.svc\\.cluster\\.local",kind="DataNodeActivity",port="9866",role="DataNode",service="HDFS"}',
69+
# Counter suffixed with "_total"
70+
'hadoop_datanode_estimated_capacity_lost_total{kind="FSDatasetState",role="DataNode",service="HDFS"}',
71+
# Non-special metric
72+
'hadoop_datanode_gc_count{kind="JvmMetrics",role="DataNode",service="HDFS"}',
73+
]
74+
75+
if product_version in ["3.3.4", "3.3.6"]:
76+
# Log counters were removed in 3.4.0 (HADOOP-17524).
77+
expected_metrics.extend(
78+
[
79+
# Metric suffixed with "_info"
80+
'hadoop_datanode_log_info_{kind="JvmMetrics",role="DataNode",service="HDFS"}',
81+
]
82+
)
83+
84+
check_metrics(namespace, "datanode", 8082, expected_metrics)
8285

8386

8487
def check_journalnode_metrics(
8588
namespace: str,
8689
product_version: str,
87-
) -> None:
88-
expected_metrics: list[str] = [
89-
# Kind "MetricsSystem"
90-
'hadoop_journalnode_num_active_sources{kind="MetricsSystem",role="JournalNode",service="HDFS",sub="Stats"}',
91-
# Non-special metric
92-
'hadoop_journalnode_bytes_written{kind="Journal-hdfs",role="JournalNode",service="HDFS"}',
93-
]
94-
95-
if product_version in ["3.3.4", "3.3.6"]:
96-
# Log counters were removed in 3.4.0 (HADOOP-17524).
97-
expected_metrics.extend([
98-
# Metric suffixed with "_info"
99-
'hadoop_journalnode_log_info_{kind="JvmMetrics",role="JournalNode",service="HDFS"}',
100-
])
101-
102-
check_metrics(namespace, 'journalnode', 8081, expected_metrics)
90+
) -> None:
91+
expected_metrics: list[str] = [
92+
# Kind "MetricsSystem"
93+
'hadoop_journalnode_num_active_sources{kind="MetricsSystem",role="JournalNode",service="HDFS",sub="Stats"}',
94+
# Non-special metric
95+
'hadoop_journalnode_bytes_written{kind="Journal-hdfs",role="JournalNode",service="HDFS"}',
96+
]
97+
98+
if product_version in ["3.3.4", "3.3.6"]:
99+
# Log counters were removed in 3.4.0 (HADOOP-17524).
100+
expected_metrics.extend(
101+
[
102+
# Metric suffixed with "_info"
103+
'hadoop_journalnode_log_info_{kind="JvmMetrics",role="JournalNode",service="HDFS"}',
104+
]
105+
)
106+
107+
check_metrics(namespace, "journalnode", 8081, expected_metrics)
103108

104109

105110
if __name__ == "__main__":
106-
namespace_arg: str = sys.argv[1]
107-
product_version_arg: str = sys.argv[2]
111+
namespace_arg: str = sys.argv[1]
112+
product_version_arg: str = sys.argv[2]
108113

109-
logging.basicConfig(
110-
level="DEBUG",
111-
format="%(asctime)s %(levelname)s: %(message)s",
112-
stream=sys.stdout,
113-
)
114+
logging.basicConfig(
115+
level="DEBUG",
116+
format="%(asctime)s %(levelname)s: %(message)s",
117+
stream=sys.stdout,
118+
)
114119

115-
check_namenode_metrics(namespace_arg, product_version_arg)
116-
check_datanode_metrics(namespace_arg, product_version_arg)
117-
check_journalnode_metrics(namespace_arg, product_version_arg)
120+
check_namenode_metrics(namespace_arg, product_version_arg)
121+
check_datanode_metrics(namespace_arg, product_version_arg)
122+
check_journalnode_metrics(namespace_arg, product_version_arg)
118123

119-
print("All expected metrics found")
124+
print("All expected metrics found")

0 commit comments

Comments
 (0)