File tree Expand file tree Collapse file tree 1 file changed +8
-2
lines changed
rust/operator-binary/src/config Expand file tree Collapse file tree 1 file changed +8
-2
lines changed Original file line number Diff line number Diff line change @@ -32,7 +32,14 @@ pub fn construct_global_jvm_args(kerberos_enabled: bool) -> String {
3232 jvm_args. push ( "-Djava.security.krb5.conf=/stackable/kerberos/krb5.conf" . to_owned ( ) ) ;
3333 }
3434
35- // TODO: Handle user input
35+ // We do *not* add user overrides to the global JVM args, but only the role specific JVm arguments.
36+ // This allows users to configure stuff for the server (probably what they want to do), without
37+ // also influencing e.g. startup scripts.
38+ //
39+ // However, this is just an assumptions. If it is wrong users can still envOverride the global
40+ // JVM args.
41+ //
42+ // Please feel absolutely free to change this behavior!
3643 jvm_args. join ( " " )
3744}
3845
@@ -72,7 +79,6 @@ pub fn construct_role_specific_jvm_args(
7279 jvm_args. push ( "-Djava.security.krb5.conf=/stackable/kerberos/krb5.conf" . to_string ( ) ) ;
7380 }
7481
75- // TODO: Handle user input
7682 let operator_generated = JvmArgumentOverrides :: new_with_only_additions ( jvm_args) ;
7783 let merged_jvm_args = hdfs
7884 . get_merged_jvm_argument_overrides ( hdfs_role, role_group, & operator_generated)
You can’t perform that action at this time.
0 commit comments