Skip to content

Commit 1ff9f4c

Browse files
committed
Merge branch 'feat/singleton' into feat/updates
# Conflicts: # .github/workflows/maven.yml # CHANGELOG.md # pom.xml
2 parents 77b606e + c64440f commit 1ff9f4c

File tree

5 files changed

+50
-17
lines changed

5 files changed

+50
-17
lines changed

.github/workflows/maven.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
runs-on: ubuntu-latest
1919

2020
steps:
21-
- uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
21+
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
2222
- name: Set up JDK 17
2323
uses: actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9 # v4.2.1
2424
with:
@@ -28,6 +28,6 @@ jobs:
2828
- name: Build with Maven
2929
run: mvn -P hadoop-3.4.0 -B verify
3030
- name: Update dependency graph
31-
uses: advanced-security/maven-dependency-submission-action@5d0f9011b55d6268922128af45275986303459c3 # v4.0.3
31+
uses: advanced-security/maven-dependency-submission-action@bb3f7338b5bd0e3b225d8082e26b7b6289e17ef3 # v4.1.0
3232
with:
3333
maven-args: -P hadoop-3.4.0

.github/workflows/reviewdog.yml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,50 +13,50 @@ jobs:
1313
actionlint:
1414
runs-on: ubuntu-latest
1515
steps:
16-
- uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
17-
- uses: reviewdog/action-actionlint@89a03f6ba8c0a9fd238e82c075ffb34b86e40291 # v1.46.0
16+
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
17+
- uses: reviewdog/action-actionlint@d99f1ceaf59e7db022a790dc308ccccb68dda71a # v1.53.0
1818
with:
1919
github_token: ${{ secrets.GITHUB_TOKEN }}
2020

2121
detect-secrets:
2222
runs-on: ubuntu-latest
2323
steps:
24-
- uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
25-
- uses: reviewdog/action-detect-secrets@8827bf02944e7d1684d490c2361be0bf6c2d6e7d # v0.21.0
24+
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
25+
- uses: reviewdog/action-detect-secrets@84a331098c48fc892be9af5656f798d0f5f79d81 # v0.25.0
2626
with:
2727
github_token: ${{ secrets.github_token }}
2828

2929
flake8:
3030
runs-on: ubuntu-latest
3131
steps:
32-
- uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
33-
- uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
32+
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
33+
- uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5.1.1
3434
with:
3535
python-version: "3.9"
36-
- uses: reviewdog/action-flake8@51c2708ac3e9463b4d27d0ba7d9e3ded608a6ad3 # tag=v3.8.0
36+
- uses: reviewdog/action-flake8@a16657733fa37bf58a277754fa9c055f0c3aae49 # v3.12.0
3737
with:
3838
github_token: ${{ secrets.GITHUB_TOKEN }}
3939

4040
markdownlint:
4141
runs-on: ubuntu-latest
4242
steps:
43-
- uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
44-
- uses: reviewdog/action-markdownlint@5bc6ad5ba9e1250878f351bafcc7ac0a11dc050f # v0.18.0
43+
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
44+
- uses: reviewdog/action-markdownlint@af20b94e5c376c5b964555d9c21c2d9df8b89975 # v0.23.0
4545
with:
4646
github_token: ${{ secrets.GITHUB_TOKEN }}
4747

4848
shellcheck:
4949
runs-on: ubuntu-latest
5050
steps:
51-
- uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
52-
- uses: reviewdog/action-shellcheck@72365a51bf6476fe952a117c3ff703eb7775e40a # v1.20.0
51+
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
52+
- uses: reviewdog/action-shellcheck@628ce8561be20bfbfb6173cf88c7475ddab95f22 # v1.24.0
5353
with:
5454
github_token: ${{ secrets.GITHUB_TOKEN }}
5555

5656
yamllint:
5757
runs-on: ubuntu-latest
5858
steps:
59-
- uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
60-
- uses: reviewdog/action-yamllint@8d79c3d034667db2792e328936811ed44953d691 # v1.14.0
59+
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
60+
- uses: reviewdog/action-yamllint@c23c5d4cd45b5cc16fa3e6e34073068b228cabeb # v1.17.0
6161
with:
6262
github_token: ${{ secrets.GITHUB_TOKEN }}

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,12 @@ All notable changes to this project will be documented in this file.
66

77
### Changed
88

9+
- Bump okio to 1.17.6 to get rid of CVE-2023-3635 ([#46])
10+
- Performance fixes ([#50])
911
- Updates various dependencies and does a full spotless run. This will now require JDK 17 or later to build (required by later error-prone versions), the build target is still Java 11 [#51]
1012

13+
[#46]: https://github.com/stackabletech/hdfs-utils/pull/46
14+
[#50]: https://github.com/stackabletech/hdfs-utils/pull/50
1115
[#51]: https://github.com/stackabletech/hdfs-utils/pull/51
1216

1317
## [0.3.0] - 2024-07-04

Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
FROM docker.stackable.tech/stackable/hadoop:3.3.6-stackable0.0.0-dev
22

33
COPY --chown=stackable:stackable ./hdfs-utils-*.jar /stackable/hadoop/share/hadoop/tools/lib/
4+
COPY --chown=stackable:stackable ./bom.json /stackable/hadoop/share/hadoop/tools/lib/hdfs-utils.cdx.json

pom.xml

Lines changed: 30 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@
5050
<maven-site-plugin.version>3.12.1</maven-site-plugin.version>
5151
<maven-surefire-plugin.version>3.5.2</maven-surefire-plugin.version>
5252
<spotless-maven-plugin.version>2.43.0</spotless-maven-plugin.version>
53-
<kubernetes-client.version>6.13.4</kubernetes-client.version>
54-
53+
<kubernetes-client.version>6.13.1</kubernetes-client.version>
54+
<okio.version>1.17.6</okio.version>
5555
</properties>
5656

5757
<dependencies>
@@ -95,6 +95,17 @@
9595
<artifactId>kubernetes-client-api</artifactId>
9696
<version>${kubernetes-client.version}</version>
9797
</dependency>
98+
<dependency>
99+
<!--
100+
We bump this here to get rid of a critical CVE in okio 1.15 which we get via kubernetes-client.
101+
We tried understanding _why_ we get 1.15 as dependency:tree for kubernetes-client says we should be getting 1.17.6.
102+
As we failed to understand this we did this short/medium term fix of adding an explicit dependency here which should override the one coming from kubernetes-client.
103+
This can be removed again as soon as we get the proper version from kubernetes-client.
104+
-->
105+
<groupId>com.squareup.okio</groupId>
106+
<artifactId>okio</artifactId>
107+
<version>${okio.version}</version>
108+
</dependency>
98109
<!-- End of needed by topology-provider -->
99110
<dependency>
100111
<groupId>junit</groupId>
@@ -246,6 +257,23 @@
246257
</execution>
247258
</executions>
248259
</plugin>
260+
<plugin>
261+
<groupId>org.cyclonedx</groupId>
262+
<artifactId>cyclonedx-maven-plugin</artifactId>
263+
<version>2.8.0</version>
264+
<configuration>
265+
<projectType>application</projectType>
266+
<schemaVersion>1.5</schemaVersion>
267+
</configuration>
268+
<executions>
269+
<execution>
270+
<phase>package</phase>
271+
<goals>
272+
<goal>makeBom</goal>
273+
</goals>
274+
</execution>
275+
</executions>
276+
</plugin>
249277
</plugins>
250278
</build>
251279

0 commit comments

Comments
 (0)