Skip to content

Commit 2ab4543

Browse files
committed
changed readme to reflect treatment of slashes in group name
1 parent 0f3c32c commit 2ab4543

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,15 @@ The Group Mapper only needs the group listing, which can be requested specifical
3636
"result": {
3737
"groups": {
3838
"groups": [
39-
"/admin",
40-
"/superuser"
39+
"admin",
40+
"superuser"
4141
]
4242
}
4343
}
4444
}
4545
```
4646

47-
The leading slash is required by Opa/Keycloak to allow the definition of subgroups, but this is removed by the group mapper before returning this list of strings to the internal calling routine.
47+
The leading slash is required by Opa/Keycloak to allow the definition of subgroups, but this should be removed by the rego rule before returning this list of strings to the mapper.
4848

4949
## Configuration
5050

@@ -103,7 +103,7 @@ and the Hadoop logs will show that the lookup has taken place:
103103

104104
```text
105105
- Calling StackableGroupMapper.getGroups for user [nn]
106-
- Opa response [{"result":{"groups":{"groups":["/admin","/superuser"]},"users_by_name":{"alice":{"customAttributes":{},"groups":["/superset-admin"],"id":"af07f12c-1234-40a7-93e0-874537bdf3f5","username":"alice"},"bob":{"customAttributes":{},"groups":["/admin"],"id":"af07f12c-2345-40a7-93e0-874537bdf3f5","username":"bob"},"nn":{"customAttributes":{},"groups":["/admin","/superuser"],"id":"af07f12c-7890-40a7-93e0-874537bdf3f5","username":"nn"},"stackable":{"customAttributes":{},"groups":["/admin","/superuser"],"id":"af07f12c-3456-40a7-93e0-874537bdf3f5","username":"stackable"}}}}
106+
- Opa response [{"result":{"groups":{"groups":["admin","superuser"]},"users_by_name":{"alice":{"customAttributes":{},"groups":["/superset-admin"],"id":"af07f12c-1234-40a7-93e0-874537bdf3f5","username":"alice"},"bob":{"customAttributes":{},"groups":["/admin"],"id":"af07f12c-2345-40a7-93e0-874537bdf3f5","username":"bob"},"nn":{"customAttributes":{},"groups":["/admin","/superuser"],"id":"af07f12c-7890-40a7-93e0-874537bdf3f5","username":"nn"},"stackable":{"customAttributes":{},"groups":["/admin","/superuser"],"id":"af07f12c-3456-40a7-93e0-874537bdf3f5","username":"stackable"}}}}
107107
- Groups for [nn]: [[admin, superuser]]
108108
```
109109

0 commit comments

Comments
 (0)