Skip to content
This repository was archived by the owner on Jun 6, 2025. It is now read-only.

Conversation

@razvan
Copy link
Member

@razvan razvan commented Dec 9, 2024

Description

Part of stackabletech/issues#527

Depends on stackabletech/docker-images#950

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@razvan razvan self-assigned this Dec 9, 2024
@razvan razvan requested a review from a team December 9, 2024 16:51
@razvan razvan changed the title chore: bump rust version in stackable base image feat: run containerdebug in the background Dec 10, 2024
nightkr
nightkr previously approved these changes Dec 13, 2024
Copy link
Contributor

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nightkr nightkr dismissed their stale review December 13, 2024 11:52

missing log dir

@nightkr nightkr self-requested a review December 13, 2024 11:52
@nightkr
Copy link
Contributor

nightkr commented Dec 16, 2024

Hm, this is also OOMing for me.

@razvan razvan added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit cb42365 Dec 17, 2024
16 of 17 checks passed
@razvan razvan deleted the feature/containerdebug branch December 17, 2024 13:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants