Skip to content

Commit a914539

Browse files
committed
fix: rustfmt lint
1 parent a0c4617 commit a914539

File tree

10 files changed

+98
-109
lines changed

10 files changed

+98
-109
lines changed

rust/olm-deployer/src/data.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
use anyhow::{anyhow, Context};
2-
use stackable_operator::kube::{api::DynamicObject, ResourceExt};
1+
use anyhow::{Context, anyhow};
2+
use stackable_operator::kube::{ResourceExt, api::DynamicObject};
33

44
pub fn container<'a>(
55
target: &'a mut DynamicObject,

rust/olm-deployer/src/env/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
use stackable_operator::{
22
k8s_openapi::api::{apps::v1::Deployment, core::v1::EnvVar},
33
kube::{
4-
api::{DynamicObject, GroupVersionKind},
54
ResourceExt,
5+
api::{DynamicObject, GroupVersionKind},
66
},
77
};
88

rust/olm-deployer/src/main.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ mod owner;
1717
mod resources;
1818
mod tolerations;
1919

20-
use anyhow::{anyhow, bail, Context, Result};
21-
use clap::{crate_description, crate_version, Parser};
20+
use anyhow::{Context, Result, anyhow, bail};
21+
use clap::{Parser, crate_description, crate_version};
2222
use stackable_operator::{
2323
cli::Command,
2424
client,

rust/olm-deployer/src/owner/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ use stackable_operator::{
55
apimachinery::pkg::apis::meta::v1::OwnerReference,
66
},
77
kube::{
8+
Resource,
89
api::{DynamicObject, ResourceExt},
910
discovery::Scope,
10-
Resource,
1111
},
1212
};
1313

rust/olm-deployer/src/resources/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
use stackable_operator::{
22
k8s_openapi::api::{apps::v1::Deployment, core::v1::ResourceRequirements},
33
kube::{
4-
api::{DynamicObject, GroupVersionKind},
54
ResourceExt,
5+
api::{DynamicObject, GroupVersionKind},
66
},
77
};
88

rust/olm-deployer/src/tolerations/mod.rs

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
use anyhow::{anyhow, Context};
1+
use anyhow::{Context, anyhow};
22
use stackable_operator::{
33
k8s_openapi::api::{apps::v1::Deployment, core::v1::Toleration},
44
kube::{
5-
api::{DynamicObject, GroupVersionKind},
65
ResourceExt,
6+
api::{DynamicObject, GroupVersionKind},
77
},
88
};
99

@@ -27,10 +27,12 @@ pub(super) fn maybe_copy_tolerations(
2727
.pointer_mut("/spec")
2828
.context(anyhow!("DaemonSet named [{tname}] has empty .spec"))?,
2929
path,
30-
)? = serde_json::json!(tolerations
31-
.iter()
32-
.map(|t| serde_json::json!(t))
33-
.collect::<Vec<serde_json::Value>>());
30+
)? = serde_json::json!(
31+
tolerations
32+
.iter()
33+
.map(|t| serde_json::json!(t))
34+
.collect::<Vec<serde_json::Value>>()
35+
);
3436
}
3537
}
3638

@@ -114,11 +116,13 @@ spec:
114116
let mut daemonset = DAEMONSET.clone();
115117
maybe_copy_tolerations(&DEPLOYMENT, &mut daemonset, &gvk)?;
116118

117-
let expected = serde_json::json!(deployment_tolerations(&DEPLOYMENT)
118-
.unwrap()
119-
.iter()
120-
.map(|t| serde_json::json!(t))
121-
.collect::<Vec<serde_json::Value>>());
119+
let expected = serde_json::json!(
120+
deployment_tolerations(&DEPLOYMENT)
121+
.unwrap()
122+
.iter()
123+
.map(|t| serde_json::json!(t))
124+
.collect::<Vec<serde_json::Value>>()
125+
);
122126

123127
assert_eq!(
124128
daemonset.data.pointer("/spec/template/spec/tolerations"),

rust/operator-binary/src/csi_server/controller.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use csi_grpc as csi;
2-
use serde::{de::IntoDeserializer, Deserialize};
2+
use serde::{Deserialize, de::IntoDeserializer};
33
use snafu::{OptionExt, ResultExt, Snafu};
44
use stackable_operator::{
55
commons::listener::{Listener, ListenerClass, ServiceType},
@@ -8,7 +8,7 @@ use stackable_operator::{
88
};
99
use tonic::{Request, Response, Status};
1010

11-
use super::{tonic_unimplemented, ListenerSelector, ListenerVolumeContext};
11+
use super::{ListenerSelector, ListenerVolumeContext, tonic_unimplemented};
1212
use crate::utils::error::error_full_message;
1313

1414
pub struct ListenerOperatorController {

rust/operator-binary/src/csi_server/node.rs

Lines changed: 49 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use std::{fmt::Debug, path::PathBuf};
22

33
use csi_grpc::{self as csi, v1::Topology};
4-
use serde::{de::IntoDeserializer, Deserialize};
4+
use serde::{Deserialize, de::IntoDeserializer};
55
use snafu::{OptionExt, ResultExt, Snafu};
66
use stackable_operator::{
77
builder::meta::OwnerReferenceBuilder,
@@ -17,11 +17,11 @@ use stackable_operator::{
1717
};
1818
use tonic::{Request, Response, Status};
1919

20-
use super::{tonic_unimplemented, ListenerSelector, ListenerVolumeContext};
20+
use super::{ListenerSelector, ListenerVolumeContext, tonic_unimplemented};
2121
use crate::{
2222
listener_controller::{
23-
listener_mounted_pod_label, listener_persistent_volume_label, ListenerMountedPodLabelError,
24-
ListenerPersistentVolumeLabelError,
23+
ListenerMountedPodLabelError, ListenerPersistentVolumeLabelError,
24+
listener_mounted_pod_label, listener_persistent_volume_label,
2525
},
2626
utils::{address::node_primary_addresses, error::error_full_message},
2727
};
@@ -258,10 +258,12 @@ impl csi::v1::node_server::Node for ListenerOperatorNode {
258258
metadata: ObjectMeta {
259259
namespace: Some(ns.clone()),
260260
name: Some(pvc_name.to_string()),
261-
owner_references: Some(vec![OwnerReferenceBuilder::new()
262-
.initialize_from_resource(&pv)
263-
.build()
264-
.context(BuildListenerOwnerRefSnafu)?]),
261+
owner_references: Some(vec![
262+
OwnerReferenceBuilder::new()
263+
.initialize_from_resource(&pv)
264+
.build()
265+
.context(BuildListenerOwnerRefSnafu)?,
266+
]),
265267
// Propagate the labels from the PVC to the Listener object, so it can be found easier, e.g. to
266268
// determine the endpoints of stacklets.
267269
labels: pvc.metadata.labels,
@@ -302,21 +304,17 @@ impl csi::v1::node_server::Node for ListenerOperatorNode {
302304
// Add listener label to PV, allowing traffic to be directed based on reservations, rather than which replicas are *currently* active.
303305
// See https://github.com/stackabletech/listener-operator/issues/220
304306
self.client
305-
.apply_patch(
306-
FIELD_MANAGER_SCOPE,
307-
&pv,
308-
&PersistentVolume {
309-
metadata: ObjectMeta {
310-
labels: Some(listener_persistent_volume_label(&listener).context(
311-
ListenerPvReferenceSnafu {
312-
listener: ObjectRef::from_obj(&listener),
313-
},
314-
)?),
315-
..Default::default()
316-
},
307+
.apply_patch(FIELD_MANAGER_SCOPE, &pv, &PersistentVolume {
308+
metadata: ObjectMeta {
309+
labels: Some(listener_persistent_volume_label(&listener).context(
310+
ListenerPvReferenceSnafu {
311+
listener: ObjectRef::from_obj(&listener),
312+
},
313+
)?),
317314
..Default::default()
318315
},
319-
)
316+
..Default::default()
317+
})
320318
.await
321319
.with_context(|_| AddListenerLabelToPvSnafu {
322320
pv: ObjectRef::from_obj(&pv),
@@ -327,23 +325,20 @@ impl csi::v1::node_server::Node for ListenerOperatorNode {
327325
// IMPORTANT
328326
// Use a merge patch rather than an apply so that we don't delete labels added by other listener volumes.
329327
// Volumes aren't hot-swappable anyway, and all labels will be removed when the pod is deleted.
330-
.merge_patch(
331-
&pod,
332-
&Pod {
333-
metadata: ObjectMeta {
334-
labels: Some(
335-
[listener_mounted_pod_label(&listener).context(
336-
ListenerPodSelectorSnafu {
337-
listener: ObjectRef::from_obj(&listener),
338-
},
339-
)?]
340-
.into(),
341-
),
342-
..Default::default()
343-
},
328+
.merge_patch(&pod, &Pod {
329+
metadata: ObjectMeta {
330+
labels: Some(
331+
[listener_mounted_pod_label(&listener).context(
332+
ListenerPodSelectorSnafu {
333+
listener: ObjectRef::from_obj(&listener),
334+
},
335+
)?]
336+
.into(),
337+
),
344338
..Default::default()
345339
},
346-
)
340+
..Default::default()
341+
})
347342
.await
348343
.with_context(|_| AddListenerLabelToPodSnafu {
349344
pod: ObjectRef::from_obj(&pod),
@@ -517,29 +512,28 @@ async fn publish_pod_listener(
517512
metadata: ObjectMeta {
518513
name: pod.metadata.uid.as_deref().map(|uid| format!("pod-{uid}")),
519514
namespace: pod.metadata.namespace.clone(),
520-
owner_references: Some(vec![OwnerReferenceBuilder::new()
521-
.initialize_from_resource(pod)
522-
.build()
523-
.context(BuildListenerOwnerRefSnafu)?]),
515+
owner_references: Some(vec![
516+
OwnerReferenceBuilder::new()
517+
.initialize_from_resource(pod)
518+
.build()
519+
.context(BuildListenerOwnerRefSnafu)?,
520+
]),
524521
..Default::default()
525522
},
526523
spec: PodListenersSpec {
527-
listeners: [(
528-
listener_pod_volume.name.clone(),
529-
PodListener {
530-
scope: if listener
531-
.status
532-
.as_ref()
533-
.and_then(|s| s.node_ports.as_ref())
534-
.is_some()
535-
{
536-
PodListenerScope::Node
537-
} else {
538-
PodListenerScope::Cluster
539-
},
540-
ingress_addresses: Some(listener_addresses.to_vec()),
524+
listeners: [(listener_pod_volume.name.clone(), PodListener {
525+
scope: if listener
526+
.status
527+
.as_ref()
528+
.and_then(|s| s.node_ports.as_ref())
529+
.is_some()
530+
{
531+
PodListenerScope::Node
532+
} else {
533+
PodListenerScope::Cluster
541534
},
542-
)]
535+
ingress_addresses: Some(listener_addresses.to_vec()),
536+
})]
543537
.into(),
544538
},
545539
};

rust/operator-binary/src/listener_controller.rs

Lines changed: 20 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ use std::{
55

66
use const_format::concatcp;
77
use futures::{
8-
future::{try_join, try_join_all},
98
StreamExt,
9+
future::{try_join, try_join_all},
1010
};
1111
use snafu::{OptionExt, ResultExt, Snafu};
1212
#[cfg(doc)]
@@ -24,26 +24,26 @@ use stackable_operator::{
2424
apimachinery::pkg::apis::meta::v1::LabelSelector,
2525
},
2626
kube::{
27+
Resource, ResourceExt,
2728
api::{DynamicObject, ObjectMeta},
28-
core::{error_boundary, DeserializeGuard},
29+
core::{DeserializeGuard, error_boundary},
2930
runtime::{
3031
controller,
3132
events::{Recorder, Reporter},
3233
reflector::ObjectRef,
3334
watcher,
3435
},
35-
Resource, ResourceExt,
3636
},
3737
kvp::{Annotations, Labels},
38-
logging::controller::{report_controller_reconciled, ReconcilerError},
38+
logging::controller::{ReconcilerError, report_controller_reconciled},
3939
time::Duration,
4040
};
4141
use strum::IntoStaticStr;
4242

4343
use crate::{
44-
csi_server::node::NODE_TOPOLOGY_LABEL_HOSTNAME,
45-
utils::address::{node_primary_addresses, AddressCandidates},
4644
APP_NAME, OPERATOR_KEY,
45+
csi_server::node::NODE_TOPOLOGY_LABEL_HOSTNAME,
46+
utils::address::{AddressCandidates, node_primary_addresses},
4747
};
4848

4949
const OPERATOR_NAME: &str = "listeners.stackable.tech";
@@ -56,13 +56,10 @@ pub async fn run(client: stackable_operator::client::Client) {
5656
watcher::Config::default(),
5757
);
5858
let listener_store = controller.store();
59-
let event_recorder = Arc::new(Recorder::new(
60-
client.as_kube_client(),
61-
Reporter {
62-
controller: FULL_CONTROLLER_NAME.to_string(),
63-
instance: None,
64-
},
65-
));
59+
let event_recorder = Arc::new(Recorder::new(client.as_kube_client(), Reporter {
60+
controller: FULL_CONTROLLER_NAME.to_string(),
61+
instance: None,
62+
}));
6663
controller
6764
.owns(
6865
client.get_all_api::<DeserializeGuard<Service>>(),
@@ -302,15 +299,12 @@ pub async fn reconcile(
302299
port,
303300
protocol,
304301
}| {
305-
(
306-
(protocol, name),
307-
ServicePort {
308-
name: Some(name.clone()),
309-
protocol: protocol.clone(),
310-
port: *port,
311-
..Default::default()
312-
},
313-
)
302+
((protocol, name), ServicePort {
303+
name: Some(name.clone()),
304+
protocol: protocol.clone(),
305+
port: *port,
306+
..Default::default()
307+
})
314308
},
315309
)
316310
// Deduplicate ports by (protocol, name)
@@ -527,13 +521,10 @@ async fn node_names_for_nodeport_listener(
527521
let (pvs, endpoints) = try_join(
528522
async {
529523
client
530-
.list_with_label_selector::<PersistentVolume>(
531-
&(),
532-
&LabelSelector {
533-
match_labels: Some(listener_persistent_volume_label(listener).unwrap()),
534-
..Default::default()
535-
},
536-
)
524+
.list_with_label_selector::<PersistentVolume>(&(), &LabelSelector {
525+
match_labels: Some(listener_persistent_volume_label(listener).unwrap()),
526+
..Default::default()
527+
})
537528
.await
538529
.context(GetListenerPvsSnafu)
539530
},

rust/operator-binary/src/main.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
11
use std::{os::unix::prelude::FileTypeExt, path::PathBuf};
22

3-
use clap::{crate_description, crate_version, Parser};
3+
use clap::{Parser, crate_description, crate_version};
44
use csi_grpc::v1::{
55
controller_server::ControllerServer, identity_server::IdentityServer, node_server::NodeServer,
66
};
77
use csi_server::{
88
controller::ListenerOperatorController, identity::ListenerOperatorIdentity,
99
node::ListenerOperatorNode,
1010
};
11-
use futures::{pin_mut, FutureExt, TryStreamExt};
11+
use futures::{FutureExt, TryStreamExt, pin_mut};
1212
use stackable_operator::{
13+
CustomResourceExt,
1314
commons::listener::{Listener, ListenerClass, PodListeners},
1415
logging::TracingTarget,
1516
utils::cluster_info::KubernetesClusterInfoOpts,
16-
CustomResourceExt,
1717
};
18-
use tokio::signal::unix::{signal, SignalKind};
18+
use tokio::signal::unix::{SignalKind, signal};
1919
use tokio_stream::wrappers::UnixListenerStream;
2020
use tonic::transport::Server;
21-
use utils::unix_stream::{uds_bind_private, TonicUnixStream};
21+
use utils::unix_stream::{TonicUnixStream, uds_bind_private};
2222

2323
mod csi_server;
2424
mod listener_controller;

0 commit comments

Comments
 (0)