Skip to content

docs: Document how to use ListenHTTP #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbernauer merged 7 commits into from
Mar 26, 2025
Merged

docs: Document how to use ListenHTTP #765

sbernauer merged 7 commits into from
Mar 26, 2025

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Mar 24, 2025

Description

Deployed this at a customer setup, it's probably worth documenting publicly.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Mar 24, 2025
@sbernauer sbernauer self-assigned this Mar 24, 2025
@NickLarsenNZ NickLarsenNZ self-requested a review March 24, 2025 11:59
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 24, 2025
razvan
razvan reviewed Mar 24, 2025
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Made some suggestions to make it sound a bit less colloquial.

NickLarsenNZ
NickLarsenNZ reviewed Mar 24, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions

razvan
razvan previously approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

NickLarsenNZ
NickLarsenNZ approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Mar 26, 2025
Merged via the queue into main with commit dd338e6 Mar 26, 2025
14 of 17 checks passed
@sbernauer sbernauer deleted the docs/listen-http branch March 26, 2025 13:24
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Mar 26, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

@razvan razvan razvan left review comments

Assignees

@sbernauer sbernauer

Labels

customer-request release/25.3.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sbernauer @razvan @NickLarsenNZ @lfrancke