chore: separate impls from crd data structures

This makes way for the versioned module we will soon introduce

Author: NickLarsenNZ

rust/operator-binary/src/crd/mod.rs

@@ -122,16 +122,6 @@ pub enum CurrentlySupportedListenerClasses {
     ExternalStable,
 }
 
-impl CurrentlySupportedListenerClasses {
-    pub fn k8s_service_type(&self) -> String {
-        match self {
-            CurrentlySupportedListenerClasses::ClusterInternal => "ClusterIP".to_string(),
-            CurrentlySupportedListenerClasses::ExternalUnstable => "NodePort".to_string(),
-            CurrentlySupportedListenerClasses::ExternalStable => "LoadBalancer".to_string(),
-        }
-    }
-}
-
 #[allow(clippy::derive_partial_eq_without_eq)]
 #[derive(Clone, Debug, Default, Fragment, JsonSchema, PartialEq)]
 #[fragment_attrs(
@@ -201,6 +191,42 @@ pub struct OpaConfig {
     pub graceful_shutdown_timeout: Option<Duration>,
 }
 
+#[derive(
+    EnumIter,
+    Clone,
+    Debug,
+    Hash,
+    Deserialize,
+    Eq,
+    JsonSchema,
+    PartialEq,
+    Serialize,
+    Display,
+    EnumString,
+)]
+pub enum OpaRole {
+    #[serde(rename = "server")]
+    #[strum(serialize = "server")]
+    Server,
+}
+
+#[derive(Clone, Default, Debug, Deserialize, Eq, JsonSchema, PartialEq, Serialize)]
+#[serde(rename_all = "camelCase")]
+pub struct OpaClusterStatus {
+    #[serde(default)]
+    pub conditions: Vec<ClusterCondition>,
+}
+
+impl CurrentlySupportedListenerClasses {
+    pub fn k8s_service_type(&self) -> String {
+        match self {
+            CurrentlySupportedListenerClasses::ClusterInternal => "ClusterIP".to_string(),
+            CurrentlySupportedListenerClasses::ExternalUnstable => "NodePort".to_string(),
+            CurrentlySupportedListenerClasses::ExternalStable => "LoadBalancer".to_string(),
+        }
+    }
+}
+
 impl OpaConfig {
     fn default_config() -> OpaConfigFragment {
         OpaConfigFragment {
@@ -256,25 +282,6 @@ impl Configuration for OpaConfigFragment {
     }
 }
 
-#[derive(
-    EnumIter,
-    Clone,
-    Debug,
-    Hash,
-    Deserialize,
-    Eq,
-    JsonSchema,
-    PartialEq,
-    Serialize,
-    Display,
-    EnumString,
-)]
-pub enum OpaRole {
-    #[serde(rename = "server")]
-    #[strum(serialize = "server")]
-    Server,
-}
-
 impl OpaCluster {
     /// Returns a reference to the role.
     pub fn role(&self, role_variant: &OpaRole) -> &Role<OpaConfigFragment, EmptyRoleConfig> {
@@ -354,13 +361,6 @@ impl OpaCluster {
     }
 }
 
-#[derive(Clone, Default, Debug, Deserialize, Eq, JsonSchema, PartialEq, Serialize)]
-#[serde(rename_all = "camelCase")]
-pub struct OpaClusterStatus {
-    #[serde(default)]
-    pub conditions: Vec<ClusterCondition>,
-}
-
 impl HasStatusCondition for OpaCluster {
     fn conditions(&self) -> Vec<ClusterCondition> {
         match &self.status {

rust/operator-binary/src/crd/user_info_fetcher.rs

@@ -38,12 +38,6 @@ pub enum Backend {
     ActiveDirectory(ActiveDirectoryBackend),
 }
 
-impl Default for Backend {
-    fn default() -> Self {
-        Self::None {}
-    }
-}
-
 #[derive(Clone, Debug, Deserialize, Eq, JsonSchema, PartialEq, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct KeycloakBackend {
@@ -75,10 +69,6 @@ pub struct KeycloakBackend {
     pub user_realm: String,
 }
 
-fn default_root_path() -> String {
-    "/".to_string()
-}
-
 #[derive(Clone, Debug, Deserialize, Eq, JsonSchema, PartialEq, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct AasBackend {
@@ -90,10 +80,6 @@ pub struct AasBackend {
     pub port: u16,
 }
 
-fn aas_default_port() -> u16 {
-    5000
-}
-
 #[derive(Clone, Debug, Deserialize, Eq, JsonSchema, PartialEq, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct ActiveDirectoryBackend {
@@ -125,6 +111,20 @@ pub struct Cache {
     pub entry_time_to_live: Duration,
 }
 
+impl Default for Backend {
+    fn default() -> Self {
+        Self::None {}
+    }
+}
+
+fn default_root_path() -> String {
+    "/".to_string()
+}
+
+fn aas_default_port() -> u16 {
+    5000
+}
+
 impl Cache {
     const fn default_entry_time_to_live() -> Duration {
         Duration::from_minutes_unchecked(1)