Skip to content

Commit edbe052

Browse files
committed
Add comment about bundle builder log rotation
1 parent 412e713 commit edbe052

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

rust/operator-binary/src/controller.rs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -104,17 +104,20 @@ const DEFAULT_CONSOLE_LOG_LEVEL: LogLevel = LogLevel::INFO;
104104
const DEFAULT_SERVER_LOG_LEVEL: LogLevel = LogLevel::INFO;
105105
const DEFAULT_DECISION_LOG_LEVEL: LogLevel = LogLevel::NONE;
106106

107-
// bundle builder: ~ 5 MB x 5
108-
// these sizes are needed both for the single file (for rotation, in bytes) as well as the total (for the EmptyDir)
107+
// Bundle builder: ~ 5 MB x 5
108+
// These sizes are needed both for the single file (for rotation, in bytes) as well as the total (for the EmptyDir).
109+
//
110+
// Ideally, we would rotate the logs by size, but this is currently not supported due to upstream issues.
111+
// Please see https://github.com/stackabletech/opa-operator/issues/606 for more details.
109112
const OPA_ROLLING_BUNDLE_BUILDER_LOG_FILE_SIZE_MB: u32 = 5;
110113
const OPA_ROLLING_BUNDLE_BUILDER_LOG_FILES: u32 = 5;
111114
const MAX_OPA_BUNDLE_BUILDER_LOG_FILE_SIZE: MemoryQuantity = MemoryQuantity {
112115
value: (OPA_ROLLING_BUNDLE_BUILDER_LOG_FILE_SIZE_MB * OPA_ROLLING_BUNDLE_BUILDER_LOG_FILES)
113116
as f32,
114117
unit: BinaryMultiple::Mebi,
115118
};
116-
// opa logs: ~ 5 MB x 2
117-
// these sizes are needed both for the single file (for multilog, in bytes) as well as the total (for the EmptyDir)
119+
// OPA logs: ~ 5 MB x 2
120+
// These sizes are needed both for the single file (for multilog, in bytes) as well as the total (for the EmptyDir).
118121
const OPA_ROLLING_LOG_FILE_SIZE_MB: u32 = 5;
119122
const OPA_ROLLING_LOG_FILE_SIZE_BYTES: u32 = OPA_ROLLING_LOG_FILE_SIZE_MB * 1000000;
120123
const OPA_ROLLING_LOG_FILES: u32 = 2;

0 commit comments

Comments
 (0)