Apply suggestions from code review

sbernauer · Techassi · web-flow · commit 27f322d2f23b · 2024-11-22T15:40:25.000+01:00
Co-authored-by: Techassi &lt;git@techassi.dev&gt;
diff --git a/crates/stackable-operator/src/commons/authentication/oidc.rs b/crates/stackable-operator/src/commons/authentication/oidc.rs
@@ -113,7 +113,7 @@ impl AuthenticationProvider {
         }
     }
 
-    /// Returns the base [`Url`] without any path segments.
+    /// Returns the OIDC base [`Url`] without any path segments.
     ///
     /// The base url only contains the scheme, the host, and an optional port.
     fn base_url(&self) -> Result<Url> {
@@ -147,7 +147,7 @@ impl AuthenticationProvider {
         Ok(url)
     }
 
-    /// Returns the well-known [`Url`] without a trailing slash.
+    /// Returns the well-known OIDC configuration [`Url`] without a trailing slash.
     ///
     /// The returned url is a combination of [`Self::endpoint_url`] joined with
     /// the well-known OIDC configuration path `DEFAULT_WELLKNOWN_OIDC_CONFIG_PATH`.

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ impl AuthenticationProvider {`
`113`	`113`	`}`
`114`	`114`	`}`
`115`	`115`
`116`		- /// Returns the base [`Url`] without any path segments.
	`116`	+ /// Returns the OIDC base [`Url`] without any path segments.
`117`	`117`	`///`
`118`	`118`	`/// The base url only contains the scheme, the host, and an optional port.`
`119`	`119`	`fn base_url(&self) -> Result<Url> {`
`@@ -147,7 +147,7 @@ impl AuthenticationProvider {`
`147`	`147`	`Ok(url)`
`148`	`148`	`}`
`149`	`149`
`150`		- /// Returns the well-known [`Url`] without a trailing slash.
	`150`	+ /// Returns the well-known OIDC configuration [`Url`] without a trailing slash.
`151`	`151`	`///`
`152`	`152`	/// The returned url is a combination of [`Self::endpoint_url`] joined with
`153`	`153`	/// the well-known OIDC configuration path `DEFAULT_WELLKNOWN_OIDC_CONFIG_PATH`.