Skip to content

Commit 34d6db8

Browse files
sbernauerTechassi
andauthored
Apply suggestions from code review
Co-authored-by: Techassi <[email protected]>
1 parent 7dc2394 commit 34d6db8

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

crates/stackable-operator/src/commons/authentication/ldap.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ pub enum Error {
3535
)]
3636
#[serde(rename_all = "camelCase")]
3737
pub struct AuthenticationProvider {
38-
/// Host of the LDAP server, for example: `my.ldap.server`.
38+
/// Host of the LDAP server, for example: `my.ldap.server` or `127.0.0.1`.
3939
pub hostname: Host,
4040

4141
/// Port of the LDAP server. If TLS is used defaults to 636 otherwise to 389.

crates/stackable-operator/src/commons/authentication/oidc.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ pub enum Error {
4242
)]
4343
#[serde(rename_all = "camelCase")]
4444
pub struct AuthenticationProvider {
45-
/// Host of the identity provider, e.g. `my.keycloak.corp`.
45+
/// Host of the identity provider, e.g. `my.keycloak.corp` or `127.0.0.1`.
4646
hostname: Host,
4747

4848
/// Port of the identity provider. If TLS is used defaults to 443,

crates/stackable-operator/src/commons/networking.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ impl TryFrom<String> for Host {
9393

9494
impl From<Host> for String {
9595
fn from(value: Host) -> Self {
96-
format!("{value}")
96+
value.to_string()
9797
}
9898
}
9999

0 commit comments

Comments
 (0)