refactor: Simplify From and Build trait usages

Author: Techassi

crates/stackable-telemetry/src/tracing/settings/console_log.rs

@@ -48,32 +48,30 @@ impl ConsoleLogSettingsBuilder {
     }
 
     pub fn build(self) -> ConsoleLogSettings {
-        self.into()
-    }
-}
-
-impl From<ConsoleLogSettingsBuilder> for ConsoleLogSettings {
-    fn from(value: ConsoleLogSettingsBuilder) -> Self {
-        Self {
-            common_settings: value.common_settings,
-            log_format: value.log_format,
+        ConsoleLogSettings {
+            common_settings: self.common_settings,
+            log_format: self.log_format,
         }
     }
 }
 
+/// This implementation is used to turn the common settings builder into the console log specific
+/// settings builder via the [`SettingsBuilder::console_log_settings_builder`] function.
 impl From<SettingsBuilder> for ConsoleLogSettingsBuilder {
     fn from(value: SettingsBuilder) -> Self {
         Self {
-            common_settings: value.into(),
+            common_settings: value.build(),
             log_format: Format::default(),
         }
     }
 }
 
+/// This implementation is used to build console log settings from common settings without
+/// specifying console log specific settings.
 impl Build<ConsoleLogSettings> for SettingsBuilder {
     fn build(self) -> ConsoleLogSettings {
         ConsoleLogSettings {
-            common_settings: self.into(),
+            common_settings: self.build(),
             ..Default::default()
         }
     }

crates/stackable-telemetry/src/tracing/settings/mod.rs

@@ -52,7 +52,7 @@ impl Settings {
 
 impl Default for Settings {
     fn default() -> Self {
-        SettingsBuilder::default().into()
+        SettingsBuilder::default().build()
     }
 }
 
@@ -71,7 +71,11 @@ pub trait Build<T> {
 
 impl Build<Settings> for SettingsBuilder {
     fn build(self) -> Settings {
-        self.into()
+        Settings {
+            environment_variable: self.environment_variable,
+            default_level: self.default_level,
+            enabled: self.enabled,
+        }
     }
 }
 
@@ -134,16 +138,6 @@ impl Default for SettingsBuilder {
     }
 }
 
-impl From<SettingsBuilder> for Settings {
-    fn from(value: SettingsBuilder) -> Self {
-        Self {
-            environment_variable: value.environment_variable,
-            default_level: value.default_level,
-            enabled: value.enabled,
-        }
-    }
-}
-
 #[cfg(test)]
 mod test {
     use super::*;

crates/stackable-telemetry/src/tracing/settings/otlp_log.rs

@@ -15,30 +15,28 @@ pub struct OtlpLogSettingsBuilder {
 
 impl OtlpLogSettingsBuilder {
     pub fn build(self) -> OtlpLogSettings {
-        self.into()
+        OtlpLogSettings {
+            common_settings: self.common_settings,
+        }
     }
 }
 
+/// This implementation is used to turn the common settings builder into the OTLP log specific
+/// settings builder via the [`SettingsBuilder::otlp_log_settings_builder`] function.
 impl From<SettingsBuilder> for OtlpLogSettingsBuilder {
     fn from(value: SettingsBuilder) -> Self {
         Self {
-            common_settings: value.into(),
-        }
-    }
-}
-
-impl From<OtlpLogSettingsBuilder> for OtlpLogSettings {
-    fn from(value: OtlpLogSettingsBuilder) -> Self {
-        Self {
-            common_settings: value.common_settings,
+            common_settings: value.build(),
         }
     }
 }
 
+/// This implementation is used to build OTLP log settings from common settings without
+/// specifying OTLP log specific settings.
 impl Build<OtlpLogSettings> for SettingsBuilder {
     fn build(self) -> OtlpLogSettings {
         OtlpLogSettings {
-            common_settings: self.into(),
+            common_settings: self.build(),
             // ..Default::default()
         }
     }

crates/stackable-telemetry/src/tracing/settings/otlp_trace.rs

@@ -15,30 +15,28 @@ pub struct OtlpTraceSettingsBuilder {
 
 impl OtlpTraceSettingsBuilder {
     pub fn build(self) -> OtlpTraceSettings {
-        self.into()
+        OtlpTraceSettings {
+            common_settings: self.common_settings,
+        }
     }
 }
 
+/// This implementation is used to turn the common settings builder into the OTLP trace specific
+/// settings builder via the [`SettingsBuilder::otlp_trace_settings_builder`] function.
 impl From<SettingsBuilder> for OtlpTraceSettingsBuilder {
     fn from(value: SettingsBuilder) -> Self {
         Self {
-            common_settings: value.into(),
-        }
-    }
-}
-
-impl From<OtlpTraceSettingsBuilder> for OtlpTraceSettings {
-    fn from(value: OtlpTraceSettingsBuilder) -> Self {
-        Self {
-            common_settings: value.common_settings,
+            common_settings: value.build(),
         }
     }
 }
 
+/// This implementation is used to build OTLP trace settings from common settings without
+/// specifying OTLP trace specific settings.
 impl Build<OtlpTraceSettings> for SettingsBuilder {
     fn build(self) -> OtlpTraceSettings {
         OtlpTraceSettings {
-            common_settings: self.into(),
+            common_settings: self.build(),
             // ..Default::default()
         }
     }