Skip to content

Commit 5969711

Browse files
Apply suggestions from code review
Co-authored-by: Nick <[email protected]>
1 parent 20fa37e commit 5969711

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

crates/stackable-operator/src/commons/authentication/oidc.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,9 @@ impl AuthenticationProvider {
116116
/// path at [`DEFAULT_OIDC_WELLKNOWN_PATH`].
117117
pub fn endpoint_url(&self) -> Result<Url> {
118118
let mut url = Url::parse(&format!(
119-
"http://{}:{}",
120-
self.hostname.as_url_host(),
121-
self.port()
119+
"http://{host}:{port}",
120+
host = self.hostname.as_url_host(),
121+
port = self.port()
122122
))
123123
.context(ParseOidcEndpointUrlSnafu)?;
124124

crates/stackable-operator/src/commons/s3/helpers.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,9 @@ impl ResolvedS3Connection {
4848
/// Build the endpoint URL from this connection
4949
pub fn endpoint(&self) -> Result<Url, S3Error> {
5050
let mut url = Url::parse(&format!(
51-
"http://{}:{}",
52-
self.host.as_url_host(),
53-
self.port()
51+
"http://{host}:{port}",
52+
host = self.host.as_url_host(),
53+
port = self.port()
5454
))
5555
.context(ParseS3EndpointSnafu)?;
5656

0 commit comments

Comments
 (0)