Skip to content

Commit 5b152c7

Browse files
refactor(stackable-telemetry)!: Improve stackable-telemetry to make it easier to build the TraceGuard (#901)
* chore(stackable-telemetry): move tracing to a module directory * feat(stackable-telemetry): Add a settings builder and implement it for console logging * feat(stackable-telemetry): Add a settings builder for the otlp trace exporter * feat(stackable-telemetry): Add a settings builder for the otlp log exporter * chore(stackable-telemetry): Make settings available to the Tracing::init() function * chore(stackable-telemetry): Introduce the CommonSettings trait for quicker access to common settings from subscriber specific settings * refactor(stackable-telemetry): Rename env_var() for consistency, reorder fields * chore(stackable-telemetry): Add SettingsDouble and SettingsTriple tuple and From impls as a config shortcut similar to before this PR * chore(stackable-telemetry): Resolve clippy warnings * refactor(stackable-telemetry): Prefix builder methods with `with_`. I avoided prefixing `enabled()` because it sounds strange. * refactor(stackable-telemetry): Revert SettingsDouble/SettingsTriple Note: They will appear in a future PR * docs(stackable-telemetry): Partially add docs Note: More docs will appear in a future PR so that this PR isn't a blocker. Tip: Enable `#![warn(missing_docs)]` * refactor: Simplify From and Build trait usages * refactor: Provide centralized default impls for CommonSettings trait * docs: Fix doc tests * docs: Fix doc comment references * refactor: Use Deref instead of CommonSettings trait * chore(stackable-telemetry): Apply suggestions from code review Co-authored-by: Techassi <[email protected]> * chore(stackable-telemetry): Update changelog --------- Co-authored-by: Techassi <[email protected]> Co-authored-by: Techassi <[email protected]>
1 parent 41c439c commit 5b152c7

File tree

6 files changed

+576
-100
lines changed

6 files changed

+576
-100
lines changed

crates/stackable-telemetry/CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,17 @@ All notable changes to this project will be documented in this file.
44

55
## [Unreleased]
66

7+
### Added
8+
9+
- Introduce common `Settings` and subscriber specific settings ([#901]).
10+
11+
### Changed
12+
13+
- BREAKING: Renamed `TracingBuilder` methods with long names, and prefix with `with_` ([#901]).
14+
- BREAKING: Use the new subscriber settings in the `TracingBuilder` ([#901]).
15+
16+
[#901]: https://github.com/stackabletech/operator-rs/pull/901
17+
718
## [0.2.0] - 2024-07-10
819

920
### Changed

0 commit comments

Comments
 (0)