Apply suggestions from code review

Co-authored-by: Techassi <[email protected]>

Author: sbernauer

crates/stackable-operator/src/commons/authentication/ldap.rs

@@ -32,10 +32,10 @@ pub enum Error {
     #[snafu(display("failed to add LDAP TLS client details volumes and volume mounts"))]
     AddLdapTlsClientDetailsVolumes { source: TlsClientDetailsError },
 
-    #[snafu(display("failed to add needed volumes"))]
+    #[snafu(display("failed to add required volumes"))]
     AddVolumes { source: builder::pod::Error },
 
-    #[snafu(display("failed to add needed volumeMounts"))]
+    #[snafu(display("failed to add required volumeMounts"))]
     AddVolumeMounts {
         source: builder::pod::container::Error,
     },

crates/stackable-operator/src/commons/s3/mod.rs

@@ -34,10 +34,10 @@ pub enum S3Error {
     #[snafu(display("failed to add S3 TLS client details volumes and volume mounts"))]
     AddS3TlsClientDetailsVolumes { source: TlsClientDetailsError },
 
-    #[snafu(display("failed to add needed volumes"))]
+    #[snafu(display("failed to add required volumes"))]
     AddVolumes { source: builder::pod::Error },
 
-    #[snafu(display("failed to add needed volumeMounts"))]
+    #[snafu(display("failed to add required volumeMounts"))]
     AddVolumeMounts {
         source: builder::pod::container::Error,
     },

crates/stackable-operator/src/commons/tls_verification.rs

@@ -19,10 +19,10 @@ pub enum TlsClientDetailsError {
     #[snafu(display("failed to convert secret class volume into named Kubernetes volume"))]
     SecretClassVolume { source: SecretClassVolumeError },
 
-    #[snafu(display("failed to add needed volumes"))]
+    #[snafu(display("failed to add required volumes"))]
     AddVolumes { source: builder::pod::Error },
 
-    #[snafu(display("failed to add needed volumeMounts"))]
+    #[snafu(display("failed to add required volumeMounts"))]
     AddVolumeMounts {
         source: builder::pod::container::Error,
     },

crates/stackable-operator/src/product_logging/framework.rs

@@ -40,7 +40,7 @@ pub enum LoggingError {
         source: builder::pod::container::Error,
     },
 
-    #[snafu(display("failed to add needed volumeMounts"))]
+    #[snafu(display("failed to add required volumeMounts"))]
     AddVolumeMounts {
         source: builder::pod::container::Error,
     },