Add some error details

Author: sbernauer

crates/stackable-operator/src/commons/s3/helpers.rs

@@ -38,7 +38,9 @@ impl S3ConnectionInlineOrReference {
             Self::Reference(reference) => Ok(client
                 .get::<S3Connection>(&reference, namespace)
                 .await
-                .context(RetrieveS3ConnectionSnafu)?
+                .context(RetrieveS3ConnectionSnafu {
+                    s3_connection: reference,
+                })?
                 .spec),
         }
     }
@@ -47,12 +49,12 @@ impl S3ConnectionInlineOrReference {
 impl ResolvedS3Connection {
     /// Build the endpoint URL from this connection
     pub fn endpoint(&self) -> Result<Url, S3Error> {
-        let mut url = Url::parse(&format!(
+        let endpoint = format!(
             "http://{host}:{port}",
             host = self.host.as_url_host(),
             port = self.port()
-        ))
-        .context(ParseS3EndpointSnafu)?;
+        );
+        let mut url = Url::parse(&endpoint).context(ParseS3EndpointSnafu { endpoint })?;
 
         if self.tls.uses_tls() {
             url.set_scheme("https").map_err(|_| {
@@ -172,7 +174,9 @@ impl S3BucketInlineOrReference {
                 let bucket = client
                     .get::<S3Bucket>(&reference, namespace)
                     .await
-                    .context(RetrieveS3ConnectionSnafu)?
+                    .context(RetrieveS3ConnectionSnafu {
+                        s3_connection: reference,
+                    })?
                     .spec;
                 Ok(ResolvedS3Bucket {
                     bucket_name: bucket.bucket_name,

crates/stackable-operator/src/commons/s3/mod.rs

@@ -11,11 +11,17 @@ use super::{secret_class::SecretClassVolumeError, tls_verification::TlsClientDet
 
 #[derive(Debug, Snafu)]
 pub enum S3Error {
-    #[snafu(display("failed to retrieve S3 connection"))]
-    RetrieveS3Connection { source: crate::client::Error },
-
-    #[snafu(display("failed to parse S3 endpoint"))]
-    ParseS3Endpoint { source: url::ParseError },
+    #[snafu(display("failed to retrieve S3 connection '{s3_connection}'"))]
+    RetrieveS3Connection {
+        source: crate::client::Error,
+        s3_connection: String,
+    },
+
+    #[snafu(display("failed to parse S3 endpoint '{endpoint}'"))]
+    ParseS3Endpoint {
+        source: url::ParseError,
+        endpoint: String,
+    },
 
     #[snafu(display("failed to set S3 endpoint scheme '{scheme}' for endpoint '{endpoint}'"))]
     SetS3EndpointScheme { endpoint: Url, scheme: String },